From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Sharma, Swati2" <swati2.sharma@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
Date: Thu, 28 Feb 2019 17:09:19 +0100 [thread overview]
Message-ID: <33cf717c-9337-2aa7-4787-aafcc092892c@linux.intel.com> (raw)
In-Reply-To: <9872A5B702A4C6478FE7367F3B7CB4F725BB033F@BGSMSX101.gar.corp.intel.com>
Op 28-02-2019 om 15:07 schreef Sharma, Swati2:
> Hi Maarten,
>
> Thank you for the review :) When I made changes as you said, tests are getting skipped because of test reqt data.display.is_atomic not getting met.
>
> ./build/tests/kms_color --run-subtest pipe-A-ctm-red-to-blue
> IGT-Version: 1.23-g3f2aaed (x86_64) (Linux: 5.0.0-rc8+ x86_64)
> Test requirement not met in function __real_main1161, file ../tests/kms_color.c:1174:
> Test requirement: data.display.is_atomic
> Subtest pipe-A-ctm-red-to-blue: SKIP
What system?
If it's pre gen5, probably no big issue.
> Thanks and Regards,
> Swati
>
> -----Original Message-----
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Sent: Wednesday, February 13, 2019 8:45 PM
> To: Sharma, Swati2 <swati2.sharma@intel.com>; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
>
> Hey,
>
> Op 29-01-2019 om 15:08 schreef swati2.sharma@intel.com:
>> From: Swati Sharma <swati2.sharma@intel.com>
>>
>> Existing kms_color i-g-t, commit style by default is legacy for all
>> the ctm/gamma/degamma subtests.
>>
>> In this patch, provision for both legacy and atomic commit is
>> provided. Patch is floated as RFC to gather feedback on the idea and
>> infrastructure proposed.
>>
>> Other approach could be getting the value of is_atomic as done in
>> kms_available_modes_crc like data.commit = data.display.is_atomic ?
>> COMMIT_ATOMIC : COMMIT_LEGACY However with this approach we won't be
>> able to test both the paths.
>>
>> v1: As per Daniel's comments switching over to atomic.
>> v2: Rebase
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>
> Just do COMMIT_ATOMIC, and add igt_require(display.is_atomic), drivers should support it for this test. :)
>
> ~Maarten
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-02-28 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 14:08 [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style swati2.sharma
2019-01-29 15:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Change in commit style (rev4) Patchwork
2019-02-13 15:15 ` [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style Maarten Lankhorst via igt-dev
2019-02-28 14:07 ` Sharma, Swati2
2019-02-28 16:09 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33cf717c-9337-2aa7-4787-aafcc092892c@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox