From: Maarten Lankhorst via igt-dev <igt-dev@lists.freedesktop.org>
To: swati2.sharma@intel.com, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
Date: Wed, 13 Feb 2019 16:15:06 +0100 [thread overview]
Message-ID: <e6eb5c73-2370-4cc0-c5a8-f7205bc0ddfe@linux.intel.com> (raw)
In-Reply-To: <1548770932-13048-1-git-send-email-swati2.sharma@intel.com>
Hey,
Op 29-01-2019 om 15:08 schreef swati2.sharma@intel.com:
> From: Swati Sharma <swati2.sharma@intel.com>
>
> Existing kms_color i-g-t, commit style by default is legacy for
> all the ctm/gamma/degamma subtests.
>
> In this patch, provision for both legacy and atomic commit is
> provided. Patch is floated as RFC to gather feedback on the idea
> and infrastructure proposed.
>
> Other approach could be getting the value of is_atomic as done in
> kms_available_modes_crc like
> data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY
> However with this approach we won't be able to test both the paths.
>
> v1: As per Daniel's comments switching over to atomic.
> v2: Rebase
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Just do COMMIT_ATOMIC, and add igt_require(display.is_atomic), drivers should support it for this test. :)
~Maarten
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-13 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 14:08 [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style swati2.sharma
2019-01-29 15:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Change in commit style (rev4) Patchwork
2019-02-13 15:15 ` Maarten Lankhorst via igt-dev [this message]
2019-02-28 14:07 ` [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style Sharma, Swati2
2019-02-28 16:09 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6eb5c73-2370-4cc0-c5a8-f7205bc0ddfe@linux.intel.com \
--to=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox