From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario
Date: Tue, 26 Sep 2023 11:28:30 +0530 [thread overview]
Message-ID: <36072188-701d-42de-2c73-76b0af077b65@intel.com> (raw)
In-Reply-To: <20230922151937.1188567-1-jeevan.b@intel.com>
Please change subject to "Add comment for valid scenario"
Remaining LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 22-Sep-23 8:49 PM, Jeevan B wrote:
> Describe the valid scenario for 'basic-clone-single-crtc' and
> 'basic-clone-single-crtc' tests, as these tests are skipped if
> a valid scenario is not found, which can cause confusion during
> bug analysis.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> cc: Swati Sharma <swati2.sharma@intel.com>
> ---
> tests/kms_setmode.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index 32a6fb690..a669cc1df 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -979,6 +979,14 @@ const char *help_str =
> " -t <test id>\tRun only the test with this id\n"
> " -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
>
> +/*
> + * basic-clone-single-crtc allows the use of a single CRTC for two connectors, such as VGA/HDMI,
> + * VGA/DP, and HDMI/HDMI, which are the possible combinations. Similarly, for invalid-clone-exclusive-crtc,
> + * when a connector uses a CRTC that is not compatible with the connector, for instance, DP/HDMI
> + * can be used on certain pipes on old platforms.
> + */
> +
> +
> igt_main_args("det:", NULL, help_str, opt_handler, NULL)
> {
> const struct {
next prev parent reply other threads:[~2023-09-26 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:19 [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario Jeevan B
2023-09-22 18:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_setmode: Add info as comment for valid scenario (rev3) Patchwork
2023-09-22 18:42 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-09-23 20:32 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-26 5:58 ` Sharma, Swati2 [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-20 10:31 [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario Jeevan B
2023-09-20 6:08 Jeevan B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36072188-701d-42de-2c73-76b0af077b65@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox