From: Lyude Paul <lyude@redhat.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Use glib's regex utilities instead of POSIX ERE
Date: Fri, 10 May 2019 11:57:11 -0400 [thread overview]
Message-ID: <365fdfba703a6faf60ccca33699eac3678180696.camel@redhat.com> (raw)
In-Reply-To: <20190510092235.GJ22949@platvala-desk.ger.corp.intel.com>
On Fri, 2019-05-10 at 12:22 +0300, Petri Latvala wrote:
> On Thu, May 09, 2019 at 08:06:04PM -0400, Lyude wrote:
> > From: Lyude Paul <lyude@redhat.com>
> >
> > POSIX ERE, while pretty standard is also very old and severely limited.
> > In fact, it's so limited that Intel CI's own test blacklist,
> > tests/intel-ci/blacklist.txt, doesn't even work with it due to the lack
> > of support for backreferences.
>
> Side note: Even with these changes, nothing can currently eat
> blacklist.txt as is. Sitting tightly in my TODO is to implement the
> final piece of the pipeline that CI uses piglit for with igt_runner,
> scripts/run-tests.sh -l, with something that can process
> blacklist.txt. These changes are the first step towards that, thanks
> for doing this.
>
> In other words, this doesn't implement what I guess you're trying to
> do but it's needed, so
sidenote: I have an ansible playbook I use for processing the blacklist as
well, when I was referring to the intel-ci blacklist I was just referring to
the actual entries in it - I'm aware this doesn't let you pass the blacklist
directly to igt! But, I figured having behavior like this would enable
something like you're trying to do and make us more consistent with piglit
anyway
Anyway-thanks for the review! will push in a moment
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-05-10 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 0:06 [igt-dev] [PATCH i-g-t] runner: Use glib's regex utilities instead of POSIX ERE Lyude
2019-05-10 0:43 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-10 6:55 ` [igt-dev] [PATCH i-g-t] " Ser, Simon
2019-05-10 9:05 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2019-05-10 9:22 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-05-10 15:57 ` Lyude Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365fdfba703a6faf60ccca33699eac3678180696.camel@redhat.com \
--to=lyude@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox