public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: Arun R Murthy <arun.r.murthy@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/6] tests/kms_async_flips: Render the bars full height
Date: Thu, 9 Feb 2023 19:41:27 +0530	[thread overview]
Message-ID: <37e15e57-6da1-2e5d-fba4-314ba79a3f62@intel.com> (raw)
In-Reply-To: <20230131120646.27434-3-ville.syrjala@linux.intel.com>

LTGM.

On 1/31/2023 5:36 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Make the colored bars full height so that we can actually see
> the async flip activity on every scanline, as opposed to just
> being able to see it in the middle of the screen.
>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_async_flips.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 89e431ac32e2..55be0bd874ad 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -133,7 +133,7 @@ static void make_fb(data_t *data, struct igt_fb *fb,
>   	}
>   
>   	cr = igt_get_cairo_ctx(data->drm_fd, fb);
> -	igt_paint_color_rand(cr, rec_width * 2 + rec_width * index, height / 4, rec_width, height / 2);
> +	igt_paint_color_rand(cr, rec_width * 2 + rec_width * index, 0, rec_width, height);
>   	igt_put_cairo_ctx(cr);
>   }
>   

  reply	other threads:[~2023-02-09 14:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 12:06 [igt-dev] [PATCH i-g-t 0/6] tests/kms_async_flips: Test format modifiers Ville Syrjala
2023-01-31 12:06 ` [igt-dev] [PATCH i-g-t 1/6] tests/kms_async_flips: Add missing igt_put_cairo_ctx() Ville Syrjala
2023-02-02 11:03   ` Murthy, Arun R
2023-01-31 12:06 ` [igt-dev] [PATCH i-g-t 2/6] tests/kms_async_flips: Render the bars full height Ville Syrjala
2023-02-09 14:11   ` Karthik B S [this message]
2023-01-31 12:06 ` [igt-dev] [PATCH i-g-t 3/6] tests/kms_async_flips: Ger rid of i915 specific fb creation Ville Syrjala
2023-02-02 11:24   ` Murthy, Arun R
2023-05-15  9:13   ` Murthy, Arun R
2023-01-31 12:06 ` [igt-dev] [PATCH i-g-t 4/6] tests/kms_async_flips: Run the test only once per pipe Ville Syrjala
2023-01-31 12:21   ` Modem, Bhanuprakash
2023-02-02  9:27     ` Ville Syrjälä
2023-02-02 11:25   ` Murthy, Arun R
2023-01-31 12:06 ` [igt-dev] [PATCH i-g-t 5/6] tests/kms_async_flips: Split test_init() Ville Syrjala
2023-05-15  9:10   ` Murthy, Arun R
2023-01-31 12:06 ` [igt-dev] [PATCH i-g-t 6/6] tests/kms_async_flips: Test all modifiers Ville Syrjala
2023-02-02 11:23   ` Murthy, Arun R
2023-02-02 12:15     ` Ville Syrjälä
2023-02-02 12:24       ` Murthy, Arun R
2023-02-03 12:32         ` Ville Syrjälä
2023-02-07  5:49           ` Murthy, Arun R
2023-05-15  9:07             ` Murthy, Arun R
2023-02-03 12:29     ` Ville Syrjälä
2023-02-07  5:41       ` Murthy, Arun R
2023-01-31 12:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_async_flips: Test format modifiers Patchwork
2023-01-31 16:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37e15e57-6da1-2e5d-fba4-314ba79a3f62@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox