Re: [igt-dev] [PATCH i-g-t 4/6] tests/kms_async_flips: Run the test only once per pipe

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Jan 31, 2023 at 05:51:22PM +0530, Modem, Bhanuprakash wrote:
> Hi Ville,
> 
> On Tue-31-01-2023 05:36 pm, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > No real reason to iterate over all the outputs here. Just
> > do the test once per pipe.
> > 
> > Cc: Arun R Murthy <arun.r.murthy@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >   tests/kms_async_flips.c | 18 +++++-------------
> >   1 file changed, 5 insertions(+), 13 deletions(-)
> > 
> > diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> > index f8c97e029c59..54611f66350d 100644
> > --- a/tests/kms_async_flips.c
> > +++ b/tests/kms_async_flips.c
> > @@ -544,20 +544,12 @@ static void test_crc(data_t *data)
> >   
> >   static void run_test(data_t *data, void (*test)(data_t *))
> >   {
> > -	igt_output_t *output;
> > -	enum pipe pipe;
> > +	for_each_pipe_with_valid_output(&data->display, data->pipe, data->output) {
> 
> If data->extended is true, it'll iterate over all outputs. Maybe we can 
> use for_each_pipe_with_single_output() to run test once per pipe.

Hmm. After further thought it might still be nice to iterate all
outputs, in case we have output specific stuff (eg. PSR) that
could affect the behaviour or async flips. In which case I suppose
we need to keep including the output name in the test name.

> 
> - Bhanu
> 
> > +		igt_dynamic_f("pipe-%s", kmstest_pipe_name(data->pipe))
> > +			test(data);
> >   
> > -	for_each_pipe(&data->display, pipe) {
> > -		for_each_valid_output_on_pipe(&data->display, pipe, output) {
> > -			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
> > -				data->output = output;
> > -				data->pipe = pipe;
> > -				test(data);
> > -			}
> > -
> > -			if (!data->extended)
> > -				break;
> > -		}
> > +		if (!data->extended)
> > +			break;
> >   	}
> >   }
> >   

-- 
Ville Syrjälä
Intel