Re: [PATCH 1/2] tests/amdgpu: Fix typos and grammar in test files

[Karthik B S <karthik.b.s@intel.com>]

On 4/17/2026 5:51 AM, Alex Hung wrote:
> Fix various typos and grammar errors across multiple AMDGPU
> test files:
> - amd_abm: "amdpgu" -> "amdgpu", fix grammar in comment
> - amd_assr: add missing article, remove trailing spaces
> - amd_color: "amdpgu" -> "amdgpu", "liner" -> "linear",
>    fix incorrect "degamma" comment in regamma function
> - amd_plane: "backgroud" -> "background",
>    "overley" -> "overlay", "beacause" -> "because",
>    fix wrong size notation and misleading comment
> - amd_vrr_range: "gange" -> "range" in function name
>
> Assisted-by: GitHub Copilot:Claude Opus 4.6
> Signed-off-by: Alex Hung <alex.hung@amd.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/amdgpu/amd_abm.c       |  4 ++--
>   tests/amdgpu/amd_assr.c      |  6 +++---
>   tests/amdgpu/amd_color.c     |  6 +++---
>   tests/amdgpu/amd_plane.c     | 14 +++++++-------
>   tests/amdgpu/amd_vrr_range.c |  4 ++--
>   5 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index d36044aab..207d075b0 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -128,7 +128,7 @@ static void test_init(data_t *data)
>   	if (!has_edp)
>   		igt_skip("No eDP connector found\n");
>   
> -	/* It doesn't matter which pipe we choose on amdpgu. */
> +	/* It doesn't matter which pipe we choose on amdgpu. */
>   	data->crtc = igt_first_crtc(&data->display);
>   
>   	igt_display_reset(display);
> @@ -169,7 +169,7 @@ static void test_fini(data_t *data)
>   	igt_display_t *display = &data->display;
>   	igt_output_t *output;
>   
> -	/* Disable ABM before exit test */
> +	/* Disable ABM before exiting the test */
>   	for_each_valid_output_on_crtc(&data->display,
>   				      data->crtc,
>   				      output) {
> diff --git a/tests/amdgpu/amd_assr.c b/tests/amdgpu/amd_assr.c
> index b07f3fb15..71209e79f 100644
> --- a/tests/amdgpu/amd_assr.c
> +++ b/tests/amdgpu/amd_assr.c
> @@ -29,7 +29,7 @@
>   #include <sys/stat.h>
>   
>   IGT_TEST_DESCRIPTION("Check if ASSR is enabled on eDP links that support "
> -		     "the display authentication by changing scrambling sequence. "
> +		     "the display authentication by changing the scrambling sequence. "
>   		     "The test also covers embedded and non-removable "
>   		     "displays that appear as DP.");
>   
> @@ -285,10 +285,10 @@ int igt_main()
>   	igt_describe("Test ASSR on connected DP/eDP links");
>   	igt_subtest("assr-links")
>   		test_assr_links(&data, TEST_NONE);
> -	igt_describe("Test ASSR with DPMS ");
> +	igt_describe("Test ASSR with DPMS");
>   	igt_subtest("assr-links-dpms")
>   		test_assr_links(&data, TEST_DPMS);
> -	igt_describe("Test ASSR with suspend ");
> +	igt_describe("Test ASSR with suspend");
>   	igt_subtest("assr-links-suspend")
>   		test_assr_links(&data, TEST_SUSPEND);
>   
> diff --git a/tests/amdgpu/amd_color.c b/tests/amdgpu/amd_color.c
> index 68f541d64..eb1eb581a 100644
> --- a/tests/amdgpu/amd_color.c
> +++ b/tests/amdgpu/amd_color.c
> @@ -177,7 +177,7 @@ static void test_init(data_t *data)
>   {
>   	igt_display_t *display = &data->display;
>   
> -	/* It doesn't matter which pipe we choose on amdpgu. */
> +	/* It doesn't matter which pipe we choose on amdgpu. */
>   	data->crtc = igt_first_crtc(&data->display);
>   
>   	igt_display_reset(display);
> @@ -262,7 +262,7 @@ static void test_crtc_linear_degamma(data_t *data)
>    * sRGB regamma matrix with incorrect calculations or rounding errors.
>    * If we put the pipe into bypass or use the hardware defined sRGB regamma
>    * on the plane then we can and should get the correct CRTC when passing a
> - * liner regamma matrix to DRM.
> + * linear regamma matrix to DRM.
>    */
>   static void test_crtc_linear_regamma(data_t *data)
>   {
> @@ -291,7 +291,7 @@ static void test_crtc_linear_regamma(data_t *data)
>   
>   	igt_pipe_crc_collect_crc(data->pipe_crc, &ref_crc);
>   
> -	/* Apply a linear degamma. The result should remain the same. */
> +	/* Apply a linear regamma. The result should remain the same. */
>   	set_regamma_lut(data, &lut_linear);
>   	igt_display_commit_atomic(display, 0, NULL);
>   
> diff --git a/tests/amdgpu/amd_plane.c b/tests/amdgpu/amd_plane.c
> index 412a220b2..e63d4dc2f 100644
> --- a/tests/amdgpu/amd_plane.c
> +++ b/tests/amdgpu/amd_plane.c
> @@ -366,14 +366,14 @@ static void test_multi_overlay(data_t *data, int display_count, int w, int h, st
>   }
>   
>   /*
> - * Compares the result of white backgroud with white window with and without MPO
> + * Compares the result of white background with white window with and without MPO
>    *
>    * Reference crc:
>    * Draws a White background of size (pw,ph).
>    *
>    * Test crc:
> - * Draws a White Overlay of size (pw,ph) then creates a cutout of size (p,w) at location (x,y)
> - * Draws a White Primary plane of size (p,w) at location (x,y) (under the overlay)
> + * Draws a White Overlay of size (pw,ph) then creates a cutout of size (dw,dh) at location (x,y)
> + * Draws a White Primary plane of size (dw,dh) at location (x,y) (under the overlay)
>    *
>    * NOTE: The reason for using White+White is to speed up the crc (reuse the ref crc for all cases vs taking
>    * a ref crc per flip)
> @@ -400,7 +400,7 @@ static void test_plane(data_t *data, int n, int x, int y, double w, double h, do
>   	igt_plane_set_fb(data->primary[n], &fbc[n].test_primary);
>   	igt_plane_set_fb(data->overlay[n], &fbc[n].test_overlay);
>   
> -	/* Move the overlay to cover the cutout */
> +	/* Move the primary to cover the cutout */
>   	igt_plane_set_position(data->primary[n], x, y);
>   	igt_plane_set_size(data->primary[n], dw, dh);
>   
> @@ -451,7 +451,7 @@ static void test_panning_1_display(data_t *data, int display_count, int w, int h
>   				int x = dx*j*dir[i][0];
>   				int y = dy*j*dir[i][1];
>   
> -				/* No need to pan a overley that is bigger than the display */
> +				/* No need to pan an overlay that is bigger than the display */
>   				if (pw <= w && ph <= h)
>   					break;
>   
> @@ -491,7 +491,7 @@ static void test_scaling_planes(data_t *data, int display_count, int w, int h, s
>   		int ph = data->h[n];
>   
>   		for (int i=0;i<ARRAY_SIZE(scale);i++) {
> -			/* No need to scale a overley that is bigger than the display */
> +			/* No need to scale an overlay that is bigger than the display */
>   			if (pw <= w*scale[i] && ph <= h*scale[i])
>   				break;
>   			test_plane(data, n, 0, 0, w, h, w*scale[i], h*scale[i], pw, ph, fb);
> @@ -523,7 +523,7 @@ static void test_panning_2_display(data_t *data, int w, int h, struct fbc *fbc)
>   	int it = 3; /* # of times to swap */
>   
>   	/* Set y to 0 if window is bigger than one of the displays
> -	 * beacause y will be negative in that case
> +	 * because y will be negative in that case
>   	 */
>   	if (h >= smallest_h)
>   		y[0] = y[1] = y[2] = 0;
> diff --git a/tests/amdgpu/amd_vrr_range.c b/tests/amdgpu/amd_vrr_range.c
> index 4397f3c15..0312e22c2 100644
> --- a/tests/amdgpu/amd_vrr_range.c
> +++ b/tests/amdgpu/amd_vrr_range.c
> @@ -260,7 +260,7 @@ static bool has_vrr(igt_output_t *output)
>   	       igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE);
>   }
>   
> -static void parse_vrr_gange_from_edid(data_t *data, uint8_t *edid, int index)
> +static void parse_vrr_range_from_edid(data_t *data, uint8_t *edid, int index)
>   {
>   	bool max_rate_offset = false;
>   	bool min_rate_offset = false;
> @@ -314,7 +314,7 @@ static bool find_vrr_range_from_edid(data_t *data, igt_output_t *output)
>   				break;
>   			else if (i == range_head_size-1) {
>   				/* Found Display Range Limits Descriptor block */
> -				parse_vrr_gange_from_edid(data, sink_edid, index);
> +				parse_vrr_range_from_edid(data, sink_edid, index);
>   				return true;
>   			}
>   		}