public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <aurabindo.pillai@amd.com>, Alex Hung <alex.hung@amd.com>
Subject: [PATCH 2/2] tests/amdgpu/amd_plane: Remove unused parameters from test_plane()
Date: Thu, 16 Apr 2026 18:21:16 -0600	[thread overview]
Message-ID: <20260417002116.94208-2-alex.hung@amd.com> (raw)
In-Reply-To: <20260417002116.94208-1-alex.hung@amd.com>

Remove unused w and h parameters from test_plane() in
amd_plane. These parameters were never referenced inside
the function body; only dw and dh are used for the cutout
and primary plane sizing. Update all call sites accordingly.

Assisted-by: GitHub Copilot:Claude Opus 4.6
Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 tests/amdgpu/amd_plane.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/amdgpu/amd_plane.c b/tests/amdgpu/amd_plane.c
index e63d4dc2f..9a08f8e29 100644
--- a/tests/amdgpu/amd_plane.c
+++ b/tests/amdgpu/amd_plane.c
@@ -378,7 +378,7 @@ static void test_multi_overlay(data_t *data, int display_count, int w, int h, st
  * NOTE: The reason for using White+White is to speed up the crc (reuse the ref crc for all cases vs taking
  * a ref crc per flip)
  */
-static void test_plane(data_t *data, int n, int x, int y, double w, double h, double dw, double dh, int pw, int ph, struct fbc *fbc){
+static void test_plane(data_t *data, int n, int x, int y, double dw, double dh, int pw, int ph, struct fbc *fbc){
 
 	igt_crc_t test_crc;
 	igt_display_t *display = &data->display;
@@ -455,7 +455,7 @@ static void test_panning_1_display(data_t *data, int display_count, int w, int h
 				if (pw <= w && ph <= h)
 					break;
 
-				test_plane(data, n, x, y, w, h, w, h, pw, ph, fb);
+				test_plane(data, n, x, y, w, h, pw, ph, fb);
 
 			}
 		}
@@ -494,11 +494,11 @@ static void test_scaling_planes(data_t *data, int display_count, int w, int h, s
 			/* No need to scale an overlay that is bigger than the display */
 			if (pw <= w*scale[i] && ph <= h*scale[i])
 				break;
-			test_plane(data, n, 0, 0, w, h, w*scale[i], h*scale[i], pw, ph, fb);
+			test_plane(data, n, 0, 0, w*scale[i], h*scale[i], pw, ph, fb);
 		}
 
 		/* Test Fullscreen scale*/
-		test_plane(data, n, 0, 0, w, h, pw, ph, pw, ph, fb);
+		test_plane(data, n, 0, 0, pw, ph, pw, ph, fb);
 	}
 
 	return;
@@ -532,9 +532,9 @@ static void test_panning_2_display(data_t *data, int w, int h, struct fbc *fbc)
 	for (int j = 0; j < ARRAY_SIZE(y); j++){
 		for (int i = 0; i < it; i++){
 			if (toggle)
-				test_plane(data, 0, pw-w, y[j], w, h, w, h, pw, ph, fbc);
+				test_plane(data, 0, pw-w, y[j], w, h, pw, ph, fbc);
 			else
-				test_plane(data, 1, 0, y[j], w, h, w, h, pw2, ph2, fbc);
+				test_plane(data, 1, 0, y[j], w, h, pw2, ph2, fbc);
 
 			toggle = !toggle;
 		}
-- 
2.43.0


  reply	other threads:[~2026-04-17  0:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  0:21 [PATCH 1/2] tests/amdgpu: Fix typos and grammar in test files Alex Hung
2026-04-17  0:21 ` Alex Hung [this message]
2026-04-17  3:26   ` [PATCH 2/2] tests/amdgpu/amd_plane: Remove unused parameters from test_plane() Karthik B S
2026-04-17  2:51 ` ✓ i915.CI.BAT: success for series starting with [1/2] tests/amdgpu: Fix typos and grammar in test files Patchwork
2026-04-17  3:16 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-17  3:25 ` [PATCH 1/2] " Karthik B S
2026-04-17  5:42 ` ✗ Xe.CI.FULL: failure for series starting with [1/2] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417002116.94208-2-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=aurabindo.pillai@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox