From: "Kulkarni, Vandita" <vandita.kulkarni@intel.com>
To: "B S, Karthik" <karthik.b.s@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Joshi, Kunal1" <kunal1.joshi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output
Date: Mon, 14 Jun 2021 09:47:48 +0000 [thread overview]
Message-ID: <3c9716b4408c43d09b6a81c47ce96a49@intel.com> (raw)
In-Reply-To: <20210614082746.7951-1-karthik.b.s@intel.com>
> -----Original Message-----
> From: B S, Karthik <karthik.b.s@intel.com>
> Sent: Monday, June 14, 2021 1:58 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Kulkarni, Vandita <vandita.kulkarni@intel.com>; Joshi, Kunal1
> <kunal1.joshi@intel.com>; B S, Karthik <karthik.b.s@intel.com>
> Subject: [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output
>
> Use 'output' here rather than 'data->output' as it is still not populated.
>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/3494
Fixes - patch that introduced this
Closes - issue id
With that fixed,
LGTM.
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Thanks,
Vandita
>
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/kms_dp_dsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c index
> 2446fd82..12180b19 100644
> --- a/tests/kms_dp_dsc.c
> +++ b/tests/kms_dp_dsc.c
> @@ -228,7 +228,7 @@ static void run_test(data_t *data, igt_output_t
> *output, {
> enum pipe pipe;
>
> - data->mode = igt_output_get_mode(data->output);
> + data->mode = igt_output_get_mode(output);
> igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay,
> data->mode->vdisplay,
> DRM_FORMAT_XRGB8888,
> --
> 2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-06-14 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 8:27 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output Karthik B S
2021-06-14 9:47 ` Kulkarni, Vandita [this message]
2021-06-14 10:04 ` Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c9716b4408c43d09b6a81c47ce96a49@intel.com \
--to=vandita.kulkarni@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox