* [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output @ 2021-06-14 8:27 Karthik B S 2021-06-14 9:47 ` Kulkarni, Vandita 0 siblings, 1 reply; 3+ messages in thread From: Karthik B S @ 2021-06-14 8:27 UTC (permalink / raw) To: igt-dev; +Cc: kunal1.joshi Use 'output' here rather than 'data->output' as it is still not populated. Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/3494 Signed-off-by: Karthik B S <karthik.b.s@intel.com> --- tests/kms_dp_dsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c index 2446fd82..12180b19 100644 --- a/tests/kms_dp_dsc.c +++ b/tests/kms_dp_dsc.c @@ -228,7 +228,7 @@ static void run_test(data_t *data, igt_output_t *output, { enum pipe pipe; - data->mode = igt_output_get_mode(data->output); + data->mode = igt_output_get_mode(output); igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay, data->mode->vdisplay, DRM_FORMAT_XRGB8888, -- 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output 2021-06-14 8:27 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output Karthik B S @ 2021-06-14 9:47 ` Kulkarni, Vandita 2021-06-14 10:04 ` Karthik B S 0 siblings, 1 reply; 3+ messages in thread From: Kulkarni, Vandita @ 2021-06-14 9:47 UTC (permalink / raw) To: B S, Karthik, igt-dev@lists.freedesktop.org; +Cc: Joshi, Kunal1 > -----Original Message----- > From: B S, Karthik <karthik.b.s@intel.com> > Sent: Monday, June 14, 2021 1:58 PM > To: igt-dev@lists.freedesktop.org > Cc: Kulkarni, Vandita <vandita.kulkarni@intel.com>; Joshi, Kunal1 > <kunal1.joshi@intel.com>; B S, Karthik <karthik.b.s@intel.com> > Subject: [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output > > Use 'output' here rather than 'data->output' as it is still not populated. > > Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/3494 Fixes - patch that introduced this Closes - issue id With that fixed, LGTM. Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com> Thanks, Vandita > > Signed-off-by: Karthik B S <karthik.b.s@intel.com> > --- > tests/kms_dp_dsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c index > 2446fd82..12180b19 100644 > --- a/tests/kms_dp_dsc.c > +++ b/tests/kms_dp_dsc.c > @@ -228,7 +228,7 @@ static void run_test(data_t *data, igt_output_t > *output, { > enum pipe pipe; > > - data->mode = igt_output_get_mode(data->output); > + data->mode = igt_output_get_mode(output); > igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay, > data->mode->vdisplay, > DRM_FORMAT_XRGB8888, > -- > 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output 2021-06-14 9:47 ` Kulkarni, Vandita @ 2021-06-14 10:04 ` Karthik B S 0 siblings, 0 replies; 3+ messages in thread From: Karthik B S @ 2021-06-14 10:04 UTC (permalink / raw) To: Kulkarni, Vandita, igt-dev@lists.freedesktop.org; +Cc: Joshi, Kunal1 On 6/14/2021 3:17 PM, Kulkarni, Vandita wrote: >> -----Original Message----- >> From: B S, Karthik <karthik.b.s@intel.com> >> Sent: Monday, June 14, 2021 1:58 PM >> To: igt-dev@lists.freedesktop.org >> Cc: Kulkarni, Vandita <vandita.kulkarni@intel.com>; Joshi, Kunal1 >> <kunal1.joshi@intel.com>; B S, Karthik <karthik.b.s@intel.com> >> Subject: [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output >> >> Use 'output' here rather than 'data->output' as it is still not populated. >> >> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/3494 > Fixes - patch that introduced this > Closes - issue id > With that fixed, > LGTM. > Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com> Thank you for the rb. I will update the patch accordingly. Thanks, Karthik.B.S > > Thanks, > Vandita >> Signed-off-by: Karthik B S <karthik.b.s@intel.com> >> --- >> tests/kms_dp_dsc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c index >> 2446fd82..12180b19 100644 >> --- a/tests/kms_dp_dsc.c >> +++ b/tests/kms_dp_dsc.c >> @@ -228,7 +228,7 @@ static void run_test(data_t *data, igt_output_t >> *output, { >> enum pipe pipe; >> >> - data->mode = igt_output_get_mode(data->output); >> + data->mode = igt_output_get_mode(output); >> igt_create_pattern_fb(data->drm_fd, data->mode->hdisplay, >> data->mode->vdisplay, >> DRM_FORMAT_XRGB8888, >> -- >> 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-14 10:04 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-14 8:27 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Assign the proper output Karthik B S 2021-06-14 9:47 ` Kulkarni, Vandita 2021-06-14 10:04 ` Karthik B S
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox