Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Op 16-03-18 om 07:29 schreef Lofstedt, Marta:
> I would RB this if there was some kms_frontbuffer_tracking PSR related tests that was run on PW.
>
> Could you re-send this together with a HACK patch on fast-feedback.testlist where you replace the standard tests with some kms_frontbuffer_tracking PSR related tests that was hit on the bug?
>
Same..

Link standby mode only matches the dev_priv->link_standby parameter not the actual hw mode, so this patch is

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> -----Original Message-----
>> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of
>> Dhinakaran Pandiyan
>> Sent: Friday, March 16, 2018 3:21 AM
>> To: igt-dev@lists.freedesktop.org
>> Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo
>> <rodrigo.vivi@intel.com>
>> Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update
>> check for PSR status
>>
>> Kernel does not expose the "Active: " flag in edp_psr_status anymore.
>> So test for "HW Enabled & Active bit: yes", although this isn't completely
>> accurate either for frontbuffer tests. Let's go with this for now until the
>> kernel exposes HW PSR status.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519
>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> ---
>>  tests/kms_fbcon_fbt.c            | 2 +-
>>  tests/kms_frontbuffer_tracking.c | 3 +--
>>  2 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index
>> b01c769c..280ddbd7 100644
>> --- a/tests/kms_fbcon_fbt.c
>> +++ b/tests/kms_fbcon_fbt.c
>> @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd)
>>  	char buf[256];
>>
>>  	igt_debugfs_read(fd, "i915_edp_psr_status", buf);
>> -	return strstr(buf, "\nActive: yes\n");
>> +	return strstr(buf, "\nHW Enabled & Active bit: yes\n");
>>  }
>>
>>  static bool psr_wait_until_enabled(int fd) diff --git
>> a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
>> index 2b85392d..5cba4158 100644
>> --- a/tests/kms_frontbuffer_tracking.c
>> +++ b/tests/kms_frontbuffer_tracking.c
>> @@ -781,8 +781,7 @@ static bool psr_is_enabled(void)
>>  	char buf[256];
>>
>>  	debugfs_read("i915_edp_psr_status", buf);
>> -	return strstr(buf, "\nActive: yes\n") &&
>> -	       strstr(buf, "\nHW Enabled & Active bit: yes\n");
>> +	return strstr(buf, "\nHW Enabled & Active bit: yes\n");
>>  }
>>
>>  static void psr_print_status(void)
>> --
>> 2.14.1
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev