Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Op 16-03-18 om 02:21 schreef Dhinakaran Pandiyan:
> Kernel does not expose the "Active: " flag in edp_psr_status anymore.
> So test for "HW Enabled & Active bit: yes", although this isn't completely
> accurate either for frontbuffer tests. Let's go with this for now until
> the kernel exposes HW PSR status.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/kms_fbcon_fbt.c            | 2 +-
>  tests/kms_frontbuffer_tracking.c | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
> index b01c769c..280ddbd7 100644
> --- a/tests/kms_fbcon_fbt.c
> +++ b/tests/kms_fbcon_fbt.c
> @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd)
>  	char buf[256];
>  
>  	igt_debugfs_read(fd, "i915_edp_psr_status", buf);
> -	return strstr(buf, "\nActive: yes\n");
> +	return strstr(buf, "\nHW Enabled & Active bit: yes\n");
>  }
>  
>  static bool psr_wait_until_enabled(int fd)
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 2b85392d..5cba4158 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -781,8 +781,7 @@ static bool psr_is_enabled(void)
>  	char buf[256];
>  
>  	debugfs_read("i915_edp_psr_status", buf);
> -	return strstr(buf, "\nActive: yes\n") &&
> -	       strstr(buf, "\nHW Enabled & Active bit: yes\n");
> +	return strstr(buf, "\nHW Enabled & Active bit: yes\n");
>  }
>  
>  static void psr_print_status(void)

Hey,

If enable_psr is set to link standby, won't "Main link in standby mode: yes" also be a valid way of entering PSR?

This is probably the case for HSW, I've sent my own patch for this..

https://patchwork.freedesktop.org/patch/211060/

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev