* [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status
@ 2018-03-16 1:21 Dhinakaran Pandiyan
2018-03-16 1:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Dhinakaran Pandiyan @ 2018-03-16 1:21 UTC (permalink / raw)
To: igt-dev; +Cc: Dhinakaran Pandiyan, Rodrigo Vivi
Kernel does not expose the "Active: " flag in edp_psr_status anymore.
So test for "HW Enabled & Active bit: yes", although this isn't completely
accurate either for frontbuffer tests. Let's go with this for now until
the kernel exposes HW PSR status.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
tests/kms_fbcon_fbt.c | 2 +-
tests/kms_frontbuffer_tracking.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index b01c769c..280ddbd7 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd)
char buf[256];
igt_debugfs_read(fd, "i915_edp_psr_status", buf);
- return strstr(buf, "\nActive: yes\n");
+ return strstr(buf, "\nHW Enabled & Active bit: yes\n");
}
static bool psr_wait_until_enabled(int fd)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 2b85392d..5cba4158 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -781,8 +781,7 @@ static bool psr_is_enabled(void)
char buf[256];
debugfs_read("i915_edp_psr_status", buf);
- return strstr(buf, "\nActive: yes\n") &&
- strstr(buf, "\nHW Enabled & Active bit: yes\n");
+ return strstr(buf, "\nHW Enabled & Active bit: yes\n");
}
static void psr_print_status(void)
--
2.14.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-16 1:21 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status Dhinakaran Pandiyan @ 2018-03-16 1:41 ` Patchwork 2018-03-16 3:11 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2018-03-16 1:41 UTC (permalink / raw) To: Pandiyan, Dhinakaran; +Cc: igt-dev == Series Details == Series: tests/kms_frontbuffer_tracking: Update check for PSR status URL : https://patchwork.freedesktop.org/series/40070/ State : success == Summary == IGT patchset tested on top of latest successful build 2e92134b4e4f754239f9721b8781ce2fc0aab07c tests/kms_frontbuffer_tracking: Reduce fbc status spam, v2. with latest DRM-Tip kernel build CI_DRM_3935 9ac56f76a6a2 drm-tip: 2018y-03m-15d-22h-52m-42s UTC integration manifest No testlist changes. ---- Known issues: Test gem_mmap_gtt: Subgroup basic-small-bo-tiledx: pass -> FAIL (fi-gdg-551) fdo#102575 Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-b: pass -> INCOMPLETE (fi-snb-2520m) fdo#103713 fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575 fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:429s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:441s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:379s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:539s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:296s fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:515s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:518s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:505s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:408s fi-cfl-s2 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:580s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:508s fi-cnl-drrs total:285 pass:254 dwarn:3 dfail:0 fail:0 skip:28 time:525s fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:598s fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:417s fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:318s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:539s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:401s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:421s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:464s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:427s fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:474s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:469s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:514s fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:656s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:441s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:532s fi-skl-6700hq total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:540s fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:510s fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:505s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:427s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:446s fi-snb-2520m total:242 pass:208 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:400s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1142/issues.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: warning for tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-16 1:21 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status Dhinakaran Pandiyan 2018-03-16 1:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2018-03-16 3:11 ` Patchwork 2018-03-16 6:29 ` [igt-dev] [PATCH i-g-t] " Lofstedt, Marta 2018-03-16 16:19 ` Maarten Lankhorst 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2018-03-16 3:11 UTC (permalink / raw) To: Pandiyan, Dhinakaran; +Cc: igt-dev == Series Details == Series: tests/kms_frontbuffer_tracking: Update check for PSR status URL : https://patchwork.freedesktop.org/series/40070/ State : warning == Summary == ---- Possible new issues: Test gem_tiled_swapping: Subgroup non-threaded: skip -> PASS (shard-snb) Test kms_draw_crc: Subgroup draw-method-xrgb2101010-blt-xtiled: skip -> PASS (shard-snb) Test kms_universal_plane: Subgroup cursor-fb-leak-pipe-a: pass -> SKIP (shard-snb) ---- Known issues: Test gem_eio: Subgroup in-flight-external: incomplete -> PASS (shard-apl) fdo#105341 Test gem_exec_suspend: Subgroup basic-s3: skip -> PASS (shard-snb) fdo#104311 Test kms_cursor_crc: Subgroup cursor-256x256-suspend: pass -> SKIP (shard-snb) fdo#103375 Test kms_flip: Subgroup 2x-flip-vs-expired-vblank-interruptible: fail -> PASS (shard-hsw) fdo#102887 +1 Subgroup 2x-plain-flip-ts-check: fail -> PASS (shard-hsw) fdo#100368 Test kms_plane_multiple: Subgroup atomic-pipe-a-tiling-x: fail -> PASS (shard-snb) fdo#103166 Test kms_vblank: Subgroup pipe-a-accuracy-idle: pass -> FAIL (shard-hsw) fdo#102583 fdo#105341 https://bugs.freedesktop.org/show_bug.cgi?id=105341 fdo#104311 https://bugs.freedesktop.org/show_bug.cgi?id=104311 fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887 fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166 fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583 shard-apl total:3442 pass:1814 dwarn:1 dfail:0 fail:7 skip:1619 time:13093s shard-hsw total:3442 pass:1766 dwarn:1 dfail:0 fail:3 skip:1671 time:11883s shard-snb total:3442 pass:1355 dwarn:1 dfail:0 fail:3 skip:2083 time:7205s Blacklisted hosts: shard-kbl total:2134 pass:1192 dwarn:7 dfail:0 fail:4 skip:929 time:5620s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1142/shards.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-16 1:21 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status Dhinakaran Pandiyan 2018-03-16 1:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-03-16 3:11 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork @ 2018-03-16 6:29 ` Lofstedt, Marta 2018-03-16 16:27 ` Maarten Lankhorst 2018-03-20 11:26 ` Lofstedt, Marta 2018-03-16 16:19 ` Maarten Lankhorst 3 siblings, 2 replies; 8+ messages in thread From: Lofstedt, Marta @ 2018-03-16 6:29 UTC (permalink / raw) To: Pandiyan, Dhinakaran, igt-dev@lists.freedesktop.org Cc: Pandiyan, Dhinakaran, Vivi, Rodrigo I would RB this if there was some kms_frontbuffer_tracking PSR related tests that was run on PW. Could you re-send this together with a HACK patch on fast-feedback.testlist where you replace the standard tests with some kms_frontbuffer_tracking PSR related tests that was hit on the bug? /Marta > -----Original Message----- > From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of > Dhinakaran Pandiyan > Sent: Friday, March 16, 2018 3:21 AM > To: igt-dev@lists.freedesktop.org > Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo > <rodrigo.vivi@intel.com> > Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update > check for PSR status > > Kernel does not expose the "Active: " flag in edp_psr_status anymore. > So test for "HW Enabled & Active bit: yes", although this isn't completely > accurate either for frontbuffer tests. Let's go with this for now until the > kernel exposes HW PSR status. > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519 > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > --- > tests/kms_fbcon_fbt.c | 2 +- > tests/kms_frontbuffer_tracking.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index > b01c769c..280ddbd7 100644 > --- a/tests/kms_fbcon_fbt.c > +++ b/tests/kms_fbcon_fbt.c > @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd) > char buf[256]; > > igt_debugfs_read(fd, "i915_edp_psr_status", buf); > - return strstr(buf, "\nActive: yes\n"); > + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); > } > > static bool psr_wait_until_enabled(int fd) diff --git > a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c > index 2b85392d..5cba4158 100644 > --- a/tests/kms_frontbuffer_tracking.c > +++ b/tests/kms_frontbuffer_tracking.c > @@ -781,8 +781,7 @@ static bool psr_is_enabled(void) > char buf[256]; > > debugfs_read("i915_edp_psr_status", buf); > - return strstr(buf, "\nActive: yes\n") && > - strstr(buf, "\nHW Enabled & Active bit: yes\n"); > + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); > } > > static void psr_print_status(void) > -- > 2.14.1 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-16 6:29 ` [igt-dev] [PATCH i-g-t] " Lofstedt, Marta @ 2018-03-16 16:27 ` Maarten Lankhorst 2018-03-20 11:26 ` Lofstedt, Marta 1 sibling, 0 replies; 8+ messages in thread From: Maarten Lankhorst @ 2018-03-16 16:27 UTC (permalink / raw) To: Lofstedt, Marta, Pandiyan, Dhinakaran, igt-dev@lists.freedesktop.org Cc: Vivi, Rodrigo Op 16-03-18 om 07:29 schreef Lofstedt, Marta: > I would RB this if there was some kms_frontbuffer_tracking PSR related tests that was run on PW. > > Could you re-send this together with a HACK patch on fast-feedback.testlist where you replace the standard tests with some kms_frontbuffer_tracking PSR related tests that was hit on the bug? > Same.. Link standby mode only matches the dev_priv->link_standby parameter not the actual hw mode, so this patch is Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> -----Original Message----- >> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of >> Dhinakaran Pandiyan >> Sent: Friday, March 16, 2018 3:21 AM >> To: igt-dev@lists.freedesktop.org >> Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo >> <rodrigo.vivi@intel.com> >> Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update >> check for PSR status >> >> Kernel does not expose the "Active: " flag in edp_psr_status anymore. >> So test for "HW Enabled & Active bit: yes", although this isn't completely >> accurate either for frontbuffer tests. Let's go with this for now until the >> kernel exposes HW PSR status. >> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519 >> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> >> --- >> tests/kms_fbcon_fbt.c | 2 +- >> tests/kms_frontbuffer_tracking.c | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index >> b01c769c..280ddbd7 100644 >> --- a/tests/kms_fbcon_fbt.c >> +++ b/tests/kms_fbcon_fbt.c >> @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd) >> char buf[256]; >> >> igt_debugfs_read(fd, "i915_edp_psr_status", buf); >> - return strstr(buf, "\nActive: yes\n"); >> + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); >> } >> >> static bool psr_wait_until_enabled(int fd) diff --git >> a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c >> index 2b85392d..5cba4158 100644 >> --- a/tests/kms_frontbuffer_tracking.c >> +++ b/tests/kms_frontbuffer_tracking.c >> @@ -781,8 +781,7 @@ static bool psr_is_enabled(void) >> char buf[256]; >> >> debugfs_read("i915_edp_psr_status", buf); >> - return strstr(buf, "\nActive: yes\n") && >> - strstr(buf, "\nHW Enabled & Active bit: yes\n"); >> + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); >> } >> >> static void psr_print_status(void) >> -- >> 2.14.1 >> >> _______________________________________________ >> igt-dev mailing list >> igt-dev@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/igt-dev > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-16 6:29 ` [igt-dev] [PATCH i-g-t] " Lofstedt, Marta 2018-03-16 16:27 ` Maarten Lankhorst @ 2018-03-20 11:26 ` Lofstedt, Marta 2018-03-20 11:36 ` Maarten Lankhorst 1 sibling, 1 reply; 8+ messages in thread From: Lofstedt, Marta @ 2018-03-20 11:26 UTC (permalink / raw) To: Pandiyan, Dhinakaran, 'igt-dev@lists.freedesktop.org' Cc: Pandiyan, Dhinakaran, Vivi, Rodrigo https://patchwork.freedesktop.org/series/40137/ has no failing PST frombuffer_tracking tests. So, Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com> > -----Original Message----- > From: Lofstedt, Marta > Sent: Friday, March 16, 2018 8:30 AM > To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>; igt- > dev@lists.freedesktop.org > Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo > <rodrigo.vivi@intel.com> > Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update > check for PSR status > > I would RB this if there was some kms_frontbuffer_tracking PSR related tests > that was run on PW. > > Could you re-send this together with a HACK patch on fast-feedback.testlist > where you replace the standard tests with some kms_frontbuffer_tracking > PSR related tests that was hit on the bug? > > /Marta > > > -----Original Message----- > > From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf > > Of Dhinakaran Pandiyan > > Sent: Friday, March 16, 2018 3:21 AM > > To: igt-dev@lists.freedesktop.org > > Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, > > Rodrigo <rodrigo.vivi@intel.com> > > Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: > > Update check for PSR status > > > > Kernel does not expose the "Active: " flag in edp_psr_status anymore. > > So test for "HW Enabled & Active bit: yes", although this isn't > > completely accurate either for frontbuffer tests. Let's go with this > > for now until the kernel exposes HW PSR status. > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519 > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > > --- > > tests/kms_fbcon_fbt.c | 2 +- > > tests/kms_frontbuffer_tracking.c | 3 +-- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index > > b01c769c..280ddbd7 100644 > > --- a/tests/kms_fbcon_fbt.c > > +++ b/tests/kms_fbcon_fbt.c > > @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd) > > char buf[256]; > > > > igt_debugfs_read(fd, "i915_edp_psr_status", buf); > > - return strstr(buf, "\nActive: yes\n"); > > + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); > > } > > > > static bool psr_wait_until_enabled(int fd) diff --git > > a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c > > index 2b85392d..5cba4158 100644 > > --- a/tests/kms_frontbuffer_tracking.c > > +++ b/tests/kms_frontbuffer_tracking.c > > @@ -781,8 +781,7 @@ static bool psr_is_enabled(void) > > char buf[256]; > > > > debugfs_read("i915_edp_psr_status", buf); > > - return strstr(buf, "\nActive: yes\n") && > > - strstr(buf, "\nHW Enabled & Active bit: yes\n"); > > + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); > > } > > > > static void psr_print_status(void) > > -- > > 2.14.1 > > > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-20 11:26 ` Lofstedt, Marta @ 2018-03-20 11:36 ` Maarten Lankhorst 0 siblings, 0 replies; 8+ messages in thread From: Maarten Lankhorst @ 2018-03-20 11:36 UTC (permalink / raw) To: Lofstedt, Marta, Pandiyan, Dhinakaran, 'igt-dev@lists.freedesktop.org' Cc: Vivi, Rodrigo Op 20-03-18 om 12:26 schreef Lofstedt, Marta: > https://patchwork.freedesktop.org/series/40137/ > > has no failing PST frombuffer_tracking tests. So, > > Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com> > >> -----Original Message----- >> From: Lofstedt, Marta >> Sent: Friday, March 16, 2018 8:30 AM >> To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>; igt- >> dev@lists.freedesktop.org >> Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, Rodrigo >> <rodrigo.vivi@intel.com> >> Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update >> check for PSR status >> >> I would RB this if there was some kms_frontbuffer_tracking PSR related tests >> that was run on PW. >> >> Could you re-send this together with a HACK patch on fast-feedback.testlist >> where you replace the standard tests with some kms_frontbuffer_tracking >> PSR related tests that was hit on the bug? >> >> /Marta >> >>> -----Original Message----- >>> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf >>> Of Dhinakaran Pandiyan >>> Sent: Friday, March 16, 2018 3:21 AM >>> To: igt-dev@lists.freedesktop.org >>> Cc: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Vivi, >>> Rodrigo <rodrigo.vivi@intel.com> >>> Subject: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: >>> Update check for PSR status >>> >>> Kernel does not expose the "Active: " flag in edp_psr_status anymore. >>> So test for "HW Enabled & Active bit: yes", although this isn't >>> completely accurate either for frontbuffer tests. Let's go with this >>> for now until the kernel exposes HW PSR status. >>> >>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519 >>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> >>> --- >>> tests/kms_fbcon_fbt.c | 2 +- >>> tests/kms_frontbuffer_tracking.c | 3 +-- >>> 2 files changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index >>> b01c769c..280ddbd7 100644 >>> --- a/tests/kms_fbcon_fbt.c >>> +++ b/tests/kms_fbcon_fbt.c >>> @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd) >>> char buf[256]; >>> >>> igt_debugfs_read(fd, "i915_edp_psr_status", buf); >>> - return strstr(buf, "\nActive: yes\n"); >>> + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); >>> } >>> >>> static bool psr_wait_until_enabled(int fd) diff --git >>> a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c >>> index 2b85392d..5cba4158 100644 >>> --- a/tests/kms_frontbuffer_tracking.c >>> +++ b/tests/kms_frontbuffer_tracking.c >>> @@ -781,8 +781,7 @@ static bool psr_is_enabled(void) >>> char buf[256]; >>> >>> debugfs_read("i915_edp_psr_status", buf); >>> - return strstr(buf, "\nActive: yes\n") && >>> - strstr(buf, "\nHW Enabled & Active bit: yes\n"); >>> + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); >>> } >>> >>> static void psr_print_status(void) >>> -- >>> 2.14.1 >>> >>> _______________________________________________ >>> igt-dev mailing list >>> igt-dev@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/igt-dev > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev Thanks, pushed. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status 2018-03-16 1:21 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status Dhinakaran Pandiyan ` (2 preceding siblings ...) 2018-03-16 6:29 ` [igt-dev] [PATCH i-g-t] " Lofstedt, Marta @ 2018-03-16 16:19 ` Maarten Lankhorst 3 siblings, 0 replies; 8+ messages in thread From: Maarten Lankhorst @ 2018-03-16 16:19 UTC (permalink / raw) To: Dhinakaran Pandiyan, igt-dev; +Cc: Rodrigo Vivi Op 16-03-18 om 02:21 schreef Dhinakaran Pandiyan: > Kernel does not expose the "Active: " flag in edp_psr_status anymore. > So test for "HW Enabled & Active bit: yes", although this isn't completely > accurate either for frontbuffer tests. Let's go with this for now until > the kernel exposes HW PSR status. > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105519 > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > --- > tests/kms_fbcon_fbt.c | 2 +- > tests/kms_frontbuffer_tracking.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c > index b01c769c..280ddbd7 100644 > --- a/tests/kms_fbcon_fbt.c > +++ b/tests/kms_fbcon_fbt.c > @@ -189,7 +189,7 @@ static bool psr_is_enabled(int fd) > char buf[256]; > > igt_debugfs_read(fd, "i915_edp_psr_status", buf); > - return strstr(buf, "\nActive: yes\n"); > + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); > } > > static bool psr_wait_until_enabled(int fd) > diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c > index 2b85392d..5cba4158 100644 > --- a/tests/kms_frontbuffer_tracking.c > +++ b/tests/kms_frontbuffer_tracking.c > @@ -781,8 +781,7 @@ static bool psr_is_enabled(void) > char buf[256]; > > debugfs_read("i915_edp_psr_status", buf); > - return strstr(buf, "\nActive: yes\n") && > - strstr(buf, "\nHW Enabled & Active bit: yes\n"); > + return strstr(buf, "\nHW Enabled & Active bit: yes\n"); > } > > static void psr_print_status(void) Hey, If enable_psr is set to link standby, won't "Main link in standby mode: yes" also be a valid way of entering PSR? This is probably the case for HSW, I've sent my own patch for this.. https://patchwork.freedesktop.org/patch/211060/ ~Maarten _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-20 11:36 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-16 1:21 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Update check for PSR status Dhinakaran Pandiyan 2018-03-16 1:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2018-03-16 3:11 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork 2018-03-16 6:29 ` [igt-dev] [PATCH i-g-t] " Lofstedt, Marta 2018-03-16 16:27 ` Maarten Lankhorst 2018-03-20 11:26 ` Lofstedt, Marta 2018-03-20 11:36 ` Maarten Lankhorst 2018-03-16 16:19 ` Maarten Lankhorst
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox