Re: [igt-dev] [V3 i-g-t 05/23] tests/amdgpu: Close the fd before exit

["Christian König" <christian.koenig@amd.com>]

Am 22.06.23 um 08:54 schrieb Bhanuprakash Modem:
> Close the file descriptor before exiting the test.
>
> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   tests/amdgpu/amd_abm.c                 | 1 +
>   tests/amdgpu/amd_assr.c                | 1 +
>   tests/amdgpu/amd_freesync_video_mode.c | 1 +
>   tests/amdgpu/amd_mem_leak.c            | 1 +
>   tests/amdgpu/amd_psr.c                 | 3 ++-
>   tests/amdgpu/amd_vrr_range.c           | 1 +
>   6 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index 9400ed806..082da7ed6 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -378,5 +378,6 @@ igt_main
>   
>   	igt_fixture {
>   		igt_display_fini(&data.display);
> +		drm_close_driver(data.drm_fd);
>   	}
>   }
> diff --git a/tests/amdgpu/amd_assr.c b/tests/amdgpu/amd_assr.c
> index 80cbbe8e9..fc2367f99 100644
> --- a/tests/amdgpu/amd_assr.c
> +++ b/tests/amdgpu/amd_assr.c
> @@ -299,5 +299,6 @@ igt_main
>   	igt_fixture
>   	{
>   		igt_display_fini(&data.display);
> +		drm_close_driver(data.fd);
>   	}
>   }
> diff --git a/tests/amdgpu/amd_freesync_video_mode.c b/tests/amdgpu/amd_freesync_video_mode.c
> index 579d24436..62d42a06c 100644
> --- a/tests/amdgpu/amd_freesync_video_mode.c
> +++ b/tests/amdgpu/amd_freesync_video_mode.c
> @@ -868,5 +868,6 @@ igt_main
>   
>   	igt_fixture {
>   		igt_display_fini(&data.display);
> +		drm_close_driver(data.drm_fd);
>   	}
>   }
> diff --git a/tests/amdgpu/amd_mem_leak.c b/tests/amdgpu/amd_mem_leak.c
> index dee563cbe..e4a4b5c47 100644
> --- a/tests/amdgpu/amd_mem_leak.c
> +++ b/tests/amdgpu/amd_mem_leak.c
> @@ -232,5 +232,6 @@ igt_main
>   	igt_fixture
>   	{
>   		igt_display_fini(&data.display);
> +		drm_close_driver(data.fd);
>   	}
>   }
> diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c
> index 966a0dccf..3932e143a 100644
> --- a/tests/amdgpu/amd_psr.c
> +++ b/tests/amdgpu/amd_psr.c
> @@ -640,7 +640,7 @@ static void run_check_psr_su_cursor(data_t *data, bool test_mpo)
>   	 * panning the primary plane at the top-left of screen
>   	 * set alpha region in overlay plane and set alpha to 0.0 to show primary plane
>   	 * set cursor plane and starting from position of (0, 0)
> -	 */
> +	 */
>   	draw_color_alpha(&data->ov_fb[0], 0, 0, data->pfb_w, data->pfb_h, 1.0, 1.0, 1.0, .0);
>   	igt_plane_set_fb(data->primary, &data->pm_fb[0]);
>   	igt_plane_set_fb(data->overlay, &data->ov_fb[0]);
> @@ -763,5 +763,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>   		}
>   		close(data.debugfs_fd);
>   		igt_display_fini(&data.display);
> +		drm_close_driver(data.fd);
>   	}
>   }
> diff --git a/tests/amdgpu/amd_vrr_range.c b/tests/amdgpu/amd_vrr_range.c
> index 611f41f95..a77895622 100644
> --- a/tests/amdgpu/amd_vrr_range.c
> +++ b/tests/amdgpu/amd_vrr_range.c
> @@ -408,5 +408,6 @@ igt_main
>   	igt_fixture
>   	{
>   		igt_display_fini(&data.display);
> +		drm_close_driver(data.fd);
>   	}
>   }