public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915/gem_eio: Not everyone actually has contexts
@ 2019-02-21 10:01 Chris Wilson
  2019-02-21 11:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2019-02-21 10:01 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Eek, I assumed the 'banned' subtest only applied to context platforms,
ti doesn't. The basic test works for all, checking whether a second
context works after the first is banned however only applies to
platforms with contexts!

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_eio.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
index c5fd07585..3f941071d 100644
--- a/tests/i915/gem_eio.c
+++ b/tests/i915/gem_eio.c
@@ -334,13 +334,13 @@ static void __test_banned(int fd)
 
 			/* Only this context, not the file, should be banned */
 			igt_assert_neq(__gem_context_create(fd, &ctx), -EIO);
-			igt_assert_neq(ctx, 0);
-
-			/* And check it actually works! */
-			execbuf.rsvd1 = ctx;
-			gem_execbuf(fd, &execbuf);
+			if (ctx) { /* remember the contextless! */
+				/* And check it actually works! */
+				execbuf.rsvd1 = ctx;
+				gem_execbuf(fd, &execbuf);
 
-			gem_context_destroy(fd, ctx);
+				gem_context_destroy(fd, ctx);
+			}
 			return;
 		}
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-21 20:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-21 10:01 [igt-dev] [PATCH i-g-t] i915/gem_eio: Not everyone actually has contexts Chris Wilson
2019-02-21 11:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-21 17:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-21 17:50 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Antonio Argenziano
2019-02-21 20:43   ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox