Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: "Sharma, Swati2" <swati2.sharma@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: test odd size planar yuv
Date: Tue, 10 Oct 2023 10:50:15 +0300	[thread overview]
Message-ID: <46fd9f27-b874-c7a4-e992-b29c77b7cb89@gmail.com> (raw)
In-Reply-To: <204d9c5e-86e6-4faf-becd-5e5cbac15fb5@intel.com>

Hei Swati,

On 10.10.2023 9.22, Sharma, Swati2 wrote:
> Hi JP
> 
> Overall patch looks good. One review comment we had from Lucas before,
> "It's also odd from a testing perspective since we are testing a
> *negative*, in test_*invalid*_settings(), and then expecting it to be
> valid.  Should we need to improve the test, maybe being more specific on
> its name? Example: odd-width-nv12 / odd-height-nv12"
> 
> Should we rename test? With current name, it seems its a negative test.

yes, we should rename this test. In fact I had done it as discussed 
earlier but that change made it only to commit message while that 
renaming change in source code I'll need to amend to my patch and send 
again. :)

/Juha-Pekka

> 
> On 10-Oct-23 1:25 AM, Patchwork wrote:
>> *Patch Details*
>> *Series:*    tests/kms_plane: test odd size planar yuv
>> *URL:*    https://patchwork.freedesktop.org/series/124848/ 
>> <https://patchwork.freedesktop.org/series/124848/>
>> *State:*    success
>> *Details:* 
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html 
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html>
>>
>>
>>   CI Bug Log - changes from IGT_7523 -> IGTPW_9954
>>
>>
>>     Summary
>>
>> *SUCCESS*
>>
>> No regressions found.
>>
>> External URL: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html
>>
>>
>>     Participating hosts (37 -> 36)
>>
>> Additional (1): fi-kbl-soraka
>> Missing (2): fi-hsw-4770 fi-snb-2520m
>>
>>
>>     Known issues
>>
>> Here are the changes found in IGTPW_9954 that come from known issues:
>>
>>
>>       IGT changes
>>
>>
>>         Issues hit
>>
>>   *
>>
>>     igt@gem_huc_copy@huc-copy:
>>
>>       o fi-kbl-soraka: NOTRUN -> SKIP
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>)
>>   *
>>
>>     igt@gem_lmem_swapping@basic:
>>
>>       o fi-kbl-soraka: NOTRUN -> SKIP
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 other tests skip
>>   *
>>
>>     igt@gem_lmem_swapping@random-engines:
>>
>>       o fi-bsw-n3050: NOTRUN -> SKIP
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +18 other tests skip
>>   *
>>
>>     igt@i915_selftest@live@gt_pm:
>>
>>       o fi-kbl-soraka: NOTRUN -> DMESG-FAIL
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> (i915#1886 <https://gitlab.freedesktop.org/drm/intel/issues/1886>)
>>   *
>>
>>     igt@kms_dsc@dsc-basic:
>>
>>       o fi-kbl-soraka: NOTRUN -> SKIP
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +9 other tests skip
>>   *
>>
>>     igt@kms_frontbuffer_tracking@basic:
>>
>>       o fi-bsw-nick: PASS
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7523/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html> -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html> (i915#9276 <https://gitlab.freedesktop.org/drm/intel/issues/9276>)
>>   *
>>
>>     igt@kms_hdmi_inject@inject-audio:
>>
>>       o
>>
>>         fi-kbl-guc: PASS
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7523/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html> -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html> (IGT#3 <https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3>)
>>
>>       o
>>
>>         fi-bsw-n3050: NOTRUN -> FAIL
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-bsw-n3050/igt@kms_hdmi_inject@inject-audio.html> (IGT#3 <https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3>)
>>
>>
>>         Possible fixes
>>
>>   * igt@i915_selftest@live@gt_heartbeat:
>>       o fi-apl-guc: DMESG-FAIL
>>         
>> <https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7523/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334 <https://gitlab.freedesktop.org/drm/intel/issues/5334>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html>
>>
>> {name}: This element is suppressed. This means it is ignored when 
>> computing
>> the status of the difference (SUCCESS, WARNING, or FAILURE).
>>
>>
>>     Build changes
>>
>>   * CI: CI-20190529 -> None
>>   * IGT: IGT_7523 -> IGTPW_9954
>>
>> CI-20190529: 20190529
>> CI_DRM_13730: 1c99af947eb335283794db0644648dc4b40f44cd @ 
>> git://anongit.freedesktop.org/gfx-ci/linux
>> IGTPW_9954: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9954/index.html
>> IGT_7523: 361c2f92f1fe5641090f2fc59951fcaba15387f5 @ 
>> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>>

  reply	other threads:[~2023-10-10  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 18:25 [igt-dev] [PATCH i-g-t] tests/kms_plane: test odd size planar yuv Juha-Pekka Heikkila
2023-10-09 19:55 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-10-10  6:22   ` Sharma, Swati2
2023-10-10  7:50     ` Juha-Pekka Heikkila [this message]
2023-10-09 20:25 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-10  0:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46fd9f27-b874-c7a4-e992-b29c77b7cb89@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox