Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Skip the subtest if the resolution is not supported
@ 2022-05-04 22:00 Nidhi Gupta
  2022-05-04 22:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Nidhi Gupta @ 2022-05-04 22:00 UTC (permalink / raw)
  To: igt-dev; +Cc: Nidhi Gupta

The kms_concurrent is about testing mode setting with
reducing the resolution and then again increasing it,
for this the test will take the high resolution supported
by the connector and then calculate the lowest resolution,
if the calculated resolution is not supported by the connector
it will assign the default resolution of 1024x 768 without
checking.

Adding the check to skip the subtest if the default
resolution is not supported by the connector.

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_concurrent.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 82b2021e..fdef6b26 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -272,6 +272,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
 		mode_hi = igt_output_get_mode(output);
 		mode_lo = get_lowres_mode(data, mode_hi, output);
 
+		igt_skip_on(mode_lo->vdisplay > mode_hi->vdisplay);
+
 		/* switch to lower resolution */
 		igt_output_override_mode(output, mode_lo);
 		free(mode_lo);
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Skip the subtest if the resolution is not supported
@ 2022-05-09 12:01 Nidhi Gupta
  0 siblings, 0 replies; 7+ messages in thread
From: Nidhi Gupta @ 2022-05-09 12:01 UTC (permalink / raw)
  To: igt-dev; +Cc: Nidhi Gupta

The kms_concurrent is about testing mode setting with
reducing the resolution and then again increasing it,
for this the test will take the high resolution supported
by the connector and then calculate the lowest resolution,
if the calculated resolution is not supported by the connector
it will assign the default resolution of 1024x 768 without
checking.

Added check to skip the subtest if the default resolution is not supported
by the connector, to achieve that we are skipping if,
"mode_lo->vdisplay  > mode_hi->vdisplay".

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_concurrent.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index 82b2021e..e7f8d85c 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -272,6 +272,8 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
 		mode_hi = igt_output_get_mode(output);
 		mode_lo = get_lowres_mode(data, mode_hi, output);
 
+		igt_skip_on_f(mode_lo->vdisplay > mode_hi->vdisplay, "No suitable resolution was found\n");
+
 		/* switch to lower resolution */
 		igt_output_override_mode(output, mode_lo);
 		free(mode_lo);
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-09 11:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-04 22:00 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: Skip the subtest if the resolution is not supported Nidhi Gupta
2022-05-04 22:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-05-05  3:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-05-05  5:53 ` [igt-dev] [PATCH i-g-t] " Karthik B S
2022-05-05 12:30   ` Gupta, Nidhi1
2022-05-06 11:39     ` Kahola, Mika
  -- strict thread matches above, loose matches on Subject: below --
2022-05-09 12:01 Nidhi Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox