* [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls
@ 2020-09-24 12:36 Petri Latvala
2020-09-24 13:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Petri Latvala @ 2020-09-24 12:36 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi, Petri Latvala
Use of timeouts everywhere is meaningless if xmlrpc calls are allowed
to be blocking forever.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Cc: Arkadiusz Hiler <arek@hiler.eu>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
lib/igt_chamelium.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index d9fab902..eac893a6 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -2427,11 +2427,21 @@ void chamelium_deinit_rpc_only(struct chamelium *chamelium)
struct chamelium *chamelium_init_rpc_only(void)
{
struct chamelium *chamelium = malloc(sizeof(struct chamelium));
+ struct xmlrpc_clientparms clientparms;
+ struct xmlrpc_curl_xportparms curlparms;
if (!chamelium)
return NULL;
memset(chamelium, 0, sizeof(*chamelium));
+ memset(&clientparms, 0, sizeof(clientparms));
+ memset(&curlparms, 0, sizeof(curlparms));
+
+ curlparms.timeout = _RECEIVER_RESPONSIVE_AFTER_RESET_SECONDS;
+
+ clientparms.transport = "curl";
+ clientparms.transportparmsP = &curlparms;
+ clientparms.transportparm_size = XMLRPC_CXPSIZE(timeout);
chamelium->drm_fd = -1;
@@ -2439,7 +2449,7 @@ struct chamelium *chamelium_init_rpc_only(void)
xmlrpc_env_init(&chamelium->env);
xmlrpc_client_setup_global_const(&chamelium->env);
xmlrpc_client_create(&chamelium->env, XMLRPC_CLIENT_NO_FLAGS, PACKAGE,
- PACKAGE_VERSION, NULL, 0, &chamelium->client);
+ PACKAGE_VERSION, &clientparms, 0, &chamelium->client);
if (chamelium->env.fault_occurred) {
igt_debug("Failed to init xmlrpc: %s\n",
chamelium->env.fault_string);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 12:36 [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls Petri Latvala @ 2020-09-24 13:14 ` Patchwork 2020-09-24 13:25 ` [igt-dev] [PATCH i-g-t RFC] " Juha-Pekka Heikkila 2020-09-24 16:56 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork 2 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2020-09-24 13:14 UTC (permalink / raw) To: Petri Latvala; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 7450 bytes --] == Series Details == Series: lib/igt_chamelium: Use curl timeout for xmlrpc calls URL : https://patchwork.freedesktop.org/series/82061/ State : success == Summary == CI Bug Log - changes from CI_DRM_9047 -> IGTPW_5010 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/index.html Known issues ------------ Here are the changes found in IGTPW_5010 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#1982] / [k.org#205379]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-y/igt@i915_module_load@reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-y/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-n3050: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@vgem_basic@sysfs: - fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-y/igt@vgem_basic@sysfs.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-y/igt@vgem_basic@sysfs.html * igt@vgem_basic@unload: - fi-skl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#2203]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-skl-guc/igt@vgem_basic@unload.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-skl-guc/igt@vgem_basic@unload.html #### Possible fixes #### * igt@gem_flink_basic@basic: - fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-y/igt@gem_flink_basic@basic.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-y/igt@gem_flink_basic@basic.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-bsw-kefka: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_flip@basic-flip-vs-modeset@d-dsi1: - {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-dsi/igt@kms_flip@basic-flip-vs-modeset@d-dsi1.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-dsi/igt@kms_flip@basic-flip-vs-modeset@d-dsi1.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][15] ([i915#1982] / [i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@gem_exec_suspend@basic-s3: - fi-tgl-y: [DMESG-WARN][17] ([i915#2411] / [i915#402]) -> [DMESG-WARN][18] ([i915#2411]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html * igt@i915_pm_rpm@module-reload: - fi-tgl-y: [DMESG-WARN][19] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][20] ([i915#2411]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-y/igt@i915_pm_rpm@module-reload.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-y/igt@i915_pm_rpm@module-reload.html - fi-kbl-x1275: [DMESG-FAIL][21] ([i915#62] / [i915#95]) -> [DMESG-FAIL][22] ([i915#62]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html * igt@kms_force_connector_basic@prune-stale-modes: - fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c: - fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +2 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-kbl-x1275: [DMESG-WARN][27] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][28] ([i915#62] / [i915#92]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html - fi-tgl-y: [DMESG-WARN][29] ([i915#2411]) -> [DMESG-WARN][30] ([i915#1982] / [i915#2411]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/fi-tgl-y/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/fi-tgl-y/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 [k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379 Participating hosts (46 -> 40) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5787 -> IGTPW_5010 CI-20190529: 20190529 CI_DRM_9047: b64988a48d8e4b61361f419e42b02591e87731b7 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5010: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/index.html IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/index.html [-- Attachment #1.2: Type: text/html, Size: 10610 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 12:36 [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls Petri Latvala 2020-09-24 13:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-09-24 13:25 ` Juha-Pekka Heikkila 2020-09-24 13:36 ` Petri Latvala 2020-09-24 13:38 ` Juha-Pekka Heikkila 2020-09-24 16:56 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork 2 siblings, 2 replies; 8+ messages in thread From: Juha-Pekka Heikkila @ 2020-09-24 13:25 UTC (permalink / raw) To: Petri Latvala, igt-dev; +Cc: Kunal Joshi I guess CI isn't going to run this code anywhere for now? The change look ok to me. Assuming the results will be all green, Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> On 24.9.2020 15.36, Petri Latvala wrote: > Use of timeouts everywhere is meaningless if xmlrpc calls are allowed > to be blocking forever. > > Signed-off-by: Petri Latvala <petri.latvala@intel.com> > Cc: Kunal Joshi <kunal1.joshi@intel.com> > Cc: Arkadiusz Hiler <arek@hiler.eu> > Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > --- > lib/igt_chamelium.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c > index d9fab902..eac893a6 100644 > --- a/lib/igt_chamelium.c > +++ b/lib/igt_chamelium.c > @@ -2427,11 +2427,21 @@ void chamelium_deinit_rpc_only(struct chamelium *chamelium) > struct chamelium *chamelium_init_rpc_only(void) > { > struct chamelium *chamelium = malloc(sizeof(struct chamelium)); > + struct xmlrpc_clientparms clientparms; > + struct xmlrpc_curl_xportparms curlparms; > > if (!chamelium) > return NULL; > > memset(chamelium, 0, sizeof(*chamelium)); > + memset(&clientparms, 0, sizeof(clientparms)); > + memset(&curlparms, 0, sizeof(curlparms)); > + > + curlparms.timeout = _RECEIVER_RESPONSIVE_AFTER_RESET_SECONDS; > + > + clientparms.transport = "curl"; > + clientparms.transportparmsP = &curlparms; > + clientparms.transportparm_size = XMLRPC_CXPSIZE(timeout); > > chamelium->drm_fd = -1; > > @@ -2439,7 +2449,7 @@ struct chamelium *chamelium_init_rpc_only(void) > xmlrpc_env_init(&chamelium->env); > xmlrpc_client_setup_global_const(&chamelium->env); > xmlrpc_client_create(&chamelium->env, XMLRPC_CLIENT_NO_FLAGS, PACKAGE, > - PACKAGE_VERSION, NULL, 0, &chamelium->client); > + PACKAGE_VERSION, &clientparms, 0, &chamelium->client); > if (chamelium->env.fault_occurred) { > igt_debug("Failed to init xmlrpc: %s\n", > chamelium->env.fault_string); > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 13:25 ` [igt-dev] [PATCH i-g-t RFC] " Juha-Pekka Heikkila @ 2020-09-24 13:36 ` Petri Latvala 2020-09-24 13:40 ` Juha-Pekka Heikkila 2020-09-24 13:38 ` Juha-Pekka Heikkila 1 sibling, 1 reply; 8+ messages in thread From: Petri Latvala @ 2020-09-24 13:36 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev, Kunal Joshi On Thu, Sep 24, 2020 at 04:25:17PM +0300, Juha-Pekka Heikkila wrote: > I guess CI isn't going to run this code anywhere for now? The change look ok > to me. Assuming the results will be all green, It will run this code everywhere where chamelium is deployed. What do you mean? -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 13:36 ` Petri Latvala @ 2020-09-24 13:40 ` Juha-Pekka Heikkila 0 siblings, 0 replies; 8+ messages in thread From: Juha-Pekka Heikkila @ 2020-09-24 13:40 UTC (permalink / raw) To: Petri Latvala; +Cc: igt-dev, Kunal Joshi On 24.9.2020 16.36, Petri Latvala wrote: > On Thu, Sep 24, 2020 at 04:25:17PM +0300, Juha-Pekka Heikkila wrote: >> I guess CI isn't going to run this code anywhere for now? The change look ok >> to me. Assuming the results will be all green, > > It will run this code everywhere where chamelium is deployed. What do > you mean? I didn't know there is any chamelium on those CI machines which will provide test results for this patch. /Juha-Pekka _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 13:25 ` [igt-dev] [PATCH i-g-t RFC] " Juha-Pekka Heikkila 2020-09-24 13:36 ` Petri Latvala @ 2020-09-24 13:38 ` Juha-Pekka Heikkila 2020-09-24 13:58 ` Petri Latvala 1 sibling, 1 reply; 8+ messages in thread From: Juha-Pekka Heikkila @ 2020-09-24 13:38 UTC (permalink / raw) To: Petri Latvala, igt-dev; +Cc: Kunal Joshi On 24.9.2020 16.25, Juha-Pekka Heikkila wrote: > I guess CI isn't going to run this code anywhere for now? The change > look ok to me. Assuming the results will be all green, > > Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > > > On 24.9.2020 15.36, Petri Latvala wrote: >> Use of timeouts everywhere is meaningless if xmlrpc calls are allowed >> to be blocking forever. >> >> Signed-off-by: Petri Latvala <petri.latvala@intel.com> >> Cc: Kunal Joshi <kunal1.joshi@intel.com> >> Cc: Arkadiusz Hiler <arek@hiler.eu> >> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> >> --- >> lib/igt_chamelium.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c >> index d9fab902..eac893a6 100644 >> --- a/lib/igt_chamelium.c >> +++ b/lib/igt_chamelium.c >> @@ -2427,11 +2427,21 @@ void chamelium_deinit_rpc_only(struct >> chamelium *chamelium) >> struct chamelium *chamelium_init_rpc_only(void) >> { >> struct chamelium *chamelium = malloc(sizeof(struct chamelium)); >> + struct xmlrpc_clientparms clientparms; >> + struct xmlrpc_curl_xportparms curlparms; >> if (!chamelium) >> return NULL; >> memset(chamelium, 0, sizeof(*chamelium)); >> + memset(&clientparms, 0, sizeof(clientparms)); >> + memset(&curlparms, 0, sizeof(curlparms)); >> + >> + curlparms.timeout = _RECEIVER_RESPONSIVE_AFTER_RESET_SECONDS; I just realized here's curlparms.timeout is milliseconds, not seconds. >> + >> + clientparms.transport = "curl"; >> + clientparms.transportparmsP = &curlparms; >> + clientparms.transportparm_size = XMLRPC_CXPSIZE(timeout); >> chamelium->drm_fd = -1; >> @@ -2439,7 +2449,7 @@ struct chamelium *chamelium_init_rpc_only(void) >> xmlrpc_env_init(&chamelium->env); >> xmlrpc_client_setup_global_const(&chamelium->env); >> xmlrpc_client_create(&chamelium->env, XMLRPC_CLIENT_NO_FLAGS, >> PACKAGE, >> - PACKAGE_VERSION, NULL, 0, &chamelium->client); >> + PACKAGE_VERSION, &clientparms, 0, &chamelium->client); >> if (chamelium->env.fault_occurred) { >> igt_debug("Failed to init xmlrpc: %s\n", >> chamelium->env.fault_string); >> > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 13:38 ` Juha-Pekka Heikkila @ 2020-09-24 13:58 ` Petri Latvala 0 siblings, 0 replies; 8+ messages in thread From: Petri Latvala @ 2020-09-24 13:58 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: igt-dev, Kunal Joshi On Thu, Sep 24, 2020 at 04:38:36PM +0300, Juha-Pekka Heikkila wrote: > On 24.9.2020 16.25, Juha-Pekka Heikkila wrote: > > I guess CI isn't going to run this code anywhere for now? The change > > look ok to me. Assuming the results will be all green, > > > > Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > > > > > > On 24.9.2020 15.36, Petri Latvala wrote: > > > Use of timeouts everywhere is meaningless if xmlrpc calls are allowed > > > to be blocking forever. > > > > > > Signed-off-by: Petri Latvala <petri.latvala@intel.com> > > > Cc: Kunal Joshi <kunal1.joshi@intel.com> > > > Cc: Arkadiusz Hiler <arek@hiler.eu> > > > Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > > > --- > > > lib/igt_chamelium.c | 12 +++++++++++- > > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c > > > index d9fab902..eac893a6 100644 > > > --- a/lib/igt_chamelium.c > > > +++ b/lib/igt_chamelium.c > > > @@ -2427,11 +2427,21 @@ void chamelium_deinit_rpc_only(struct > > > chamelium *chamelium) > > > struct chamelium *chamelium_init_rpc_only(void) > > > { > > > struct chamelium *chamelium = malloc(sizeof(struct chamelium)); > > > + struct xmlrpc_clientparms clientparms; > > > + struct xmlrpc_curl_xportparms curlparms; > > > if (!chamelium) > > > return NULL; > > > memset(chamelium, 0, sizeof(*chamelium)); > > > + memset(&clientparms, 0, sizeof(clientparms)); > > > + memset(&curlparms, 0, sizeof(curlparms)); > > > + > > > + curlparms.timeout = _RECEIVER_RESPONSIVE_AFTER_RESET_SECONDS; > > I just realized here's curlparms.timeout is milliseconds, not seconds. Gah! _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_chamelium: Use curl timeout for xmlrpc calls 2020-09-24 12:36 [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls Petri Latvala 2020-09-24 13:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2020-09-24 13:25 ` [igt-dev] [PATCH i-g-t RFC] " Juha-Pekka Heikkila @ 2020-09-24 16:56 ` Patchwork 2 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2020-09-24 16:56 UTC (permalink / raw) To: Petri Latvala; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 13711 bytes --] == Series Details == Series: lib/igt_chamelium: Use curl timeout for xmlrpc calls URL : https://patchwork.freedesktop.org/series/82061/ State : success == Summary == CI Bug Log - changes from CI_DRM_9047_full -> IGTPW_5010_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_5010_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_5010_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_5010_full: ### IGT changes ### #### Warnings #### * igt@i915_pm_rpm@cursor: - shard-tglb: [DMESG-WARN][1] ([i915#2411]) -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-tglb3/igt@i915_pm_rpm@cursor.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-tglb8/igt@i915_pm_rpm@cursor.html Known issues ------------ Here are the changes found in IGTPW_5010_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_create@forked: - shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk9/igt@gem_exec_create@forked.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk5/igt@gem_exec_create@forked.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: [PASS][5] -> [FAIL][6] ([i915#1635] / [i915#2389]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-apl3/igt@gem_exec_reloc@basic-many-active@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-apl8/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_reloc@basic-many-active@vecs0: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2389]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk9/igt@gem_exec_reloc@basic-many-active@vecs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk6/igt@gem_exec_reloc@basic-many-active@vecs0.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +4 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-kbl6/igt@gem_exec_suspend@basic-s3.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-kbl7/igt@gem_exec_suspend@basic-s3.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][11] -> [SKIP][12] ([i915#2190]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-tglb7/igt@gem_huc_copy@huc-copy.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-tglb6/igt@gem_huc_copy@huc-copy.html * igt@i915_pm_dc@dc5-psr: - shard-iclb: [PASS][13] -> [FAIL][14] ([i915#1899]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb5/igt@i915_pm_dc@dc5-psr.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb1/igt@i915_pm_dc@dc5-psr.html * igt@kms_cursor_legacy@cursor-vs-flip-toggle: - shard-hsw: [PASS][15] -> [FAIL][16] ([i915#2370]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html * igt@kms_flip@flip-vs-wf_vblank-interruptible@c-hdmi-a2: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#2122]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk5/igt@kms_flip@flip-vs-wf_vblank-interruptible@c-hdmi-a2.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk7/igt@kms_flip@flip-vs-wf_vblank-interruptible@c-hdmi-a2.html * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-tglb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +4 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html * igt@kms_psr@psr2_sprite_mmap_cpu: - shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_cpu.html * igt@kms_setmode@basic: - shard-hsw: [PASS][23] -> [FAIL][24] ([i915#31]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-hsw7/igt@kms_setmode@basic.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-hsw1/igt@kms_setmode@basic.html * igt@perf@polling-small-buf: - shard-iclb: [PASS][25] -> [FAIL][26] ([i915#1722]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb1/igt@perf@polling-small-buf.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb1/igt@perf@polling-small-buf.html #### Possible fixes #### * igt@gem_exec_whisper@basic-queues-priority: - shard-glk: [INCOMPLETE][27] -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk2/igt@gem_exec_whisper@basic-queues-priority.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk9/igt@gem_exec_whisper@basic-queues-priority.html * igt@gem_mmap_offset@blt-coherency: - shard-apl: [FAIL][29] ([i915#1635]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-apl2/igt@gem_mmap_offset@blt-coherency.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-apl6/igt@gem_mmap_offset@blt-coherency.html * igt@gem_softpin@softpin: - shard-glk: [DMESG-WARN][31] ([i915#118] / [i915#95]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk8/igt@gem_softpin@softpin.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk9/igt@gem_softpin@softpin.html * igt@gen9_exec_parse@allowed-all: - shard-kbl: [DMESG-WARN][33] ([i915#1436] / [i915#716]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-kbl2/igt@gen9_exec_parse@allowed-all.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-kbl2/igt@gen9_exec_parse@allowed-all.html * igt@i915_module_load@reload: - shard-iclb: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb5/igt@i915_module_load@reload.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb8/igt@i915_module_load@reload.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][37] ([i915#1899]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb1/igt@i915_pm_dc@dc6-psr.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic: - shard-hsw: [INCOMPLETE][39] ([CI#80]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-hsw4/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-hsw4/igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [FAIL][41] ([i915#72]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_flip@2x-wf_vblank-ts-check-interruptible@ab-vga1-hdmi-a1: - shard-hsw: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-hsw6/igt@kms_flip@2x-wf_vblank-ts-check-interruptible@ab-vga1-hdmi-a1.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-hsw6/igt@kms_flip@2x-wf_vblank-ts-check-interruptible@ab-vga1-hdmi-a1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2: - shard-glk: [FAIL][45] ([i915#79]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-kbl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw: - shard-tglb: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +2 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@perf@polling-parameterized: - shard-glk: [FAIL][53] ([i915#1542]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-glk2/igt@perf@polling-parameterized.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-glk3/igt@perf@polling-parameterized.html * igt@prime_vgem@basic-fence-flip: - shard-kbl: [INCOMPLETE][55] -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-kbl1/igt@prime_vgem@basic-fence-flip.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-kbl6/igt@prime_vgem@basic-fence-flip.html #### Warnings #### * igt@i915_pm_dc@dc5-psr: - shard-tglb: [DMESG-WARN][57] ([i915#2411]) -> [FAIL][58] ([i915#1899]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-tglb7/igt@i915_pm_dc@dc5-psr.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-tglb7/igt@i915_pm_dc@dc5-psr.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][59] ([i915#1226]) -> [SKIP][60] ([fdo#109349]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9047/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 8) ------------------------------ Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5787 -> IGTPW_5010 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_9047: b64988a48d8e4b61361f419e42b02591e87731b7 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5010: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/index.html IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5010/index.html [-- Attachment #1.2: Type: text/html, Size: 15890 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-24 16:56 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-09-24 12:36 [igt-dev] [PATCH i-g-t RFC] lib/igt_chamelium: Use curl timeout for xmlrpc calls Petri Latvala 2020-09-24 13:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2020-09-24 13:25 ` [igt-dev] [PATCH i-g-t RFC] " Juha-Pekka Heikkila 2020-09-24 13:36 ` Petri Latvala 2020-09-24 13:40 ` Juha-Pekka Heikkila 2020-09-24 13:38 ` Juha-Pekka Heikkila 2020-09-24 13:58 ` Petri Latvala 2020-09-24 16:56 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox