From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH i-g-t] BMG: lib/intel_compute: Enable compute tests for BMG
Date: Mon, 22 Jul 2024 12:02:20 +0200 [thread overview]
Message-ID: <4cdcb1d2-263f-41fe-9456-fd0be8c39be1@linux.intel.com> (raw)
In-Reply-To: <f968325d-bfd6-4ea6-8a89-b3ba18ddde93@linux.intel.com>
On 7/22/2024 12:00 PM, Nirmoy Das wrote:
>
> On 7/22/2024 11:45 AM, Zbigniew Kempczyński wrote:
>> From: Nirmoy Das <nirmoy.das@intel.com>
>>
>> BMG is XE2 based so compute tests should run as it is.
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
>> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>> ---
>> lib/intel_compute.c | 31 ++++++++++++++++++++++++++++++
>> lib/intel_compute_square_kernels.c | 28 +++++++++++++++++++++++++++
>> 2 files changed, 59 insertions(+)
>>
>> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
>> index 72025a4811..54d1814f38 100644
>> --- a/lib/intel_compute.c
>> +++ b/lib/intel_compute.c
>> @@ -1449,6 +1449,21 @@ static const struct {
>> .compute_exec = xehpc_compute_exec,
>> .compat = COMPAT_DRIVER_XE,
>> },
>> + {
>> + .ip_ver = IP_VER(20, 00),
>> + .compute_exec = xe2lpg_compute_exec,
>> + .compat = COMPAT_DRIVER_XE,
>> + },
>> + {
>> + .ip_ver = IP_VER(20, 01),
>> + .compute_exec = xe2lpg_compute_exec,
>> + .compat = COMPAT_DRIVER_XE,
>> + },
>> + {
>> + .ip_ver = IP_VER(20, 02),
>> + .compute_exec = xe2lpg_compute_exec,
>> + .compat = COMPAT_DRIVER_XE,
>> + },
>> {
>> .ip_ver = IP_VER(20, 04),
>> .compute_exec = xe2lpg_compute_exec,
>> @@ -1719,11 +1734,27 @@ static const struct {
>> bool threadgroup_preemption);
>> uint32_t compat;
>> } intel_compute_preempt_batches[] = {
>> + {
>> + .ip_ver = IP_VER(20, 00),
>> + .compute_exec = xe2lpg_compute_preempt_exec,
>> + .compat = COMPAT_DRIVER_XE,
>> + },
>> + {
>> + .ip_ver = IP_VER(20, 01),
>> + .compute_exec = xe2lpg_compute_preempt_exec,
>> + .compat = COMPAT_DRIVER_XE,
>> + },
>> + {
>> + .ip_ver = IP_VER(20, 02),
>> + .compute_exec = xe2lpg_compute_preempt_exec,
>> + .compat = COMPAT_DRIVER_XE,
>> + },
>> {
>> .ip_ver = IP_VER(20, 04),
>> .compute_exec = xe2lpg_compute_preempt_exec,
>> .compat = COMPAT_DRIVER_XE,
>> },
>> +
>
> nit: Unwanted space
>
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Opps sorry, I didn't realize it was me as Author. Please ignore this.
>
>> };
>> static bool __run_intel_compute_kernel_preempt(int fd,
>> diff --git a/lib/intel_compute_square_kernels.c
>> b/lib/intel_compute_square_kernels.c
>> index efd55da0b9..39c34dc5e0 100644
>> --- a/lib/intel_compute_square_kernels.c
>> +++ b/lib/intel_compute_square_kernels.c
>> @@ -3866,6 +3866,34 @@ const struct intel_compute_kernels
>> intel_compute_square_kernels[] = {
>> .size = sizeof(xehpc_kernel_square_bin),
>> .kernel = xehpc_kernel_square_bin,
>> },
>> + {
>> + .ip_ver = IP_VER(20, 00),
>> + .size = sizeof(xe2lpg_kernel_square_bin),
>> + .kernel = xe2lpg_kernel_square_bin,
>> + .long_kernel = xe2lpg_kernel_inc_bin,
>> + .long_kernel_size = sizeof(xe2lpg_kernel_inc_bin),
>> + .sip_kernel = xe2lpg_kernel_sip_bin,
>> + .sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin),
>> + },
>> + {
>> + .ip_ver = IP_VER(20, 01),
>> + .size = sizeof(xe2lpg_kernel_square_bin),
>> + .kernel = xe2lpg_kernel_square_bin,
>> + .long_kernel = xe2lpg_kernel_inc_bin,
>> + .long_kernel_size = sizeof(xe2lpg_kernel_inc_bin),
>> + .sip_kernel = xe2lpg_kernel_sip_bin,
>> + .sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin),
>> + },
>> + {
>> + .ip_ver = IP_VER(20, 02),
>> + .size = sizeof(xe2lpg_kernel_square_bin),
>> + .kernel = xe2lpg_kernel_square_bin,
>> + .long_kernel = xe2lpg_kernel_inc_bin,
>> + .long_kernel_size = sizeof(xe2lpg_kernel_inc_bin),
>> + .sip_kernel = xe2lpg_kernel_sip_bin,
>> + .sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin),
>> + },
>> +
>> {
>> .ip_ver = IP_VER(20, 04),
>> .size = sizeof(xe2lpg_kernel_square_bin),
prev parent reply other threads:[~2024-07-22 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 9:45 [PATCH i-g-t] BMG: lib/intel_compute: Enable compute tests for BMG Zbigniew Kempczyński
2024-07-22 10:00 ` Nirmoy Das
2024-07-22 10:02 ` Nirmoy Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cdcb1d2-263f-41fe-9456-fd0be8c39be1@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox