Re: [PATCH i-g-t] BMG: lib/intel_compute: Enable compute tests for BMG

[Nirmoy Das <nirmoy.das@linux.intel.com>]

On 7/22/2024 11:45 AM, Zbigniew Kempczyński wrote:
> From: Nirmoy Das <nirmoy.das@intel.com>
>
> BMG is XE2 based so compute tests should run as it is.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
>   lib/intel_compute.c                | 31 ++++++++++++++++++++++++++++++
>   lib/intel_compute_square_kernels.c | 28 +++++++++++++++++++++++++++
>   2 files changed, 59 insertions(+)
>
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 72025a4811..54d1814f38 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -1449,6 +1449,21 @@ static const struct {
>   		.compute_exec = xehpc_compute_exec,
>   		.compat = COMPAT_DRIVER_XE,
>   	},
> +	{
> +		.ip_ver = IP_VER(20, 00),
> +		.compute_exec = xe2lpg_compute_exec,
> +		.compat = COMPAT_DRIVER_XE,
> +	},
> +	{
> +		.ip_ver = IP_VER(20, 01),
> +		.compute_exec = xe2lpg_compute_exec,
> +		.compat = COMPAT_DRIVER_XE,
> +	},
> +	{
> +		.ip_ver = IP_VER(20, 02),
> +		.compute_exec = xe2lpg_compute_exec,
> +		.compat = COMPAT_DRIVER_XE,
> +	},
>   	{
>   		.ip_ver = IP_VER(20, 04),
>   		.compute_exec = xe2lpg_compute_exec,
> @@ -1719,11 +1734,27 @@ static const struct {
>   			     bool threadgroup_preemption);
>   	uint32_t compat;
>   } intel_compute_preempt_batches[] = {
> +	{
> +		.ip_ver = IP_VER(20, 00),
> +		.compute_exec = xe2lpg_compute_preempt_exec,
> +		.compat = COMPAT_DRIVER_XE,
> +	},
> +	{
> +		.ip_ver = IP_VER(20, 01),
> +		.compute_exec = xe2lpg_compute_preempt_exec,
> +		.compat = COMPAT_DRIVER_XE,
> +	},
> +	{
> +		.ip_ver = IP_VER(20, 02),
> +		.compute_exec = xe2lpg_compute_preempt_exec,
> +		.compat = COMPAT_DRIVER_XE,
> +	},
>   	{
>   		.ip_ver = IP_VER(20, 04),
>   		.compute_exec = xe2lpg_compute_preempt_exec,
>   		.compat = COMPAT_DRIVER_XE,
>   	},
> +

nit: Unwanted space

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

>   };
>   
>   static bool __run_intel_compute_kernel_preempt(int fd,
> diff --git a/lib/intel_compute_square_kernels.c b/lib/intel_compute_square_kernels.c
> index efd55da0b9..39c34dc5e0 100644
> --- a/lib/intel_compute_square_kernels.c
> +++ b/lib/intel_compute_square_kernels.c
> @@ -3866,6 +3866,34 @@ const struct intel_compute_kernels intel_compute_square_kernels[] = {
>   		.size = sizeof(xehpc_kernel_square_bin),
>   		.kernel = xehpc_kernel_square_bin,
>   	},
> +	{
> +		.ip_ver = IP_VER(20, 00),
> +		.size = sizeof(xe2lpg_kernel_square_bin),
> +		.kernel = xe2lpg_kernel_square_bin,
> +		.long_kernel = xe2lpg_kernel_inc_bin,
> +		.long_kernel_size = sizeof(xe2lpg_kernel_inc_bin),
> +		.sip_kernel = xe2lpg_kernel_sip_bin,
> +		.sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin),
> +	},
> +	{
> +		.ip_ver = IP_VER(20, 01),
> +		.size = sizeof(xe2lpg_kernel_square_bin),
> +		.kernel = xe2lpg_kernel_square_bin,
> +		.long_kernel = xe2lpg_kernel_inc_bin,
> +		.long_kernel_size = sizeof(xe2lpg_kernel_inc_bin),
> +		.sip_kernel = xe2lpg_kernel_sip_bin,
> +		.sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin),
> +	},
> +	{
> +		.ip_ver = IP_VER(20, 02),
> +		.size = sizeof(xe2lpg_kernel_square_bin),
> +		.kernel = xe2lpg_kernel_square_bin,
> +		.long_kernel = xe2lpg_kernel_inc_bin,
> +		.long_kernel_size = sizeof(xe2lpg_kernel_inc_bin),
> +		.sip_kernel = xe2lpg_kernel_sip_bin,
> +		.sip_kernel_size = sizeof(xe2lpg_kernel_sip_bin),
> +	},
> +
>   	{
>   		.ip_ver = IP_VER(20, 04),
>   		.size = sizeof(xe2lpg_kernel_square_bin),