From: "Kempczynski, Zbigniew" <zbigniew.kempczynski@intel.com>
To: "Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>,
"Dec, Katarzyna" <katarzyna.dec@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL
Date: Tue, 17 Sep 2019 04:14:20 +0000 [thread overview]
Message-ID: <4e223dabd4bfbf403106cbfc5895d180a2b61f13.camel@intel.com> (raw)
In-Reply-To: <20190916154435.vpyjzvs5o6fkgnfz@ahiler-desk1.fi.intel.com>
On Mon, 2019-09-16 at 18:44 +0300, Arkadiusz Hiler wrote:
> On Fri, Sep 13, 2019 at 02:49:02PM +0200, Katarzyna Dec wrote:
> >
> > + else if (IS_TIGERLAKE(devid))
> > + fill = gen12p1_gpgpu_fillfunc;
>
> I find this naming a bit odd.
>
> If you don't want to overenable it for all GEN12 because you don't know
> what the future brings I think we should go with tgl_*_fillfunc, so it's
> closer to what we do in kernel (using platform codenames as function
> prefixes). This way it isalso direcly related to check
> (IS_TIGERLAKE()).
>
> If it proves to be generic then we can alway change the check to
> IS_GEN12() or whatever and rename the function accordingly.
>
> This applies to the media variant too.
>
> Other than that looks good, let's see what the CI says.
>
First patch version had this naming convention, tgl_ as prefix,
but we got negative feedback and suggestion that function should
contain genX in the name and selection should be using IS_TIGERLAKE()
macro. Due to many reasons naming in gen12 is not easy, so imo
we've chosen best option.
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-09-17 4:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 12:49 [igt-dev] [PATCH i-g-t 0/2] Enabling gpgpu_fill and media_fill on TGL Katarzyna Dec
2019-09-13 12:49 ` [igt-dev] [PATCH i-g-t 1/2] lib/gpgpu_fill/tgl: Implement gpgpu_fillfunc for TGL Katarzyna Dec
2019-09-16 15:44 ` Arkadiusz Hiler
2019-09-17 4:14 ` Kempczynski, Zbigniew [this message]
2019-09-16 19:47 ` Caz Yokoyama
2019-09-17 2:18 ` Ashutosh Dixit
2019-09-13 12:49 ` [igt-dev] [PATCH i-g-t 2/2] lib/media_fill/tgl: Implement media_fillfunc " Katarzyna Dec
2019-09-13 13:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Enabling gpgpu_fill and media_fill on TGL Patchwork
2019-09-14 12:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-09-16 15:29 ` [igt-dev] [PATCH i-g-t 0/2] " Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e223dabd4bfbf403106cbfc5895d180a2b61f13.camel@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox