* [igt-dev] [PATCH v3 0/1] test/gem_create: exercise gem_create_ext_set_pat
@ 2023-05-12 17:51 fei.yang
2023-05-12 17:51 ` [igt-dev] [PATCH v3 1/1] " fei.yang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: fei.yang @ 2023-05-12 17:51 UTC (permalink / raw)
To: igt-dev; +Cc: Fei Yang
From: Fei Yang <fei.yang@intel.com>
This is the first draft of a new test case exercising the set_pat
extension for GEM_CREATE.
v2: make sure {get|set}_caching ioctls are disabled.
v3: move header change to lib/i915/i915_drm_local.h, will submit a
separate patch for include/uapi/drm/i915_drm.h after the kernel
change lands in upstream.
Fei Yang (1):
test/gem_create: exercise gem_create_ext_set_pat
lib/i915/i915_drm_local.h | 34 ++++++++++++++++++++++++++++++
tests/i915/gem_create.c | 44 +++++++++++++++++++++++++++++++++++++++
2 files changed, 78 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH v3 1/1] test/gem_create: exercise gem_create_ext_set_pat
2023-05-12 17:51 [igt-dev] [PATCH v3 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
@ 2023-05-12 17:51 ` fei.yang
2023-05-15 10:49 ` Tvrtko Ursulin
2023-05-12 20:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-12 23:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: fei.yang @ 2023-05-12 17:51 UTC (permalink / raw)
To: igt-dev; +Cc: Fei Yang
From: Fei Yang <fei.yang@intel.com>
Gem_create uAPI has been extended with capability of setting PAT index.
Add a test case to exercise this new extension.
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
lib/i915/i915_drm_local.h | 34 ++++++++++++++++++++++++++++++
tests/i915/gem_create.c | 44 +++++++++++++++++++++++++++++++++++++++
2 files changed, 78 insertions(+)
diff --git a/lib/i915/i915_drm_local.h b/lib/i915/i915_drm_local.h
index af017650..35929a0c 100644
--- a/lib/i915/i915_drm_local.h
+++ b/lib/i915/i915_drm_local.h
@@ -26,6 +26,40 @@ extern "C" {
#define DRM_I915_PERF_PROP_OA_ENGINE_CLASS 9
#define DRM_I915_PERF_PROP_OA_ENGINE_INSTANCE 10
+#define I915_GEM_CREATE_EXT_SET_PAT 2
+
+/**
+ * struct drm_i915_gem_create_ext_set_pat - The
+ * I915_GEM_CREATE_EXT_SET_PAT extension.
+ *
+ * If this extension is provided, the specified caching policy (PAT index) is
+ * applied to the buffer object.
+ *
+ * Below is an example on how to create an object with specific caching policy:
+ *
+ * .. code-block:: C
+ *
+ * struct drm_i915_gem_create_ext_set_pat set_pat_ext = {
+ * .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
+ * .pat_index = 0,
+ * };
+ * struct drm_i915_gem_create_ext create_ext = {
+ * .size = PAGE_SIZE,
+ * .extensions = (uintptr_t)&set_pat_ext,
+ * };
+ *
+ * int err = ioctl(fd, DRM_IOCTL_I915_GEM_CREATE_EXT, &create_ext);
+ * if (err) ...
+ */
+struct drm_i915_gem_create_ext_set_pat {
+ /** @base: Extension link. See struct i915_user_extension. */
+ struct i915_user_extension base;
+ /** @pat_index: PAT index to be set */
+ __u32 pat_index;
+ /** @rsvd: reserved for future use */
+ __u32 rsvd;
+};
+
#if defined(__cplusplus)
}
#endif
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index c719ab6c..20c71afb 100644
--- a/tests/i915/gem_create.c
+++ b/tests/i915/gem_create.c
@@ -537,6 +537,45 @@ static void create_ext_placement_each(int fd)
free(regions);
}
+static void create_ext_set_pat(int fd)
+{
+ struct drm_i915_gem_create_ext_set_pat setparam_pat = {
+ .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
+ .pat_index = 0,
+ };
+ struct drm_i915_gem_create_ext_set_pat setparam_inv_pat = {
+ .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
+ .pat_index = 65,
+ };
+ struct drm_i915_gem_caching arg;
+ uint64_t size;
+ uint32_t handle;
+ int ret;
+
+ size = PAGE_SIZE;
+
+ ret = __gem_create_ext(fd, &size, 0, &handle, &setparam_pat.base);
+
+ /* Returning -EFAULT indicates set_pat extension is not supported */
+ if (ret == -EFAULT)
+ igt_info("I915_GEM_CREATE_EXT_SET_PAT is not supported\n");
+ igt_assert(ret == 0);
+
+ /* {set|get}_caching ioctl should fail for objects created with set_pat */
+ igt_assert(__gem_set_caching(fd, handle, 1) == -EOPNOTSUPP);
+
+ memset(&arg, 0, sizeof(arg));
+ arg.handle = handle;
+ igt_assert(ioctl(fd, DRM_IOCTL_I915_GEM_GET_CACHING, &arg) < 0 &&
+ errno == EOPNOTSUPP);
+
+ /* gem_create should fail with -EINVAL if invalid pat index specified */
+ igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle, &setparam_inv_pat.base),
+ -EINVAL);
+
+ gem_close(fd, handle);
+}
+
static bool supports_needs_cpu_access(int fd)
{
struct drm_i915_gem_memory_class_instance regions[] = {
@@ -897,6 +936,11 @@ igt_main
igt_subtest("create-ext-placement-all")
create_ext_placement_all(fd);
+ igt_describe("Create objects with specific cache setting"
+ " create-ext.");
+ igt_subtest("create-ext-set-pat")
+ create_ext_set_pat(fd);
+
igt_describe("Verify the basic functionally and expected ABI contract around I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS");
igt_subtest("create-ext-cpu-access-sanity-check") {
igt_require(supports_needs_cpu_access(fd));
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for test/gem_create: exercise gem_create_ext_set_pat
2023-05-12 17:51 [igt-dev] [PATCH v3 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
2023-05-12 17:51 ` [igt-dev] [PATCH v3 1/1] " fei.yang
@ 2023-05-12 20:26 ` Patchwork
2023-05-12 23:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-05-12 20:26 UTC (permalink / raw)
To: Yang, Fei; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4755 bytes --]
== Series Details ==
Series: test/gem_create: exercise gem_create_ext_set_pat
URL : https://patchwork.freedesktop.org/series/117695/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13143 -> IGTPW_8952
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/index.html
Participating hosts (38 -> 36)
------------------------------
Missing (2): fi-apl-guc fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8952 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][1] ([i915#7077])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_selftest@live@mman:
- bat-rpls-2: [PASS][2] -> [TIMEOUT][3] ([i915#6794] / [i915#7392])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rpls-2/igt@i915_selftest@live@mman.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-rpls-2/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][4] -> [ABORT][5] ([i915#4983] / [i915#7911] / [i915#7920] / [i915#7953])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rpls-1/igt@i915_selftest@live@requests.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][6] ([i915#6687])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [PASS][7] -> [FAIL][8] ([i915#7932])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- {bat-mtlp-8}: [ABORT][9] ([i915#4983] / [i915#7920] / [i915#7953]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-mtlp-8/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-mtlp-8/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][11] ([i915#4579] / [i915#8260]) -> [SKIP][12] ([i915#3555] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7286 -> IGTPW_8952
CI-20190529: 20190529
CI_DRM_13143: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8952: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/index.html
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@gem_create@create-ext-set-pat
-igt@kms_fb_coherency@memset-crc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/index.html
[-- Attachment #2: Type: text/html, Size: 5563 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for test/gem_create: exercise gem_create_ext_set_pat
2023-05-12 17:51 [igt-dev] [PATCH v3 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
2023-05-12 17:51 ` [igt-dev] [PATCH v3 1/1] " fei.yang
2023-05-12 20:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-05-12 23:06 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-05-12 23:06 UTC (permalink / raw)
To: Yang, Fei; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 17415 bytes --]
== Series Details ==
Series: test/gem_create: exercise gem_create_ext_set_pat
URL : https://patchwork.freedesktop.org/series/117695/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13143_full -> IGTPW_8952_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8952_full:
### IGT changes ###
#### Possible regressions ####
* {igt@gem_create@create-ext-set-pat} (NEW):
- shard-glk: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk3/igt@gem_create@create-ext-set-pat.html
- {shard-rkl}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-rkl-3/igt@gem_create@create-ext-set-pat.html
- shard-snb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-snb7/igt@gem_create@create-ext-set-pat.html
- {shard-dg1}: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-dg1-15/igt@gem_create@create-ext-set-pat.html
- shard-apl: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-apl3/igt@gem_create@create-ext-set-pat.html
- {shard-tglu}: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-tglu-5/igt@gem_create@create-ext-set-pat.html
New tests
---------
New tests have been introduced between CI_DRM_13143_full and IGTPW_8952_full:
### New IGT tests (1) ###
* igt@gem_create@create-ext-set-pat:
- Statuses : 6 fail(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8952_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk5/igt@gem_lmem_swapping@massive-random.html
* igt@kms_chamelium_color@ctm-max:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271]) +26 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk9/igt@kms_chamelium_color@ctm-max.html
* igt@kms_content_protection@atomic:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4579])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk8/igt@kms_content_protection@atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2346])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2346])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#79])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-apl: [PASS][16] -> [FAIL][17] ([i915#79])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-apl3/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
* igt@kms_flip@plain-flip-ts-check@b-hdmi-a2:
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#2122])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk1/igt@kms_flip@plain-flip-ts-check@b-hdmi-a2.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk7/igt@kms_flip@plain-flip-ts-check@b-hdmi-a2.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [PASS][20] -> [ABORT][21] ([i915#180])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][22] ([i915#7742]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-rkl-1/igt@drm_fdinfo@virtual-idle.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [ABORT][24] ([i915#7461] / [i915#8211]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@gem_barrier_race@remote-request@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][26] ([i915#6786]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-15/igt@gem_ctx_freq@sysfs.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-dg1-12/igt@gem_ctx_freq@sysfs.html
* igt@gem_eio@hibernate:
- {shard-dg1}: [ABORT][28] ([i915#7975] / [i915#8213]) -> [PASS][29] +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-14/igt@gem_eio@hibernate.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-dg1-18/igt@gem_eio@hibernate.html
* igt@gem_eio@in-flight-contexts-10ms:
- {shard-tglu}: [TIMEOUT][30] ([i915#3063] / [i915#7941]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-tglu-3/igt@gem_eio@in-flight-contexts-10ms.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-tglu-2/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][32] ([i915#5784]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-12/igt@gem_eio@reset-stress.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-dg1-16/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][34] ([i915#2846]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-rkl-1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-rkl}: [FAIL][36] ([i915#2842]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-apl: [FAIL][38] ([i915#2842]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
- {shard-tglu}: [FAIL][40] ([i915#2842]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-tglu-10/igt@gem_exec_fair@basic-pace-share@rcs0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-tglu-7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][42] ([i915#5493]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-dg1-18/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][44] ([i915#5566]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk3/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][46] ([i915#8011]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-7/igt@kms_cursor_legacy@single-bo@pipe-b.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-rkl-4/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][48] ([i915#79]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@perf_pmu@idle@rcs0:
- {shard-dg1}: [FAIL][50] ([i915#4349]) -> [PASS][51] +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-16/igt@perf_pmu@idle@rcs0.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-dg1-17/igt@perf_pmu@idle@rcs0.html
#### Warnings ####
* igt@kms_content_protection@mei_interface:
- shard-snb: [SKIP][52] ([fdo#109271] / [i915#4579]) -> [SKIP][53] ([fdo#109271])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-snb4/igt@kms_content_protection@mei_interface.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/shard-snb2/igt@kms_content_protection@mei_interface.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7286 -> IGTPW_8952
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13143: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8952: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/index.html
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8952/index.html
[-- Attachment #2: Type: text/html, Size: 14798 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH v3 1/1] test/gem_create: exercise gem_create_ext_set_pat
2023-05-12 17:51 ` [igt-dev] [PATCH v3 1/1] " fei.yang
@ 2023-05-15 10:49 ` Tvrtko Ursulin
2023-05-15 20:23 ` Yang, Fei
0 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2023-05-15 10:49 UTC (permalink / raw)
To: fei.yang, igt-dev
On 12/05/2023 18:51, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
>
> Gem_create uAPI has been extended with capability of setting PAT index.
> Add a test case to exercise this new extension.
>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
> lib/i915/i915_drm_local.h | 34 ++++++++++++++++++++++++++++++
> tests/i915/gem_create.c | 44 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 78 insertions(+)
>
> diff --git a/lib/i915/i915_drm_local.h b/lib/i915/i915_drm_local.h
> index af017650..35929a0c 100644
> --- a/lib/i915/i915_drm_local.h
> +++ b/lib/i915/i915_drm_local.h
> @@ -26,6 +26,40 @@ extern "C" {
> #define DRM_I915_PERF_PROP_OA_ENGINE_CLASS 9
> #define DRM_I915_PERF_PROP_OA_ENGINE_INSTANCE 10
>
> +#define I915_GEM_CREATE_EXT_SET_PAT 2
> +
> +/**
> + * struct drm_i915_gem_create_ext_set_pat - The
> + * I915_GEM_CREATE_EXT_SET_PAT extension.
> + *
> + * If this extension is provided, the specified caching policy (PAT index) is
> + * applied to the buffer object.
> + *
> + * Below is an example on how to create an object with specific caching policy:
> + *
> + * .. code-block:: C
> + *
> + * struct drm_i915_gem_create_ext_set_pat set_pat_ext = {
> + * .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> + * .pat_index = 0,
> + * };
> + * struct drm_i915_gem_create_ext create_ext = {
> + * .size = PAGE_SIZE,
> + * .extensions = (uintptr_t)&set_pat_ext,
> + * };
> + *
> + * int err = ioctl(fd, DRM_IOCTL_I915_GEM_CREATE_EXT, &create_ext);
> + * if (err) ...
> + */
> +struct drm_i915_gem_create_ext_set_pat {
> + /** @base: Extension link. See struct i915_user_extension. */
> + struct i915_user_extension base;
> + /** @pat_index: PAT index to be set */
> + __u32 pat_index;
> + /** @rsvd: reserved for future use */
> + __u32 rsvd;
> +};
> +
> #if defined(__cplusplus)
> }
> #endif
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index c719ab6c..20c71afb 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -537,6 +537,45 @@ static void create_ext_placement_each(int fd)
> free(regions);
> }
>
> +static void create_ext_set_pat(int fd)
> +{
> + struct drm_i915_gem_create_ext_set_pat setparam_pat = {
> + .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> + .pat_index = 0,
> + };
> + struct drm_i915_gem_create_ext_set_pat setparam_inv_pat = {
> + .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> + .pat_index = 65,
> + };
> + struct drm_i915_gem_caching arg;
> + uint64_t size;
> + uint32_t handle;
> + int ret;
> +
> + size = PAGE_SIZE;
> +
> + ret = __gem_create_ext(fd, &size, 0, &handle, &setparam_pat.base);
> +
> + /* Returning -EFAULT indicates set_pat extension is not supported */
> + if (ret == -EFAULT)
> + igt_info("I915_GEM_CREATE_EXT_SET_PAT is not supported\n");
Is this correct? EFAULT should be data access issues while unsupported
extensions should be EINVAL.
> + igt_assert(ret == 0);
Extension not supported should be a skip I would say.
EFAULT test is then something else, ie. hitting this path from the
kernel ioctl handler:
ext_set_pat()
...
+ if (copy_from_user(&ext, base, sizeof(ext)))
+ return -EFAULT;
> +
> + /* {set|get}_caching ioctl should fail for objects created with set_pat */
> + igt_assert(__gem_set_caching(fd, handle, 1) == -EOPNOTSUPP);
Easy to test get too as the comment suggests?
Regards,
Tvrtko
> +
> + memset(&arg, 0, sizeof(arg));
> + arg.handle = handle;
> + igt_assert(ioctl(fd, DRM_IOCTL_I915_GEM_GET_CACHING, &arg) < 0 &&
> + errno == EOPNOTSUPP);
> +
> + /* gem_create should fail with -EINVAL if invalid pat index specified */
> + igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle, &setparam_inv_pat.base),
> + -EINVAL);
> +
> + gem_close(fd, handle);
> +}
> +
> static bool supports_needs_cpu_access(int fd)
> {
> struct drm_i915_gem_memory_class_instance regions[] = {
> @@ -897,6 +936,11 @@ igt_main
> igt_subtest("create-ext-placement-all")
> create_ext_placement_all(fd);
>
> + igt_describe("Create objects with specific cache setting"
> + " create-ext.");
> + igt_subtest("create-ext-set-pat")
> + create_ext_set_pat(fd);
> +
> igt_describe("Verify the basic functionally and expected ABI contract around I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS");
> igt_subtest("create-ext-cpu-access-sanity-check") {
> igt_require(supports_needs_cpu_access(fd));
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH v3 1/1] test/gem_create: exercise gem_create_ext_set_pat
2023-05-15 10:49 ` Tvrtko Ursulin
@ 2023-05-15 20:23 ` Yang, Fei
0 siblings, 0 replies; 6+ messages in thread
From: Yang, Fei @ 2023-05-15 20:23 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev@lists.freedesktop.org
[-- Attachment #1: Type: text/plain, Size: 5132 bytes --]
> On 12/05/2023 18:51, fei.yang@intel.com wrote:
>> From: Fei Yang <fei.yang@intel.com>
>>
>> Gem_create uAPI has been extended with capability of setting PAT index.
>> Add a test case to exercise this new extension.
>>
>> Signed-off-by: Fei Yang <fei.yang@intel.com>
>> ---
>> lib/i915/i915_drm_local.h | 34 ++++++++++++++++++++++++++++++
>> tests/i915/gem_create.c | 44 +++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 78 insertions(+)
>>
>> diff --git a/lib/i915/i915_drm_local.h b/lib/i915/i915_drm_local.h
>> index af017650..35929a0c 100644
>> --- a/lib/i915/i915_drm_local.h
>> +++ b/lib/i915/i915_drm_local.h
>> @@ -26,6 +26,40 @@ extern "C" {
>> #define DRM_I915_PERF_PROP_OA_ENGINE_CLASS 9
>> #define DRM_I915_PERF_PROP_OA_ENGINE_INSTANCE 10
>>
>> +#define I915_GEM_CREATE_EXT_SET_PAT 2
>> +
>> +/**
>> + * struct drm_i915_gem_create_ext_set_pat - The
>> + * I915_GEM_CREATE_EXT_SET_PAT extension.
>> + *
>> + * If this extension is provided, the specified caching policy (PAT
>> +index) is
>> + * applied to the buffer object.
>> + *
>> + * Below is an example on how to create an object with specific caching policy:
>> + *
>> + * .. code-block:: C
>> + *
>> + * struct drm_i915_gem_create_ext_set_pat set_pat_ext = {
>> + * .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
>> + * .pat_index = 0,
>> + * };
>> + * struct drm_i915_gem_create_ext create_ext = {
>> + * .size = PAGE_SIZE,
>> + * .extensions = (uintptr_t)&set_pat_ext,
>> + * };
>> + *
>> + * int err = ioctl(fd, DRM_IOCTL_I915_GEM_CREATE_EXT, &create_ext);
>> + * if (err) ...
>> + */
>> +struct drm_i915_gem_create_ext_set_pat {
>> + /** @base: Extension link. See struct i915_user_extension. */
>> + struct i915_user_extension base;
>> + /** @pat_index: PAT index to be set */
>> + __u32 pat_index;
>> + /** @rsvd: reserved for future use */
>> + __u32 rsvd;
>> +};
>> +
>> #if defined(__cplusplus)
>> }
>> #endif
>> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c index
>> c719ab6c..20c71afb 100644
>> --- a/tests/i915/gem_create.c
>> +++ b/tests/i915/gem_create.c
>> @@ -537,6 +537,45 @@ static void create_ext_placement_each(int fd)
>> free(regions);
>> }
>>
>> +static void create_ext_set_pat(int fd) {
>> + struct drm_i915_gem_create_ext_set_pat setparam_pat = {
>> + .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
>> + .pat_index = 0,
>> + };
>> + struct drm_i915_gem_create_ext_set_pat setparam_inv_pat = {
>> + .base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
>> + .pat_index = 65,
>> + };
>> + struct drm_i915_gem_caching arg;
>> + uint64_t size;
>> + uint32_t handle;
>> + int ret;
>> +
>> + size = PAGE_SIZE;
>> +
>> + ret = __gem_create_ext(fd, &size, 0, &handle, &setparam_pat.base);
>> +
>> + /* Returning -EFAULT indicates set_pat extension is not supported */
>> + if (ret == -EFAULT)
>> + igt_info("I915_GEM_CREATE_EXT_SET_PAT is not supported\n");
>
> Is this correct? EFAULT should be data access issues while unsupported extensions should be EINVAL.
Wil correct.
>> + igt_assert(ret == 0);
>
> Extension not supported should be a skip I would say.
Will replace igt_info with igt_skip.
> EFAULT test is then something else, ie. hitting this path from the kernel ioctl handler:
>
> ext_set_pat()
> ...
> + if (copy_from_user(&ext, base, sizeof(ext)))
> + return -EFAULT;
>
>> +
>> + /* {set|get}_caching ioctl should fail for objects created with set_pat */
>> + igt_assert(__gem_set_caching(fd, handle, 1) == -EOPNOTSUPP);
>
> Easy to test get too as the comment suggests?
The ioctl right below is exercising get_caching ioctl.
I couldn't use gem_get_caching() because it overwrites errno.
> Regards,
>
> Tvrtko
>
>> +
>> + memset(&arg, 0, sizeof(arg));
>> + arg.handle = handle;
>> + igt_assert(ioctl(fd, DRM_IOCTL_I915_GEM_GET_CACHING, &arg) < 0 &&
>> + errno == EOPNOTSUPP);
>> +
>> + /* gem_create should fail with -EINVAL if invalid pat index specified */
>> + igt_assert_eq(__gem_create_ext(fd, &size, 0, &handle, &setparam_inv_pat.base),
>> + -EINVAL);
>> +
>> + gem_close(fd, handle);
>> +}
>> +
>> static bool supports_needs_cpu_access(int fd)
>> {
>> struct drm_i915_gem_memory_class_instance regions[] = { @@ -897,6
>> +936,11 @@ igt_main
>> igt_subtest("create-ext-placement-all")
>> create_ext_placement_all(fd);
>>
>> + igt_describe("Create objects with specific cache setting"
>> + " create-ext.");
>> + igt_subtest("create-ext-set-pat")
>> + create_ext_set_pat(fd);
>> +
>> igt_describe("Verify the basic functionally and expected ABI contract around I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS");
>> igt_subtest("create-ext-cpu-access-sanity-check") {
>> igt_require(supports_needs_cpu_access(fd));
[-- Attachment #2: Type: text/html, Size: 12352 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-15 20:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 17:51 [igt-dev] [PATCH v3 0/1] test/gem_create: exercise gem_create_ext_set_pat fei.yang
2023-05-12 17:51 ` [igt-dev] [PATCH v3 1/1] " fei.yang
2023-05-15 10:49 ` Tvrtko Ursulin
2023-05-15 20:23 ` Yang, Fei
2023-05-12 20:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-05-12 23:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox