Re: [PATCH i-g-t] tests/kms_plane_cursor: limit simulation to 2 pipes

[Karthik B S <karthik.b.s@intel.com>]

Hi Jeevan,

On 12-11-2026 09:49, Jeevan B wrote:
> Running on every pipe makes the test hit the timeout on simulation.
> Restrict it to 2 pipes when running in simulation.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/kms_plane_cursor.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 4b69f1a17..5938b50c1 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -68,6 +68,9 @@ typedef struct {
>   	int h;
>   } rect_t;
>   
> +/* Max pipes to test on simulation, to avoid timeouts */
> +#define SIM_MAX_PIPES 2
> +
>   /* Common test data. */
>   typedef struct data {
>   	igt_display_t display;
> @@ -327,8 +330,14 @@ int igt_main()
>   	for (i = 0; i < ARRAY_SIZE(tests); i++) {
>   		igt_describe_f("%s", tests[i].desc);
>   		igt_subtest_with_dynamic_f("%s", tests[i].name) {
> +			int pipes_tested = 0;
> +
>   			for_each_crtc_with_single_output(&data.display, crtc,
>   							 output) {
> +				if (igt_run_in_simulation() &&
> +				    pipes_tested >= SIM_MAX_PIPES)
> +					break;
Running on first pipe and last pipe is better than running on the first 
2 pipe from coverage pov, IMHO.
> +
>   				if ((tests[i].flags & TEST_OVERLAY) &&
>   				    !igt_crtc_get_plane_type(crtc,
>   							     DRM_PLANE_TYPE_OVERLAY))
> @@ -361,6 +370,7 @@ int igt_main()
>   				}
>   
>   				test_fini(&data);
> +				pipes_tested++;

  Nit: consider moving the limit check next to the increment at the end 
of the loop,

  if (igt_run_in_simulation() && ++pipes_tested >= SIM_MAX_PIPES)
      break;
Regards,
Karthik.B.S
>   			}
>   		}
>   	}