Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_plane_cursor: limit simulation to 2 pipes
Date: Fri, 13 Nov 2026 15:53:11 +0200	[thread overview]
Message-ID: <566ec9cb86e08992f2f89b18553562230d7dd30e@intel.com> (raw)
In-Reply-To: <20261112041907.2876691-1-jeevan.b@intel.com>

On Thu, 12 Nov 2026, Jeevan B <jeevan.b@intel.com> wrote:
> Running on every pipe makes the test hit the timeout on simulation.
> Restrict it to 2 pipes when running in simulation.

This is not an Intel specific test. We should prefer generic drm/kms
naming in generic code, i.e. CRTC instead of pipe.

BR,
Jani.



>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>  tests/kms_plane_cursor.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 4b69f1a17..5938b50c1 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -68,6 +68,9 @@ typedef struct {
>  	int h;
>  } rect_t;
>  
> +/* Max pipes to test on simulation, to avoid timeouts */
> +#define SIM_MAX_PIPES 2
> +
>  /* Common test data. */
>  typedef struct data {
>  	igt_display_t display;
> @@ -327,8 +330,14 @@ int igt_main()
>  	for (i = 0; i < ARRAY_SIZE(tests); i++) {
>  		igt_describe_f("%s", tests[i].desc);
>  		igt_subtest_with_dynamic_f("%s", tests[i].name) {
> +			int pipes_tested = 0;
> +
>  			for_each_crtc_with_single_output(&data.display, crtc,
>  							 output) {
> +				if (igt_run_in_simulation() &&
> +				    pipes_tested >= SIM_MAX_PIPES)
> +					break;
> +
>  				if ((tests[i].flags & TEST_OVERLAY) &&
>  				    !igt_crtc_get_plane_type(crtc,
>  							     DRM_PLANE_TYPE_OVERLAY))
> @@ -361,6 +370,7 @@ int igt_main()
>  				}
>  
>  				test_fini(&data);
> +				pipes_tested++;
>  			}
>  		}
>  	}

-- 
Jani Nikula, Intel

      parent reply	other threads:[~2026-11-13 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  4:19 [PATCH i-g-t] tests/kms_plane_cursor: limit simulation to 2 pipes Jeevan B
2026-11-12  5:07 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-11-12  5:26 ` ✓ i915.CI.BAT: " Patchwork
2026-11-12 10:32 ` ✓ Xe.CI.FULL: " Patchwork
2026-11-13  0:11 ` ✗ i915.CI.Full: failure " Patchwork
2026-11-13 13:36 ` [PATCH i-g-t] " Karthik B S
2026-11-13 13:53 ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566ec9cb86e08992f2f89b18553562230d7dd30e@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox