Re: [igt-dev] [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc

["Vudum, Lakshminarayana" <lakshminarayana.vudum@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5899 bytes --]

Re-reported.

From: Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>
Sent: Tuesday, October 12, 2021 10:57 PM
To: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; igt-dev@lists.freedesktop.org
Cc: Choi, Nicholas <Nicholas.Choi@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; contact@emersion.fr
Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc


[AMD Official Use Only]

Hi Lakshminarayana,

Here it is: https://patchwork.freedesktop.org/series/95601/


Regards

Stylon Wang

MTS Software Development Eng.  |  AMD
Display Solution Team

O +(886) 2-3789-3667 ext. 23667  C +(886) 921-897-142

----------------------------------------------------------------------------------------------------------------------------------

6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan

Facebook<https://www.facebook.com/AMD> |  Twitter<https://twitter.com/AMD> |  amd.com<http://www.amd.com/>



________________________________
From: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com<mailto:lakshminarayana.vudum@intel.com>>
Sent: October 9, 2021 5:04 AM
To: Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com<mailto:Rodrigo.Siqueira@amd.com>>; igt-dev@lists.freedesktop.org<mailto:igt-dev@lists.freedesktop.org> <igt-dev@lists.freedesktop.org<mailto:igt-dev@lists.freedesktop.org>>
Cc: Choi, Nicholas <Nicholas.Choi@amd.com<mailto:Nicholas.Choi@amd.com>>; Wentland, Harry <Harry.Wentland@amd.com<mailto:Harry.Wentland@amd.com>>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com<mailto:Nicholas.Kazlauskas@amd.com>>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com<mailto:Rodrigo.Siqueira@amd.com>>; contact@emersion.fr<mailto:contact@emersion.fr> <contact@emersion.fr<mailto:contact@emersion.fr>>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com<mailto:Stylon.Wang@amd.com>>
Subject: RE: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc

Can you please post the series link here?

Lakshmi.
-----Original Message-----
From: Rodrigo Siqueira Jordao <rjordrigo@amd.com<mailto:rjordrigo@amd.com>>
Sent: Friday, October 8, 2021 12:32 PM
To: igt-dev@lists.freedesktop.org<mailto:igt-dev@lists.freedesktop.org>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com<mailto:lakshminarayana.vudum@intel.com>>
Cc: nicholas.choi@amd.com<mailto:nicholas.choi@amd.com>; harry.wentland@amd.com<mailto:harry.wentland@amd.com>; nicholas.kazlauskas@amd.com<mailto:nicholas.kazlauskas@amd.com>; rodrigo.siqueira@amd.com<mailto:rodrigo.siqueira@amd.com>; contact@emersion.fr<mailto:contact@emersion.fr>; Stylon Wang <stylon.wang@amd.com<mailto:stylon.wang@amd.com>>
Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc

Hi Lakshminarayana,

It looks like that we have another false-positive result from the CI in this patch.

Thanks
Siqueira

On 2021-10-08 4:59 a.m., Stylon Wang wrote:
> The first commit with TEST_ONLY flag in bpc-switch subtests could fail
> the test, because previous state can be with any bpc or even wth no
> crtc assigned to the connector.
>
> v2:
> - Keep the test commit for its original purpose of checking
>    if 512x512 plane size works for the hardware.
> - Add new atomic commit so the setting of 8 bpc really takes effect.
>
> Signed-off-by: Stylon Wang <stylon.wang@amd.com<mailto:stylon.wang@amd.com>>
> ---
>   tests/kms_hdr.c | 22 +++++++++++++---------
>   1 file changed, 13 insertions(+), 9 deletions(-)
>
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c index
> 5b8529c8..273263db 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -213,16 +213,27 @@ static void test_bpc_switch_on_output(data_t
> *data, igt_output_t *output,
>
>                draw_hdr_pattern(&afb);
>
> -             /* Start in 8bpc. */
> +             /* Plane may be required to fit fullscreen. Check it here and allow
> +              * smaller plane size in following tests.
> +              */
>                igt_plane_set_fb(data->primary, &afb);
>                igt_plane_set_size(data->primary, data->w, data->h);
> -             igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8);
>                ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
>                if (!ret) {
>                        data->w = afb.width;
>                        data->h = afb.height;
>                }
>
> +             /* Start in 8bpc. */
> +             igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8);
> +             igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> +             /*
> +              * i915 driver doesn't expose max bpc as debugfs entry,
> +              * so limiting assert only for amd driver.
> +              */
> +             if (is_amdgpu_device(data->fd))
> +                     assert_output_bpc(data, 8);
> +
>                /*
>                 * amdgpu requires a primary plane when the CRTC is enabled.
>                 * However, some older Intel hardware (hsw) have scaling @@
> -232,13 +243,6 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output,
>                if (!is_amdgpu_device(data->fd))
>                        igt_plane_set_fb(data->primary, NULL);
>
> -             /*
> -              * i915 driver doesn't expose max bpc as debugfs entry,
> -              * so limiting assert only for amd driver.
> -              */
> -             if (is_amdgpu_device(data->fd))
> -                     assert_output_bpc(data, 8);
> -
>                /* Switch to 10bpc. */
>                igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 10);
>                igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET,
> NULL);
>

[-- Attachment #2: Type: text/html, Size: 14660 bytes --]