Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [i-g-t] tests/intel-ci: Block unsupported KMS tests for i915
Date: Wed, 19 Jun 2024 15:56:54 +0530	[thread overview]
Message-ID: <515d6191-11cd-4b65-a142-ecfa7b5bb739@intel.com> (raw)
In-Reply-To: <87frt9fdwh.fsf@intel.com>


On 19-06-2024 03:33 pm, Jani Nikula wrote:
> On Wed, 19 Jun 2024, Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:
>> Block KMS tests those are specific to (display_ver > 14)
>> are not applicable for i915.
> 
> Feels a bit wrong to list features like this in a block list. IMO the
> tests themselves should be aware of what's supported and what's not. I
> imagine the rationale is performance? What's the impact?

I believe there is no point in running this test for i915, as it will 
always be skipped. The test already knows which platforms it supports 
and which it doesn't.

- Bhanu

> 
> BR,
> Jani.
> 
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/intel-ci/blacklist.txt | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
>> index f6e9bb474..d01ef5e16 100644
>> --- a/tests/intel-ci/blacklist.txt
>> +++ b/tests/intel-ci/blacklist.txt
>> @@ -140,3 +140,6 @@ igt@device_reset@reset-bound
>>   
>>   # not working for i915
>>   igt@kms_bw@.*
>> +
>> +# Tests specific to (Display_ver > 14) are not applicable for i915
>> +igt@kms_vrr@cmrr
> 

  reply	other threads:[~2024-06-19 10:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  9:20 [i-g-t] tests/intel-ci: Block unsupported KMS tests for i915 Bhanuprakash Modem
2024-06-19 10:03 ` Jani Nikula
2024-06-19 10:26   ` Modem, Bhanuprakash [this message]
2024-06-19 10:41     ` Jani Nikula
2024-06-20  5:05       ` Modem, Bhanuprakash
2024-06-20 10:58         ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515d6191-11cd-4b65-a142-ecfa7b5bb739@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox