Re: [i-g-t] tests/intel-ci: Block unsupported KMS tests for i915

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 19 Jun 2024, "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com> wrote:
> On 19-06-2024 03:33 pm, Jani Nikula wrote:
>> On Wed, 19 Jun 2024, Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:
>>> Block KMS tests those are specific to (display_ver > 14)
>>> are not applicable for i915.
>> 
>> Feels a bit wrong to list features like this in a block list. IMO the
>> tests themselves should be aware of what's supported and what's not. I
>> imagine the rationale is performance? What's the impact?
>
> I believe there is no point in running this test for i915, as it will 
> always be skipped. The test already knows which platforms it supports 
> and which it doesn't.

The question is whether it's worth it to start maintaining the info in
two places, the individual tests based on dynamic info obtained from the
driver, and a manually updated static block list.

Are you also filtering xe testing for tests applicable to old platforms
only? Is the manual work worth the effort?

BR,
Jani.


>
> - Bhanu
>
>> 
>> BR,
>> Jani.
>> 
>>>
>>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>> ---
>>>   tests/intel-ci/blacklist.txt | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
>>> index f6e9bb474..d01ef5e16 100644
>>> --- a/tests/intel-ci/blacklist.txt
>>> +++ b/tests/intel-ci/blacklist.txt
>>> @@ -140,3 +140,6 @@ igt@device_reset@reset-bound
>>>   
>>>   # not working for i915
>>>   igt@kms_bw@.*
>>> +
>>> +# Tests specific to (Display_ver > 14) are not applicable for i915
>>> +igt@kms_vrr@cmrr
>> 

-- 
Jani Nikula, Intel