Re: [igt-dev] [RFC 0/2] lib/xe_gpu: Introduce xe_gpu library

["Karas, Anna" <anna.karas@intel.com>]

Hi all,
CC-ing Mauro, Matthew and Zbyszek to this thread (btw. sorry for using 
@intel.com instead of @linux.intel.com in the original email)

@all - folks, any thoughts on opens? :)

On 20.04.2023 22:38, Souza, Jose wrote:
> On Thu, 2023-04-20 at 21:14 +0200, Anna Karas wrote:
>> OPENS:
>> 1. Lack of wedged concept in XE: @Matthew informed me that there is no
>> intent to have reporting wedged device in XE. However, @Joonas believes
>> that it may be useful - "it's used at least in specific diagnostics and
>> hardware repair flows for PVC and FLR for all platforms, where we
>> prevent further accesses to the hardware. So an alternative mechanism is
>> needed for those". Since xe_require_gpu() is a direct port of i915's
>> igt_require_gem() stripped of wedged device reporting, this could be a
>> good opportunity to discuss this.
> 
> I guess you could create a Xe engine, submit NOPs and check for XE_ENGINE_GET_PROPERTY_BAN to detect if GPU is wedged.
> 

@Jose - It seems that this may help here, thanks

On 21.04.2023 09:56, Zbigniew Kempczyński wrote:
 >> +int xe_reopen_driver(int fd)
 >> +{
 >> +	char path[256];
 >> +
 >> +	snprintf(path, sizeof(path), "/proc/self/fd/%d", fd);
 >> +	fd = open(path, O_RDWR);
 >> +	igt_assert_fd(fd);
 >> +
 >> +	return fd;
 >> +}
 >
 > On quick first look:
 >
 > Duplicates gem_reopen_driver() code, maybe just replace 'i915' to 'fd'
 > there?
 >
 > --
 > Zbigniew

@Zbyszek - I agree. gem_reopen_driver() is currently placed in lib/i915, 
would it be a good idea to move it (as "drm_reopen_driver()", with 
'i915' replaced with 'fd') to lib/drmtest.c?

Ania
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.