Re: [igt-dev] [RFC 0/2] lib/xe_gpu: Introduce xe_gpu library

["Souza, Jose" <jose.souza@intel.com>]

On Thu, 2023-04-20 at 21:14 +0200, Anna Karas wrote:
> OPENS:
> 1. Lack of wedged concept in XE: @Matthew informed me that there is no
> intent to have reporting wedged device in XE. However, @Joonas believes
> that it may be useful - "it's used at least in specific diagnostics and
> hardware repair flows for PVC and FLR for all platforms, where we
> prevent further accesses to the hardware. So an alternative mechanism is
> needed for those". Since xe_require_gpu() is a direct port of i915's 
> igt_require_gem() stripped of wedged device reporting, this could be a
> good opportunity to discuss this.

I guess you could create a Xe engine, submit NOPs and check for XE_ENGINE_GET_PROPERTY_BAN to detect if GPU is wedged.

> 
> 2. igt_require_gem() was also responsible for restoring reset and
> enable_hangcheck modparams. Do we need those parameters here? Do/will we
> need different ones do restore?
> 
> 3. Would you find adding equivalent of gem_quiescent_gpu here worth?
> 
> Reference: Jira VLK-46235
> Signed-off-by: Anna Karas <anna.karas@intel.com>
> 
> Anna Karas (2):
>   lib/xe_gpu: Introduce xe_gpu library
>   tests/xe: Use xe_require_gpu() in existing tests
> 
>  lib/meson.build                 |   1 +
>  lib/xe/xe_gpu.c                 | 136 ++++++++++++++++++++++++++++++++
>  lib/xe/xe_gpu.h                 |  19 +++++
>  tests/xe/xe_compute.c           |   2 +
>  tests/xe/xe_create.c            |   2 +
>  tests/xe/xe_debugfs.c           |   2 +
>  tests/xe/xe_dma_buf_sync.c      |   2 +
>  tests/xe/xe_evict.c             |   2 +
>  tests/xe/xe_exec_balancer.c     |   2 +
>  tests/xe/xe_exec_basic.c        |   2 +
>  tests/xe/xe_exec_compute_mode.c |   2 +
>  tests/xe/xe_exec_fault_mode.c   |   2 +
>  tests/xe/xe_exec_reset.c        |   2 +
>  tests/xe/xe_exec_threads.c      |   2 +
>  tests/xe/xe_guc_pc.c            |   2 +
>  tests/xe/xe_huc_copy.c          |   2 +
>  tests/xe/xe_mmap.c              |   2 +
>  tests/xe/xe_mmio.c              |   2 +
>  tests/xe/xe_noexec_ping_pong.c  |   2 +
>  tests/xe/xe_pm.c                |   2 +
>  tests/xe/xe_prime_self_import.c |   2 +
>  tests/xe/xe_query.c             |   2 +
>  tests/xe/xe_vm.c                |   2 +
>  tests/xe/xe_waitfence.c         |   2 +
>  24 files changed, 198 insertions(+)
>  create mode 100644 lib/xe/xe_gpu.c
>  create mode 100644 lib/xe/xe_gpu.h
>