* [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations
@ 2018-12-11 18:06 Lionel Landwerlin
2018-12-11 18:06 ` [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times Lionel Landwerlin
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Lionel Landwerlin @ 2018-12-11 18:06 UTC (permalink / raw)
To: igt-dev
Those 2 tests fail regularly on HSW, probably because the OA period
aligns slightly differently there because of the differnce in the
timestamp frequency between HSW and other generation. Just bump the
max number by 1 to fix the issue.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
---
tests/perf.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/tests/perf.c b/tests/perf.c
index 48b323e5..220c52ef 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -2025,7 +2025,7 @@ test_blocking(void)
int64_t tick_ns = 1000000000 / sysconf(_SC_CLK_TCK);
int64_t test_duration_ns = tick_ns * 1000;
- int max_iterations = (test_duration_ns / oa_period) + 1;
+ int max_iterations = (test_duration_ns / oa_period) + 2;
int n_extra_iterations = 0;
/* It's a bit tricky to put a lower limit here, but we expect a
@@ -2116,12 +2116,6 @@ test_blocking(void)
n++;
}
- /* Updated the maximum of iterations based on the time spent
- * in the loop.
- */
- max_iterations = (end - start) / oa_period + 1;
- igt_debug("adjusted max iter. = %d\n", max_iterations);
-
times(&end_times);
/* Using nanosecond units is fairly silly here, given the tick in-
@@ -2190,7 +2184,7 @@ test_polling(void)
int64_t tick_ns = 1000000000 / sysconf(_SC_CLK_TCK);
int64_t test_duration_ns = tick_ns * 1000;
- int max_iterations = (test_duration_ns / oa_period) + 1;
+ int max_iterations = (test_duration_ns / oa_period) + 2;
int n_extra_iterations = 0;
/* It's a bit tricky to put a lower limit here, but we expect a
@@ -2309,12 +2303,6 @@ test_polling(void)
n++;
}
- /* Updated the maximum of iterations based on the time spent
- * in the loop.
- */
- max_iterations = (end - start) / oa_period + 1;
- igt_debug("adjusted max iter. = %d\n", max_iterations);
-
times(&end_times);
/* Using nanosecond units is fairly silly here, given the tick in-
--
2.20.0.rc2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread* [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
@ 2018-12-11 18:06 ` Lionel Landwerlin
2018-12-14 11:58 ` Matthew Auld
2018-12-11 18:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Lionel Landwerlin @ 2018-12-11 18:06 UTC (permalink / raw)
To: igt-dev
Not quite sure how that fell through the cracks for so long...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
---
tests/perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/perf.c b/tests/perf.c
index 220c52ef..54e7f4f4 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -2230,6 +2230,7 @@ test_polling(void)
* the error delta.
*/
start = get_time();
+ times(&start_times);
do_ioctl(stream_fd, I915_PERF_IOCTL_ENABLE, 0);
for (/* nop */; ((end = get_time()) - start) < test_duration_ns; /* nop */) {
struct pollfd pollfd = { .fd = stream_fd, .events = POLLIN };
--
2.20.0.rc2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times
2018-12-11 18:06 ` [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times Lionel Landwerlin
@ 2018-12-14 11:58 ` Matthew Auld
2018-12-14 13:30 ` Lionel Landwerlin
0 siblings, 1 reply; 9+ messages in thread
From: Matthew Auld @ 2018-12-14 11:58 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
On Tue, 11 Dec 2018 at 18:06, Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
>
> Not quite sure how that fell through the cracks for so long...
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
It looks like we initialize it earlier :)
> ---
> tests/perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index 220c52ef..54e7f4f4 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -2230,6 +2230,7 @@ test_polling(void)
> * the error delta.
> */
> start = get_time();
> + times(&start_times);
> do_ioctl(stream_fd, I915_PERF_IOCTL_ENABLE, 0);
> for (/* nop */; ((end = get_time()) - start) < test_duration_ns; /* nop */) {
> struct pollfd pollfd = { .fd = stream_fd, .events = POLLIN };
> --
> 2.20.0.rc2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times
2018-12-14 11:58 ` Matthew Auld
@ 2018-12-14 13:30 ` Lionel Landwerlin
2018-12-14 13:58 ` Lionel Landwerlin
0 siblings, 1 reply; 9+ messages in thread
From: Lionel Landwerlin @ 2018-12-14 13:30 UTC (permalink / raw)
To: Matthew Auld; +Cc: igt-dev
On 14/12/2018 11:58, Matthew Auld wrote:
> On Tue, 11 Dec 2018 at 18:06, Lionel Landwerlin
> <lionel.g.landwerlin@intel.com> wrote:
>> Not quite sure how that fell through the cracks for so long...
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
> It looks like we initialize it earlier :)
I can't see where :|
Unless it's in the test_blocking() which is a different test.
>
>> ---
>> tests/perf.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/perf.c b/tests/perf.c
>> index 220c52ef..54e7f4f4 100644
>> --- a/tests/perf.c
>> +++ b/tests/perf.c
>> @@ -2230,6 +2230,7 @@ test_polling(void)
>> * the error delta.
>> */
>> start = get_time();
>> + times(&start_times);
>> do_ioctl(stream_fd, I915_PERF_IOCTL_ENABLE, 0);
>> for (/* nop */; ((end = get_time()) - start) < test_duration_ns; /* nop */) {
>> struct pollfd pollfd = { .fd = stream_fd, .events = POLLIN };
>> --
>> 2.20.0.rc2
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times
2018-12-14 13:30 ` Lionel Landwerlin
@ 2018-12-14 13:58 ` Lionel Landwerlin
0 siblings, 0 replies; 9+ messages in thread
From: Lionel Landwerlin @ 2018-12-14 13:58 UTC (permalink / raw)
To: Matthew Auld; +Cc: igt-dev
On 14/12/2018 13:30, Lionel Landwerlin wrote:
> On 14/12/2018 11:58, Matthew Auld wrote:
>> On Tue, 11 Dec 2018 at 18:06, Lionel Landwerlin
>> <lionel.g.landwerlin@intel.com> wrote:
>>> Not quite sure how that fell through the cracks for so long...
>>>
>>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
>> It looks like we initialize it earlier :)
>
>
> I can't see where :|
>
> Unless it's in the test_blocking() which is a different test.
Sorry, missed some other refactoring deleting that previous one.
Dropping this patch.
Thanks,
-
Lionel
>
>
>>
>>> ---
>>> tests/perf.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/perf.c b/tests/perf.c
>>> index 220c52ef..54e7f4f4 100644
>>> --- a/tests/perf.c
>>> +++ b/tests/perf.c
>>> @@ -2230,6 +2230,7 @@ test_polling(void)
>>> * the error delta.
>>> */
>>> start = get_time();
>>> + times(&start_times);
>>> do_ioctl(stream_fd, I915_PERF_IOCTL_ENABLE, 0);
>>> for (/* nop */; ((end = get_time()) - start) <
>>> test_duration_ns; /* nop */) {
>>> struct pollfd pollfd = { .fd = stream_fd, .events =
>>> POLLIN };
>>> --
>>> 2.20.0.rc2
>>>
>>> _______________________________________________
>>> igt-dev mailing list
>>> igt-dev@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
2018-12-11 18:06 ` [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times Lionel Landwerlin
@ 2018-12-11 18:27 ` Patchwork
2018-12-11 20:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-12-11 18:27 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations
URL : https://patchwork.freedesktop.org/series/53906/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5296 -> IGTPW_2144
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53906/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2144 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@gem_mmap_gtt@basic:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_chamelium@hdmi-hpd-fast:
- {fi-kbl-7500u}: PASS -> FAIL [fdo#108767]
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: PASS -> FAIL [fdo#104008]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (48 -> 44)
------------------------------
Additional (1): fi-byt-j1900
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-ctg-p8600
Build changes
-------------
* IGT: IGT_4745 -> IGTPW_2144
CI_DRM_5296: 70751bd8a3f27b035d203ecafcad452f4d7c2c15 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2144: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2144/
IGT_4745: 3b52e8a5809a4e860350c59476a456745cd9fee0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2144/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
2018-12-11 18:06 ` [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times Lionel Landwerlin
2018-12-11 18:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations Patchwork
@ 2018-12-11 20:49 ` Patchwork
2018-12-14 11:19 ` [igt-dev] [PATCH i-g-t 1/2] " Lionel Landwerlin
2018-12-14 11:48 ` Matthew Auld
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-12-11 20:49 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations
URL : https://patchwork.freedesktop.org/series/53906/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5296_full -> IGTPW_2144_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2144_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2144_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53906/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2144_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@extended-semaphore-blt:
- shard-hsw: PASS -> FAIL
#### Warnings ####
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2144_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-await-default:
- shard-hsw: PASS -> FAIL [fdo#108888]
* igt@gem_softpin@noreloc-s3:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-a-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: PASS -> FAIL [fdo#103232] +7
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +4
* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-glk: PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]
#### Possible fixes ####
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-c-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-glk: FAIL [fdo#103184] -> PASS
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: FAIL [fdo#103833] / [fdo#105681] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-kbl: FAIL [fdo#103167] / [fdo#105682] -> PASS
- shard-apl: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render:
- shard-glk: FAIL [fdo#103167] -> PASS +4
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@sprite-rotation-90:
- shard-glk: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-glk: FAIL [fdo#103166] -> PASS +2
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@perf@blocking:
- shard-hsw: FAIL [fdo#102252] -> PASS
* igt@prime_vgem@fence-wait-blt:
- shard-snb: DMESG-WARN [fdo#107469] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-snb: DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#105411] / [fdo#106886]
* {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
- shard-kbl: DMESG-FAIL [fdo#108950] -> DMESG-WARN [fdo#105604]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105681]: https://bugs.freedesktop.org/show_bug.cgi?id=105681
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108888]: https://bugs.freedesktop.org/show_bug.cgi?id=108888
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4745 -> IGTPW_2144
* Piglit: piglit_4509 -> None
CI_DRM_5296: 70751bd8a3f27b035d203ecafcad452f4d7c2c15 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2144: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2144/
IGT_4745: 3b52e8a5809a4e860350c59476a456745cd9fee0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2144/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
` (2 preceding siblings ...)
2018-12-11 20:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-12-14 11:19 ` Lionel Landwerlin
2018-12-14 11:48 ` Matthew Auld
4 siblings, 0 replies; 9+ messages in thread
From: Lionel Landwerlin @ 2018-12-14 11:19 UTC (permalink / raw)
To: igt-dev; +Cc: Auld, Matthew
Adding Matt in Cc ;)
On 11/12/2018 18:06, Lionel Landwerlin wrote:
> Those 2 tests fail regularly on HSW, probably because the OA period
> aligns slightly differently there because of the differnce in the
> timestamp frequency between HSW and other generation. Just bump the
> max number by 1 to fix the issue.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
> ---
> tests/perf.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index 48b323e5..220c52ef 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -2025,7 +2025,7 @@ test_blocking(void)
> int64_t tick_ns = 1000000000 / sysconf(_SC_CLK_TCK);
> int64_t test_duration_ns = tick_ns * 1000;
>
> - int max_iterations = (test_duration_ns / oa_period) + 1;
> + int max_iterations = (test_duration_ns / oa_period) + 2;
> int n_extra_iterations = 0;
>
> /* It's a bit tricky to put a lower limit here, but we expect a
> @@ -2116,12 +2116,6 @@ test_blocking(void)
> n++;
> }
>
> - /* Updated the maximum of iterations based on the time spent
> - * in the loop.
> - */
> - max_iterations = (end - start) / oa_period + 1;
> - igt_debug("adjusted max iter. = %d\n", max_iterations);
> -
> times(&end_times);
>
> /* Using nanosecond units is fairly silly here, given the tick in-
> @@ -2190,7 +2184,7 @@ test_polling(void)
> int64_t tick_ns = 1000000000 / sysconf(_SC_CLK_TCK);
> int64_t test_duration_ns = tick_ns * 1000;
>
> - int max_iterations = (test_duration_ns / oa_period) + 1;
> + int max_iterations = (test_duration_ns / oa_period) + 2;
> int n_extra_iterations = 0;
>
> /* It's a bit tricky to put a lower limit here, but we expect a
> @@ -2309,12 +2303,6 @@ test_polling(void)
> n++;
> }
>
> - /* Updated the maximum of iterations based on the time spent
> - * in the loop.
> - */
> - max_iterations = (end - start) / oa_period + 1;
> - igt_debug("adjusted max iter. = %d\n", max_iterations);
> -
> times(&end_times);
>
> /* Using nanosecond units is fairly silly here, given the tick in-
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
` (3 preceding siblings ...)
2018-12-14 11:19 ` [igt-dev] [PATCH i-g-t 1/2] " Lionel Landwerlin
@ 2018-12-14 11:48 ` Matthew Auld
4 siblings, 0 replies; 9+ messages in thread
From: Matthew Auld @ 2018-12-14 11:48 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: igt-dev
On Tue, 11 Dec 2018 at 18:06, Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
>
> Those 2 tests fail regularly on HSW, probably because the OA period
> aligns slightly differently there because of the differnce in the
> timestamp frequency between HSW and other generation. Just bump the
> max number by 1 to fix the issue.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-14 13:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-11 18:06 [igt-dev] [PATCH i-g-t 1/2] tests/perf: bump max number of block/poll interations Lionel Landwerlin
2018-12-11 18:06 ` [igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times Lionel Landwerlin
2018-12-14 11:58 ` Matthew Auld
2018-12-14 13:30 ` Lionel Landwerlin
2018-12-14 13:58 ` Lionel Landwerlin
2018-12-11 18:27 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/perf: bump max number of block/poll interations Patchwork
2018-12-11 20:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-14 11:19 ` [igt-dev] [PATCH i-g-t 1/2] " Lionel Landwerlin
2018-12-14 11:48 ` Matthew Auld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox