From: "Ser, Simon" <simon.ser@intel.com>
To: "emil.l.velikov@gmail.com" <emil.l.velikov@gmail.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [i-g-t] lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call
Date: Wed, 15 May 2019 12:21:07 +0000 [thread overview]
Message-ID: <5baa4bbce9b158442d6297b0616eb91102d5af20.camel@intel.com> (raw)
In-Reply-To: <20190425154334.31695-1-emil.l.velikov@gmail.com>
On Thu, 2019-04-25 at 16:43 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
>
> Currently we allocate a state and set the state cursor to 0. The
> latter
> is not needed since it's already zero.
>
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Simon Ser <simon.ser@intel.com>
> ---
> Please push this for me if patch looks good. I have commit access,
> yet
> am really short on time at the moment :-(
> ---
> lib/igt_kms.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index df9aafd2..de310042 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -3274,7 +3274,6 @@ static int igt_atomic_commit(igt_display_t
> *display, uint32_t flags, void *user_
> if (display->is_atomic != 1)
> return -1;
> req = drmModeAtomicAlloc();
> - drmModeAtomicSetCursor(req, 0);
>
> for_each_pipe(display, pipe) {
> igt_pipe_t *pipe_obj = &display->pipes[pipe];
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-05-15 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 15:43 [igt-dev] [PATCH i-g-t] lib/igt_kms: drop unneeded drmModeAtomicSetCursor() call Emil Velikov
2019-04-25 16:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-26 6:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-05-15 12:21 ` Ser, Simon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5baa4bbce9b158442d6297b0616eb91102d5af20.camel@intel.com \
--to=simon.ser@intel.com \
--cc=emil.l.velikov@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox