From: Alex Hung <alex.hung@amd.com>
To: Tom Chung <chiahsuan.chung@amd.com>, igt-dev@lists.freedesktop.org
Cc: sunpeng.li@amd.com
Subject: Re: [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM
Date: Wed, 26 Feb 2025 12:00:28 -0700 [thread overview]
Message-ID: <5c50fc99-805a-4bb6-9c83-611cf51b2b0b@amd.com> (raw)
In-Reply-To: <20250226100929.3363-1-chiahsuan.chung@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 2/26/25 03:09, Tom Chung wrote:
> [Why & How]
> Skip the ABM test if this panel does not support ABM.
>
> Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
> ---
> tests/amdgpu/amd_abm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index 8f7f489ad..13274aa4c 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -191,7 +191,7 @@ static void set_abm_level(data_t *data, igt_output_t *output, int level)
>
> fd = open(buf, O_WRONLY);
>
> - igt_assert(fd != -1);
> + igt_skip_on_f(fd == -1, "Cannot find %s. Is it an OLED?\n", buf);
>
> igt_assert_eq(snprintf(buf, sizeof(buf), "%d", level),
> write(fd, buf, 1));
next prev parent reply other threads:[~2025-02-26 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 10:09 [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM Tom Chung
2025-02-26 19:00 ` Alex Hung [this message]
2025-02-27 13:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c50fc99-805a-4bb6-9c83-611cf51b2b0b@amd.com \
--to=alex.hung@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox