* [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM
@ 2025-02-26 10:09 Tom Chung
2025-02-26 19:00 ` Alex Hung
2025-02-27 13:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Tom Chung @ 2025-02-26 10:09 UTC (permalink / raw)
To: igt-dev; +Cc: alex.hung, sunpeng.li, chiahsuan.chung
[Why & How]
Skip the ABM test if this panel does not support ABM.
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
---
tests/amdgpu/amd_abm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index 8f7f489ad..13274aa4c 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -191,7 +191,7 @@ static void set_abm_level(data_t *data, igt_output_t *output, int level)
fd = open(buf, O_WRONLY);
- igt_assert(fd != -1);
+ igt_skip_on_f(fd == -1, "Cannot find %s. Is it an OLED?\n", buf);
igt_assert_eq(snprintf(buf, sizeof(buf), "%d", level),
write(fd, buf, 1));
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM
2025-02-26 10:09 [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM Tom Chung
@ 2025-02-26 19:00 ` Alex Hung
2025-02-27 13:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Alex Hung @ 2025-02-26 19:00 UTC (permalink / raw)
To: Tom Chung, igt-dev; +Cc: sunpeng.li
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 2/26/25 03:09, Tom Chung wrote:
> [Why & How]
> Skip the ABM test if this panel does not support ABM.
>
> Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
> ---
> tests/amdgpu/amd_abm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
> index 8f7f489ad..13274aa4c 100644
> --- a/tests/amdgpu/amd_abm.c
> +++ b/tests/amdgpu/amd_abm.c
> @@ -191,7 +191,7 @@ static void set_abm_level(data_t *data, igt_output_t *output, int level)
>
> fd = open(buf, O_WRONLY);
>
> - igt_assert(fd != -1);
> + igt_skip_on_f(fd == -1, "Cannot find %s. Is it an OLED?\n", buf);
>
> igt_assert_eq(snprintf(buf, sizeof(buf), "%d", level),
> write(fd, buf, 1));
^ permalink raw reply [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for tests/amdgpu/amd_abm: Skip the test if panel does not support ABM
2025-02-26 10:09 [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM Tom Chung
2025-02-26 19:00 ` Alex Hung
@ 2025-02-27 13:46 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2025-02-27 13:46 UTC (permalink / raw)
To: Tom Chung; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
== Series Details ==
Series: tests/amdgpu/amd_abm: Skip the test if panel does not support ABM
URL : https://patchwork.freedesktop.org/series/145472/
State : failure
== Summary ==
Series 145472 revision 1 was fully merged or fully failed: no git log
[-- Attachment #2: Type: text/html, Size: 726 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-27 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 10:09 [PATCH i-g-t] tests/amdgpu/amd_abm: Skip the test if panel does not support ABM Tom Chung
2025-02-26 19:00 ` Alex Hung
2025-02-27 13:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox