From: Alex Hung <alex.hung@amd.com>
To: Hersen Wu <hersenxs.wu@amd.com>,
igt-dev@lists.freedesktop.org, rodrigo.siqueira@amd.com,
aurabindo.pillai@amd.com, hamza.mahfooz@amd.com
Subject: Re: [igt-dev] [PATCH] [i-g-t] lib/igt_amd: add delay waiting for hotplug complete
Date: Tue, 25 Apr 2023 16:59:32 -0600 [thread overview]
Message-ID: <5f1a7a38-f7b0-9d2c-fb3c-3f81550b3b98@amd.com> (raw)
In-Reply-To: <20230424130657.50263-1-hersenxs.wu@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 2023-04-24 07:06, Hersen Wu wrote:
> when run amd tests, amd_hotplug, amd_link_setings, in patch,
> amd_link_settings be skipped. debugfs_hpd_trigger requests
> kernel to generate hot plug event, but not wait for process
> finish.it takes time for kernel and user mode components to
> complete process for hot plug.
>
> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
> ---
> lib/igt_amd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/igt_amd.c b/lib/igt_amd.c
> index bef9c193..09923101 100644
> --- a/lib/igt_amd.c
> +++ b/lib/igt_amd.c
> @@ -799,6 +799,8 @@ int igt_amd_trigger_hotplug(int drm_fd, char *connector_name)
> wr_len = write(hpd_fd, enable_hpd, strlen(enable_hpd));
> close(hpd_fd);
> igt_assert_eq(wr_len, strlen(enable_hpd));
> + /* wait for hotplug process complete by kernel and user mode components */
> + sleep(30);
>
> return 0;
> }
prev parent reply other threads:[~2023-04-25 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:06 [igt-dev] [PATCH] [i-g-t] lib/igt_amd: add delay waiting for hotplug complete Hersen Wu
2023-04-24 14:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-04-24 17:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-25 22:59 ` Alex Hung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f1a7a38-f7b0-9d2c-fb3c-3f81550b3b98@amd.com \
--to=alex.hung@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=rodrigo.siqueira@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox