* [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe
@ 2023-05-24 11:38 Christoph Manszewski
2023-05-24 15:32 ` Grzegorzek, Dominik
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Christoph Manszewski @ 2023-05-24 11:38 UTC (permalink / raw)
To: igt-dev
Currently the 'ctx' field in batch buffer creation is interpreted as
a vm id for xe. In i915 it is interpreted as a context id. Since a xe
engine more closely resembles an i915 context, change the current
behaviour and interpret the 'ctx' fied as an xe engine id. This also
allows us to use the compute engine on xe, which currently is not
possible, due to reliance on legacy i915 flags.
v2:
- don't destroy user provided engine in 'intel_bb_destroy' (Zbigniew)
- destroy internally created engine before creating a new one
Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_batchbuffer.c | 27 +++++++++++++++++++--------
tests/xe/xe_intel_bb.c | 7 +++++--
2 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index dfccc4f4..d6a44d7e 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -946,15 +946,13 @@ __intel_bb_create(int fd, uint32_t ctx, const intel_ctx_cfg_t *cfg,
ibb->gtt_size = 1ull << min_t(uint32_t, xe_va_bits(fd), 48);
end = ibb->gtt_size;
- if (!ctx)
- ctx = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+ ibb->vm_id = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
ibb->uses_full_ppgtt = true;
ibb->allocator_handle =
- intel_allocator_open_full(fd, ctx, start, end,
+ intel_allocator_open_full(fd, ibb->vm_id, start, end,
allocator_type, strategy,
ibb->alignment);
- ibb->vm_id = ctx;
ibb->last_engine = ~0U;
}
@@ -1228,6 +1226,14 @@ static void __intel_bb_remove_intel_bufs(struct intel_bb *ibb)
intel_bb_remove_intel_buf(ibb, entry);
}
+static void __xe_bb_destroy(struct intel_bb *ibb)
+{
+ if (ibb->engine_id)
+ xe_engine_destroy(ibb->fd, ibb->engine_id);
+ if (ibb->vm_id)
+ xe_vm_destroy(ibb->fd, ibb->vm_id);
+}
+
/**
* intel_bb_destroy:
* @ibb: pointer to intel_bb
@@ -1262,8 +1268,8 @@ void intel_bb_destroy(struct intel_bb *ibb)
close(ibb->fence);
if (ibb->engine_syncobj)
syncobj_destroy(ibb->fd, ibb->engine_syncobj);
- if (ibb->vm_id && !ibb->ctx)
- xe_vm_destroy(ibb->fd, ibb->vm_id);
+ if (ibb->driver == INTEL_DRIVER_XE)
+ __xe_bb_destroy(ibb);
free(ibb->batch);
free(ibb->cfg);
@@ -2298,7 +2304,9 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
igt_assert_eq(ibb->num_relocs, 0);
igt_assert_eq(ibb->xe_bound, false);
- if (ibb->last_engine != engine) {
+ if (ibb->ctx) {
+ engine_id = ibb->ctx;
+ } else if (ibb->last_engine != engine) {
struct drm_xe_engine_class_instance inst = { };
inst.engine_instance =
@@ -2323,12 +2331,15 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
}
igt_debug("Run on %s\n", xe_engine_class_string(inst.engine_class));
+ if (ibb->engine_id)
+ xe_engine_destroy(ibb->fd, ibb->engine_id);
+
ibb->engine_id = engine_id =
xe_engine_create(ibb->fd, ibb->vm_id, &inst, 0);
+ ibb->last_engine = engine;
} else {
engine_id = ibb->engine_id;
}
- ibb->last_engine = engine;
map = xe_bo_map(ibb->fd, ibb->handle, ibb->size);
memcpy(map, ibb->batch, ibb->size);
diff --git a/tests/xe/xe_intel_bb.c b/tests/xe/xe_intel_bb.c
index 35d61608..4fcc3144 100644
--- a/tests/xe/xe_intel_bb.c
+++ b/tests/xe/xe_intel_bb.c
@@ -177,6 +177,7 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
int xe = buf_ops_get_fd(bops);
struct intel_bb *ibb;
uint32_t ctx = 0;
+ uint32_t vm = 0;
ibb = intel_bb_create_with_allocator(xe, ctx, NULL, PAGE_SIZE,
INTEL_ALLOCATOR_SIMPLE);
@@ -195,7 +196,8 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
intel_bb_reset(ibb, true);
if (new_context) {
- ctx = xe_vm_create(xe, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+ vm = xe_vm_create(xe, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+ ctx = xe_engine_create(xe, vm, xe_hw_engine(xe, 0), 0);
intel_bb_destroy(ibb);
ibb = intel_bb_create_with_context(xe, ctx, NULL, PAGE_SIZE);
intel_bb_out(ibb, MI_BATCH_BUFFER_END);
@@ -203,7 +205,8 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
intel_bb_exec(ibb, intel_bb_offset(ibb),
I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC,
true);
- xe_vm_destroy(xe, ctx);
+ xe_engine_destroy(xe, ctx);
+ xe_vm_destroy(xe, vm);
}
intel_bb_destroy(ibb);
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe
2023-05-24 11:38 [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe Christoph Manszewski
@ 2023-05-24 15:32 ` Grzegorzek, Dominik
2023-05-24 18:29 ` Manszewski, Christoph
2023-05-24 15:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/intel_bb: Enable custom engine support for xe (rev2) Patchwork
2023-05-25 3:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Grzegorzek, Dominik @ 2023-05-24 15:32 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org, Manszewski, Christoph
On Wed, 2023-05-24 at 13:38 +0200, Christoph Manszewski wrote:
> Currently the 'ctx' field in batch buffer creation is interpreted as
> a vm id for xe. In i915 it is interpreted as a context id. Since a xe
> engine more closely resembles an i915 context, change the current
> behaviour and interpret the 'ctx' fied as an xe engine id. This also
> allows us to use the compute engine on xe, which currently is not
> possible, due to reliance on legacy i915 flags.
>
> v2:
> - don't destroy user provided engine in 'intel_bb_destroy' (Zbigniew)
> - destroy internally created engine before creating a new one
>
> Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> lib/intel_batchbuffer.c | 27 +++++++++++++++++++--------
> tests/xe/xe_intel_bb.c | 7 +++++--
> 2 files changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index dfccc4f4..d6a44d7e 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -946,15 +946,13 @@ __intel_bb_create(int fd, uint32_t ctx, const intel_ctx_cfg_t *cfg,
> ibb->gtt_size = 1ull << min_t(uint32_t, xe_va_bits(fd), 48);
> end = ibb->gtt_size;
>
> - if (!ctx)
> - ctx = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
> + ibb->vm_id = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
As I see ibb->vm_id is used for vm_bind. So we pass xe_engine, which has it own vm under the hood,
and we use it in execbuf. At the same time we are binding objects to new, completly different vm.
Do I miss sth here?
In i915, an intel_bb could live without knowledge which vm hides behind the context,
as it was not using vm_bind. Here I think we would need to have both passed by the caller.
Regards,
Dominik
>
> ibb->uses_full_ppgtt = true;
> ibb->allocator_handle =
> - intel_allocator_open_full(fd, ctx, start, end,
> + intel_allocator_open_full(fd, ibb->vm_id, start, end,
> allocator_type, strategy,
> ibb->alignment);
> - ibb->vm_id = ctx;
> ibb->last_engine = ~0U;
> }
>
> @@ -1228,6 +1226,14 @@ static void __intel_bb_remove_intel_bufs(struct intel_bb *ibb)
> intel_bb_remove_intel_buf(ibb, entry);
> }
>
> +static void __xe_bb_destroy(struct intel_bb *ibb)
> +{
> + if (ibb->engine_id)
> + xe_engine_destroy(ibb->fd, ibb->engine_id);
> + if (ibb->vm_id)
> + xe_vm_destroy(ibb->fd, ibb->vm_id);
> +}
> +
> /**
> * intel_bb_destroy:
> * @ibb: pointer to intel_bb
> @@ -1262,8 +1268,8 @@ void intel_bb_destroy(struct intel_bb *ibb)
> close(ibb->fence);
> if (ibb->engine_syncobj)
> syncobj_destroy(ibb->fd, ibb->engine_syncobj);
> - if (ibb->vm_id && !ibb->ctx)
> - xe_vm_destroy(ibb->fd, ibb->vm_id);
> + if (ibb->driver == INTEL_DRIVER_XE)
> + __xe_bb_destroy(ibb);
>
> free(ibb->batch);
> free(ibb->cfg);
> @@ -2298,7 +2304,9 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
> igt_assert_eq(ibb->num_relocs, 0);
> igt_assert_eq(ibb->xe_bound, false);
>
> - if (ibb->last_engine != engine) {
> + if (ibb->ctx) {
> + engine_id = ibb->ctx;
> + } else if (ibb->last_engine != engine) {
> struct drm_xe_engine_class_instance inst = { };
>
> inst.engine_instance =
> @@ -2323,12 +2331,15 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
> }
> igt_debug("Run on %s\n", xe_engine_class_string(inst.engine_class));
>
> + if (ibb->engine_id)
> + xe_engine_destroy(ibb->fd, ibb->engine_id);
> +
> ibb->engine_id = engine_id =
> xe_engine_create(ibb->fd, ibb->vm_id, &inst, 0);
> + ibb->last_engine = engine;
> } else {
> engine_id = ibb->engine_id;
> }
> - ibb->last_engine = engine;
>
> map = xe_bo_map(ibb->fd, ibb->handle, ibb->size);
> memcpy(map, ibb->batch, ibb->size);
> diff --git a/tests/xe/xe_intel_bb.c b/tests/xe/xe_intel_bb.c
> index 35d61608..4fcc3144 100644
> --- a/tests/xe/xe_intel_bb.c
> +++ b/tests/xe/xe_intel_bb.c
> @@ -177,6 +177,7 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
> int xe = buf_ops_get_fd(bops);
> struct intel_bb *ibb;
> uint32_t ctx = 0;
> + uint32_t vm = 0;
>
> ibb = intel_bb_create_with_allocator(xe, ctx, NULL, PAGE_SIZE,
> INTEL_ALLOCATOR_SIMPLE);
> @@ -195,7 +196,8 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
> intel_bb_reset(ibb, true);
>
> if (new_context) {
> - ctx = xe_vm_create(xe, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
> + vm = xe_vm_create(xe, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
> + ctx = xe_engine_create(xe, vm, xe_hw_engine(xe, 0), 0);
> intel_bb_destroy(ibb);
> ibb = intel_bb_create_with_context(xe, ctx, NULL, PAGE_SIZE);
> intel_bb_out(ibb, MI_BATCH_BUFFER_END);
> @@ -203,7 +205,8 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
> intel_bb_exec(ibb, intel_bb_offset(ibb),
> I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC,
> true);
> - xe_vm_destroy(xe, ctx);
> + xe_engine_destroy(xe, ctx);
> + xe_vm_destroy(xe, vm);
> }
>
> intel_bb_destroy(ibb);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/intel_bb: Enable custom engine support for xe (rev2)
2023-05-24 11:38 [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe Christoph Manszewski
2023-05-24 15:32 ` Grzegorzek, Dominik
@ 2023-05-24 15:33 ` Patchwork
2023-05-25 3:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-05-24 15:33 UTC (permalink / raw)
To: Christoph Manszewski; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5633 bytes --]
== Series Details ==
Series: lib/intel_bb: Enable custom engine support for xe (rev2)
URL : https://patchwork.freedesktop.org/series/118227/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13185 -> IGTPW_9028
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/index.html
Participating hosts (39 -> 38)
------------------------------
Additional (1): fi-skl-guc
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_9028 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- fi-skl-guc: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/fi-skl-guc/igt@gem_lmem_swapping@basic.html
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][2] ([i915#7077])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_selftest@live@migrate:
- bat-atsm-1: [PASS][3] -> [DMESG-FAIL][4] ([i915#7699] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/bat-atsm-1/igt@i915_selftest@live@migrate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/bat-atsm-1/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][5] -> [ABORT][6] ([i915#7913] / [i915#7982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/bat-rpls-2/igt@i915_selftest@live@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/bat-rpls-1/igt@i915_selftest@live@reset.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-skl-guc: NOTRUN -> [SKIP][9] ([fdo#109271]) +10 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/fi-skl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: NOTRUN -> [SKIP][10] ([IGT#6] / [fdo#109271]) +6 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/fi-skl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-guc: NOTRUN -> [SKIP][11] ([IGT#6] / [fdo#109271] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/fi-skl-guc/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][12] ([i915#7059]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][14] ([i915#4579] / [i915#8260]) -> [SKIP][15] ([i915#3555] / [i915#4579])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7302 -> IGTPW_9028
CI-20190529: 20190529
CI_DRM_13185: e9b0234536d53adca81a81bc1f58611a0f5209d1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9028: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/index.html
IGT_7302: de4b71f2c13f6fdcae15a4c3fac7fbe5f5737685 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/index.html
[-- Attachment #2: Type: text/html, Size: 6723 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe
2023-05-24 15:32 ` Grzegorzek, Dominik
@ 2023-05-24 18:29 ` Manszewski, Christoph
0 siblings, 0 replies; 5+ messages in thread
From: Manszewski, Christoph @ 2023-05-24 18:29 UTC (permalink / raw)
To: Grzegorzek, Dominik, igt-dev@lists.freedesktop.org
Hi Dominik,
On 24.05.2023 17:32, Grzegorzek, Dominik wrote:
> On Wed, 2023-05-24 at 13:38 +0200, Christoph Manszewski wrote:
>> Currently the 'ctx' field in batch buffer creation is interpreted as
>> a vm id for xe. In i915 it is interpreted as a context id. Since a xe
>> engine more closely resembles an i915 context, change the current
>> behaviour and interpret the 'ctx' fied as an xe engine id. This also
>> allows us to use the compute engine on xe, which currently is not
>> possible, due to reliance on legacy i915 flags.
>>
>> v2:
>> - don't destroy user provided engine in 'intel_bb_destroy' (Zbigniew)
>> - destroy internally created engine before creating a new one
>>
>> Signed-off-by: Christoph Manszewski <christoph.manszewski@intel.com>
>> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>> ---
>> lib/intel_batchbuffer.c | 27 +++++++++++++++++++--------
>> tests/xe/xe_intel_bb.c | 7 +++++--
>> 2 files changed, 24 insertions(+), 10 deletions(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index dfccc4f4..d6a44d7e 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -946,15 +946,13 @@ __intel_bb_create(int fd, uint32_t ctx, const intel_ctx_cfg_t *cfg,
>> ibb->gtt_size = 1ull << min_t(uint32_t, xe_va_bits(fd), 48);
>> end = ibb->gtt_size;
>>
>> - if (!ctx)
>> - ctx = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
>> + ibb->vm_id = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
>
> As I see ibb->vm_id is used for vm_bind. So we pass xe_engine, which has it own vm under the hood,
> and we use it in execbuf. At the same time we are binding objects to new, completly different vm.
> Do I miss sth here?
Nope, looks like I did :$
>
> In i915, an intel_bb could live without knowledge which vm hides behind the context,
> as it was not using vm_bind. Here I think we would need to have both passed by the caller.
You're right, unless there is a way to get the vm id for a specific xe
engine, we need to pass it too, maybe through the means of the "cfg"
parameter.
Thanks,
Christoph
>
> Regards,
> Dominik
>
>
>
>>
>> ibb->uses_full_ppgtt = true;
>> ibb->allocator_handle =
>> - intel_allocator_open_full(fd, ctx, start, end,
>> + intel_allocator_open_full(fd, ibb->vm_id, start, end,
>> allocator_type, strategy,
>> ibb->alignment);
>> - ibb->vm_id = ctx;
>> ibb->last_engine = ~0U;
>> }
>>
>> @@ -1228,6 +1226,14 @@ static void __intel_bb_remove_intel_bufs(struct intel_bb *ibb)
>> intel_bb_remove_intel_buf(ibb, entry);
>> }
>>
>> +static void __xe_bb_destroy(struct intel_bb *ibb)
>> +{
>> + if (ibb->engine_id)
>> + xe_engine_destroy(ibb->fd, ibb->engine_id);
>> + if (ibb->vm_id)
>> + xe_vm_destroy(ibb->fd, ibb->vm_id);
>> +}
>> +
>> /**
>> * intel_bb_destroy:
>> * @ibb: pointer to intel_bb
>> @@ -1262,8 +1268,8 @@ void intel_bb_destroy(struct intel_bb *ibb)
>> close(ibb->fence);
>> if (ibb->engine_syncobj)
>> syncobj_destroy(ibb->fd, ibb->engine_syncobj);
>> - if (ibb->vm_id && !ibb->ctx)
>> - xe_vm_destroy(ibb->fd, ibb->vm_id);
>> + if (ibb->driver == INTEL_DRIVER_XE)
>> + __xe_bb_destroy(ibb);
>>
>> free(ibb->batch);
>> free(ibb->cfg);
>> @@ -2298,7 +2304,9 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
>> igt_assert_eq(ibb->num_relocs, 0);
>> igt_assert_eq(ibb->xe_bound, false);
>>
>> - if (ibb->last_engine != engine) {
>> + if (ibb->ctx) {
>> + engine_id = ibb->ctx;
>> + } else if (ibb->last_engine != engine) {
>> struct drm_xe_engine_class_instance inst = { };
>>
>> inst.engine_instance =
>> @@ -2323,12 +2331,15 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
>> }
>> igt_debug("Run on %s\n", xe_engine_class_string(inst.engine_class));
>>
>> + if (ibb->engine_id)
>> + xe_engine_destroy(ibb->fd, ibb->engine_id);
>> +
>> ibb->engine_id = engine_id =
>> xe_engine_create(ibb->fd, ibb->vm_id, &inst, 0);
>> + ibb->last_engine = engine;
>> } else {
>> engine_id = ibb->engine_id;
>> }
>> - ibb->last_engine = engine;
>>
>> map = xe_bo_map(ibb->fd, ibb->handle, ibb->size);
>> memcpy(map, ibb->batch, ibb->size);
>> diff --git a/tests/xe/xe_intel_bb.c b/tests/xe/xe_intel_bb.c
>> index 35d61608..4fcc3144 100644
>> --- a/tests/xe/xe_intel_bb.c
>> +++ b/tests/xe/xe_intel_bb.c
>> @@ -177,6 +177,7 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
>> int xe = buf_ops_get_fd(bops);
>> struct intel_bb *ibb;
>> uint32_t ctx = 0;
>> + uint32_t vm = 0;
>>
>> ibb = intel_bb_create_with_allocator(xe, ctx, NULL, PAGE_SIZE,
>> INTEL_ALLOCATOR_SIMPLE);
>> @@ -195,7 +196,8 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
>> intel_bb_reset(ibb, true);
>>
>> if (new_context) {
>> - ctx = xe_vm_create(xe, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
>> + vm = xe_vm_create(xe, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
>> + ctx = xe_engine_create(xe, vm, xe_hw_engine(xe, 0), 0);
>> intel_bb_destroy(ibb);
>> ibb = intel_bb_create_with_context(xe, ctx, NULL, PAGE_SIZE);
>> intel_bb_out(ibb, MI_BATCH_BUFFER_END);
>> @@ -203,7 +205,8 @@ static void simple_bb(struct buf_ops *bops, bool new_context)
>> intel_bb_exec(ibb, intel_bb_offset(ibb),
>> I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC,
>> true);
>> - xe_vm_destroy(xe, ctx);
>> + xe_engine_destroy(xe, ctx);
>> + xe_vm_destroy(xe, vm);
>> }
>>
>> intel_bb_destroy(ibb);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/intel_bb: Enable custom engine support for xe (rev2)
2023-05-24 11:38 [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe Christoph Manszewski
2023-05-24 15:32 ` Grzegorzek, Dominik
2023-05-24 15:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/intel_bb: Enable custom engine support for xe (rev2) Patchwork
@ 2023-05-25 3:15 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-05-25 3:15 UTC (permalink / raw)
To: Manszewski, Christoph; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 14733 bytes --]
== Series Details ==
Series: lib/intel_bb: Enable custom engine support for xe (rev2)
URL : https://patchwork.freedesktop.org/series/118227/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13185_full -> IGTPW_9028_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_9028_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl1/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#79])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-apl: NOTRUN -> [SKIP][8] ([IGT#6] / [fdo#109271]) +6 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl4/igt@kms_flip@2x-nonexisting-fb-interruptible.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4579]) +10 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-snb2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271]) +16 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1.html
* igt@kms_scaling_modes@scaling-mode-center:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl4/igt@kms_scaling_modes@scaling-mode-center.html
* igt@perf@stress-open-close@0-rcs0:
- shard-glk: [PASS][12] -> [ABORT][13] ([i915#5213] / [i915#7941])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-glk6/igt@perf@stress-open-close@0-rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-glk2/igt@perf@stress-open-close@0-rcs0.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][14] ([i915#6268]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-snb: [FAIL][18] ([i915#4998] / [i915#8295]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctxn.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-snb2/igt@gem_ppgtt@blt-vs-render-ctxn.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [ABORT][20] ([i915#5566]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-apl6/igt@gen9_exec_parse@allowed-all.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl1/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-dg1}: [FAIL][22] ([i915#3591]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][24] ([i915#1397]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][26] ([IGT#6] / [i915#2346]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-apl: [FAIL][28] ([IGT#6] / [i915#2346]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][30] ([IGT#6] / [i915#4767]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][32] ([i915#79]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@plain-flip-ts-check@b-hdmi-a1:
- shard-glk: [FAIL][34] ([i915#2122]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-glk5/igt@kms_flip@plain-flip-ts-check@b-hdmi-a1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-glk3/igt@kms_flip@plain-flip-ts-check@b-hdmi-a1.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- {shard-tglu}: [ABORT][36] ([i915#5122] / [i915#8213]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-tglu-7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-tglu-5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf_pmu@all-busy-idle-check-all:
- {shard-dg1}: [FAIL][38] ([i915#5234]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13185/shard-dg1-18/igt@perf_pmu@all-busy-idle-check-all.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/shard-dg1-14/igt@perf_pmu@all-busy-idle-check-all.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4998]: https://gitlab.freedesktop.org/drm/intel/issues/4998
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7302 -> IGTPW_9028
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13185: e9b0234536d53adca81a81bc1f58611a0f5209d1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9028: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/index.html
IGT_7302: de4b71f2c13f6fdcae15a4c3fac7fbe5f5737685 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9028/index.html
[-- Attachment #2: Type: text/html, Size: 12219 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-25 3:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-24 11:38 [igt-dev] [PATCH i-g-t v2] lib/intel_bb: Enable custom engine support for xe Christoph Manszewski
2023-05-24 15:32 ` Grzegorzek, Dominik
2023-05-24 18:29 ` Manszewski, Christoph
2023-05-24 15:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/intel_bb: Enable custom engine support for xe (rev2) Patchwork
2023-05-25 3:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox