Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] tests/kms_plane_multiple: Start continuous CRC capture after commit
@ 2020-09-18 18:30 Victor Lu
  2020-09-18 19:24 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Victor Lu @ 2020-09-18 18:30 UTC (permalink / raw)
  To: igt-dev; +Cc: Victor Lu

atomic-pipe-a-tiling-none fails on some AMD devices because it fails
due to a timeout when reading the CRC when there is no CRC generated.

Move igt_pipe_crc_start to be after the first nonzero FB commit in
kms_plane_multiple.

Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 tests/kms_plane_multiple.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 8310981c..d0d41cec 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -290,6 +290,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 	igt_plane_t *plane;
 	int i;
 	int err, c = 0;
+	int crc_enabled = 0;
 	int iterations = opt.iterations < 1 ? 1 : opt.iterations;
 	bool loop_forever;
 	char info[256];
@@ -329,14 +330,16 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		 igt_output_name(output), kmstest_pipe_name(pipe), c,
 		 info, opt.seed);
 
-	igt_pipe_crc_start(data->pipe_crc);
-
 	i = 0;
 	while (i < iterations || loop_forever) {
 		/* randomize planes and set up the holes */
 		prepare_planes(data, pipe, &blue, tiling, c, output);
 
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+		if (!crc_enabled) {
+			igt_pipe_crc_start(data->pipe_crc);
+			crc_enabled = 1;
+		}
 
 		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &crc);
 
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-21  8:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 18:30 [igt-dev] [PATCH] tests/kms_plane_multiple: Start continuous CRC capture after commit Victor Lu
2020-09-18 19:24 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-09-21  7:45   ` Petri Latvala
2020-09-21  7:49     ` Vudum, Lakshminarayana
2020-09-21  7:48 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-09-21  8:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox