Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v3 0/2] check drmModeGetConnector() return value in some missing places
@ 2024-05-30  8:59 Luca Coelho
  2024-05-30  8:59 ` [PATCH i-g-t v3 1/2] lib/igt_chamelium: check drmModeGetConnector() before using Luca Coelho
                   ` (6 more replies)
  0 siblings, 7 replies; 17+ messages in thread
From: Luca Coelho @ 2024-05-30  8:59 UTC (permalink / raw)
  To: igt-dev; +Cc: kamil.konieczny

Hi,

There are some places where the return value of calls to the
drmModeGetConnector() function are not checked, even though it can
return NULL in some cases.

Fix that in lib/igt_chamelium and intel/i915_pm_rpm.

In v2:
   * change igt_warn() to igt_debug() [Kamil]
   * set connected to false when we can't get the connector [Kamil]
   * added Chromium stakeholders in Cc. [Kamil]
   * shortened the commit message a bit. [Kamil]

In v3:
   * changed the commit summaries [Kamil]
   * added more people to CC [Kamil]
   * changed igt_debug() back to igt_warn() [Kamil]
   * added a small excerpt from the bug report [Kamil]

Please review.

Cheers,
Luca.


Luca Coelho (2):
  lib/igt_chamelium: check drmModeGetConnector() before using
  tests/intel/i915_pm_rpm: check drmModeGetConnector() before use

 lib/igt_chamelium.c       | 5 +++++
 tests/intel/i915_pm_rpm.c | 6 ++++++
 2 files changed, 11 insertions(+)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2024-06-13 13:37 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30  8:59 [PATCH i-g-t v3 0/2] check drmModeGetConnector() return value in some missing places Luca Coelho
2024-05-30  8:59 ` [PATCH i-g-t v3 1/2] lib/igt_chamelium: check drmModeGetConnector() before using Luca Coelho
2024-06-07 14:41   ` Kamil Konieczny
2024-06-12 13:58     ` Coelho, Luciano
2024-05-30  8:59 ` [PATCH i-g-t v3 2/2] tests/intel/i915_pm_rpm: check drmModeGetConnector() before use Luca Coelho
2024-06-07 15:11   ` Kamil Konieczny
2024-06-12 14:10     ` Coelho, Luciano
2024-06-13 13:32       ` Kamil Konieczny
2024-06-13 13:37         ` Coelho, Luciano
2024-05-30  9:59 ` ✓ CI.xeBAT: success for check drmModeGetConnector() return value in some missing places (rev4) Patchwork
2024-05-30 10:04 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-05-30 12:26   ` Luca Coelho
2024-05-31 16:53     ` Illipilli, TejasreeX
2024-05-30 10:57 ` ✗ CI.xeFULL: " Patchwork
2024-05-30 20:49   ` Luca Coelho
2024-05-31 16:50 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-02  1:30 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox