* [igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: Check for bonding support before exercising
@ 2020-03-31 10:36 Chris Wilson
2020-03-31 11:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-04-01 14:12 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2020-03-31 10:36 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin, Chris Wilson
Don't bother trying and failing to test bonding if the kernel doesn't
even support it.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
tests/i915/gem_exec_balancer.c | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
index da8aff6de..9930e394d 100644
--- a/tests/i915/gem_exec_balancer.c
+++ b/tests/i915/gem_exec_balancer.c
@@ -1936,6 +1936,22 @@ static bool has_load_balancer(int i915)
return err == 0;
}
+static bool has_bonding(int i915)
+{
+ I915_DEFINE_CONTEXT_ENGINES_BOND(bonds, 0) = {
+ .base.name = I915_CONTEXT_ENGINES_EXT_BOND,
+ };
+ struct i915_engine_class_instance ci = {};
+ uint32_t ctx;
+ int err;
+
+ ctx = gem_context_create(i915);
+ err = __set_load_balancer(i915, ctx, &ci, 1, &bonds);
+ gem_context_destroy(i915, ctx);
+
+ return err == 0;
+}
+
igt_main
{
int i915 = -1;
@@ -1992,11 +2008,18 @@ igt_main
igt_subtest("smoke")
smoketest(i915, 20);
- igt_subtest("bonded-imm")
- bonded(i915, 0);
+ igt_subtest_group {
+ igt_fixture igt_require(has_bonding(i915));
+
+ igt_subtest("bonded-imm")
+ bonded(i915, 0);
+
+ igt_subtest("bonded-cork")
+ bonded(i915, CORK);
- igt_subtest("bonded-cork")
- bonded(i915, CORK);
+ igt_subtest("bonded-early")
+ bonded_early(i915);
+ }
igt_subtest("bonded-slice")
bonded_slice(i915);
@@ -2007,9 +2030,6 @@ igt_main
igt_subtest("bonded-semaphore")
bonded_semaphore(i915);
- igt_subtest("bonded-early")
- bonded_early(i915);
-
igt_fixture {
igt_stop_hang_detector();
}
--
2.26.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* [igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_exec_balancer: Check for bonding support before exercising
2020-03-31 10:36 [igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: Check for bonding support before exercising Chris Wilson
@ 2020-03-31 11:55 ` Patchwork
2020-04-01 14:12 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-03-31 11:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_exec_balancer: Check for bonding support before exercising
URL : https://patchwork.freedesktop.org/series/75302/
State : failure
== Summary ==
CI Bug Log - changes from IGT_5548 -> IGTPW_4378
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4378 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4378, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4378:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- fi-icl-dsi: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5548/fi-icl-dsi/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/fi-icl-dsi/igt@i915_selftest@live@hangcheck.html
Known issues
------------
Here are the changes found in IGTPW_4378 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-skl-6770hq: [DMESG-WARN][3] ([i915#203]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5548/fi-skl-6770hq/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/fi-skl-6770hq/igt@i915_module_load@reload.html
* igt@i915_selftest@live@execlists:
- fi-kbl-7500u: [INCOMPLETE][5] ([CI#80] / [i915#656]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5548/fi-kbl-7500u/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/fi-kbl-7500u/igt@i915_selftest@live@execlists.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-skl-6770hq: [SKIP][7] ([fdo#109271]) -> [PASS][8] +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5548/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-skl-6770hq: [DMESG-WARN][9] ([i915#106] / [i915#165]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5548/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/fi-skl-6770hq/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#106]: https://gitlab.freedesktop.org/drm/intel/issues/106
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (47 -> 43)
------------------------------
Additional (1): fi-bsw-n3050
Missing (5): fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5548 -> IGTPW_4378
CI-20190529: 20190529
CI_DRM_8222: 6970d295e51e3b03d7ee3f781522398402d3a35d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4378: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/index.html
IGT_5548: d9e70dc1b35633b7d5c81cbfa165e331189eb260 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4378/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_exec_balancer: Check for bonding support before exercising
2020-03-31 10:36 [igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: Check for bonding support before exercising Chris Wilson
2020-03-31 11:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2020-04-01 14:12 ` Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Tvrtko Ursulin @ 2020-04-01 14:12 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 31/03/2020 11:36, Chris Wilson wrote:
> Don't bother trying and failing to test bonding if the kernel doesn't
> even support it.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
> tests/i915/gem_exec_balancer.c | 34 +++++++++++++++++++++++++++-------
> 1 file changed, 27 insertions(+), 7 deletions(-)
>
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index da8aff6de..9930e394d 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -1936,6 +1936,22 @@ static bool has_load_balancer(int i915)
> return err == 0;
> }
>
> +static bool has_bonding(int i915)
> +{
> + I915_DEFINE_CONTEXT_ENGINES_BOND(bonds, 0) = {
> + .base.name = I915_CONTEXT_ENGINES_EXT_BOND,
> + };
Doh why do we allow zero bonds.. to make for an easier probe of course! :))
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
> + struct i915_engine_class_instance ci = {};
> + uint32_t ctx;
> + int err;
> +
> + ctx = gem_context_create(i915);
> + err = __set_load_balancer(i915, ctx, &ci, 1, &bonds);
> + gem_context_destroy(i915, ctx);
> +
> + return err == 0;
> +}
> +
> igt_main
> {
> int i915 = -1;
> @@ -1992,11 +2008,18 @@ igt_main
> igt_subtest("smoke")
> smoketest(i915, 20);
>
> - igt_subtest("bonded-imm")
> - bonded(i915, 0);
> + igt_subtest_group {
> + igt_fixture igt_require(has_bonding(i915));
> +
> + igt_subtest("bonded-imm")
> + bonded(i915, 0);
> +
> + igt_subtest("bonded-cork")
> + bonded(i915, CORK);
>
> - igt_subtest("bonded-cork")
> - bonded(i915, CORK);
> + igt_subtest("bonded-early")
> + bonded_early(i915);
> + }
>
> igt_subtest("bonded-slice")
> bonded_slice(i915);
> @@ -2007,9 +2030,6 @@ igt_main
> igt_subtest("bonded-semaphore")
> bonded_semaphore(i915);
>
> - igt_subtest("bonded-early")
> - bonded_early(i915);
> -
> igt_fixture {
> igt_stop_hang_detector();
> }
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-01 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-31 10:36 [igt-dev] [PATCH i-g-t] i915/gem_exec_balancer: Check for bonding support before exercising Chris Wilson
2020-03-31 11:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-04-01 14:12 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox