From: Karthik B S <karthik.b.s@intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: <kamil.konieczny@linux.intel.com>,
<ville.syrjala@linux.intel.com>, <jani.nikula@linux.intel.com>
Subject: Re: [PATCH i-g-t 2/8] tools/intel_vbt_decode.c: Include linux_scaffold.h
Date: Mon, 27 Apr 2026 10:39:27 +0530 [thread overview]
Message-ID: <695ee632-f5a1-4b2d-abe1-ee3f35d2ee48@intel.com> (raw)
In-Reply-To: <20260422034335.2326098-3-ankit.k.nautiyal@intel.com>
On 4/22/2026 9:13 AM, Ankit Nautiyal wrote:
> linux_scaffold.h provides kernel compat macros including GENMASK and
> BIT_U32, which will be needed by intel_vbt_defs.h in subsequent changes.
> Include it in intel_vbt_decode.c and remove the now duplicate typedefs
> for u8, u16, u32, and u64.
>
> While at it, move drmtest.h in asciibetical order.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tools/intel_vbt_decode.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index d4aada743e42..7785e9e82b1f 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -38,17 +38,13 @@
> #include <sys/stat.h>
> #include <sys/types.h>
>
> +#include "drmtest.h"
> #include "igt_aux.h"
> #include "igt_halffloat.h"
> #include "intel_chipset.h"
> #include "intel_io.h"
> -#include "drmtest.h"
> +#include "linux_scaffold.h"
>
> -/* kernel types for intel_vbt_defs.h */
> -typedef uint8_t u8;
> -typedef uint16_t u16;
> -typedef uint32_t u32;
> -typedef uint64_t u64;
> #define __packed __attribute__ ((packed))
>
> #define _INTEL_BIOS_PRIVATE
next prev parent reply other threads:[~2026-04-27 5:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 3:43 [PATCH i-g-t 0/8] intel_vbt_decode: Sync intel_vbt_defs.h with latest changes Ankit Nautiyal
2026-04-22 3:43 ` [PATCH i-g-t 1/8] include/linux_scaffold: Add BIT_U{8,16,32} macros Ankit Nautiyal
2026-04-27 5:07 ` Karthik B S
2026-04-27 12:31 ` Nautiyal, Ankit K
2026-04-22 3:43 ` [PATCH i-g-t 2/8] tools/intel_vbt_decode.c: Include linux_scaffold.h Ankit Nautiyal
2026-04-27 5:09 ` Karthik B S [this message]
2026-04-22 3:43 ` [PATCH i-g-t 3/8] tools/intel_vbt_defs: sync intel_vbt_defs.h with kernel commit 4d33c77cf2c3 Ankit Nautiyal
2026-04-27 5:12 ` Karthik B S
2026-04-22 3:43 ` [PATCH i-g-t 4/8] tools/intel_vbt_defs: sync intel_vbt_defs.h with kernel commit 203c7904f2d8 Ankit Nautiyal
2026-04-27 5:14 ` Karthik B S
2026-04-22 3:43 ` [PATCH i-g-t 5/8] tools/intel_vbt_defs: sync intel_vbt_defs.h with kernel commit 1b85a9b04681 Ankit Nautiyal
2026-04-27 5:14 ` Karthik B S
2026-04-22 3:43 ` [PATCH i-g-t 6/8] tools/intel_vbt_decode: dump eDP data rate override field Ankit Nautiyal
2026-04-27 5:17 ` Karthik B S
2026-04-27 12:38 ` Nautiyal, Ankit K
2026-04-22 3:43 ` [PATCH i-g-t 7/8] tools/intel_vbt_decode: dump eDP joiner enable field Ankit Nautiyal
2026-04-22 3:43 ` [PATCH i-g-t 8/8] tools/intel_vbt_decode: Dump dedicated_external and dyn_port_over_tc fields Ankit Nautiyal
2026-04-27 5:17 ` Karthik B S
2026-04-22 5:45 ` ✓ Xe.CI.BAT: success for intel_vbt_decode: Sync intel_vbt_defs.h with latest changes (rev5) Patchwork
2026-04-22 5:51 ` ✗ i915.CI.BAT: failure " Patchwork
2026-04-22 9:20 ` ✓ Xe.CI.FULL: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 12:45 [PATCH i-g-t 0/8] intel_vbt_decode: Sync intel_vbt_defs.h with latest changes Ankit Nautiyal
2026-04-27 12:46 ` [PATCH i-g-t 2/8] tools/intel_vbt_decode.c: Include linux_scaffold.h Ankit Nautiyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=695ee632-f5a1-4b2d-abe1-ee3f35d2ee48@intel.com \
--to=karthik.b.s@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox