From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>,
IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v19 3/6] lib: igt_gt: add eb flags to class helper
Date: Mon, 8 Apr 2019 17:24:41 +0100 [thread overview]
Message-ID: <6a1a1618-541b-2bd6-5a80-3ce6e71edfb9@linux.intel.com> (raw)
In-Reply-To: <20190408161533.2421-4-andi.shyti@intel.com>
On 08/04/2019 17:15, Andi Shyti wrote:
> we have a "class/instance to eb flags" helper but not the
> opposite, add it.
>
> Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> ---
> lib/igt_gt.c | 18 ++++++++++++++++++
> lib/igt_gt.h | 2 ++
> 2 files changed, 20 insertions(+)
>
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 5999524326d0..8cd58f7afbfd 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -41,6 +41,7 @@
> #include "intel_reg.h"
> #include "intel_chipset.h"
> #include "igt_dummyload.h"
> +#include "i915/gem_engine_topology.h"
>
> /**
> * SECTION:igt_gt
> @@ -586,6 +587,23 @@ const struct intel_execution_engine2 intel_execution_engines2[] = {
> { }
> };
>
> +int gem_eb_to_class(unsigned int flags)
> +{
> + switch (flags & 0x3f) {
> + case I915_EXEC_DEFAULT:
> + case I915_EXEC_RENDER:
> + return I915_ENGINE_CLASS_RENDER;
> + case I915_EXEC_BLT:
> + return I915_ENGINE_CLASS_COPY;
> + case I915_EXEC_BSD:
> + return I915_ENGINE_CLASS_VIDEO;
> + case I915_EXEC_VEBOX:
> + return I915_ENGINE_CLASS_VIDEO_ENHANCE;
> + default:
> + igt_assert(0);
> + }
> +}
> +
> unsigned int
> gem_class_instance_to_eb_flags(int gem_fd,
> enum drm_i915_gem_engine_class class,
> diff --git a/lib/igt_gt.h b/lib/igt_gt.h
> index 52b2f1ea95a5..b13062ef7d33 100644
> --- a/lib/igt_gt.h
> +++ b/lib/igt_gt.h
> @@ -99,6 +99,8 @@ extern const struct intel_execution_engine2 {
> bool is_virtual;
> } intel_execution_engines2[];
>
> +int gem_eb_to_class(unsigned int flags);
> +
> unsigned int
> gem_class_instance_to_eb_flags(int gem_fd,
> enum drm_i915_gem_engine_class class,
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-08 16:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 16:15 [igt-dev] [PATCH v19 0/6] new engine discovery interface Andi Shyti
2019-04-08 16:15 ` [igt-dev] [PATCH v19 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-08 16:37 ` Tvrtko Ursulin
2019-04-08 16:47 ` Andi Shyti
2019-04-08 16:56 ` Tvrtko Ursulin
2019-04-08 18:33 ` Antonio Argenziano
2019-04-09 7:33 ` Tvrtko Ursulin
2019-04-08 16:15 ` [igt-dev] [PATCH v19 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-08 16:54 ` Tvrtko Ursulin
2019-04-08 18:21 ` Andi Shyti
2019-04-11 16:03 ` Tvrtko Ursulin
2019-04-11 23:23 ` Andi Shyti
2019-04-08 16:15 ` [igt-dev] [PATCH v19 3/6] lib: igt_gt: add eb flags to class helper Andi Shyti
2019-04-08 16:24 ` Tvrtko Ursulin [this message]
2019-04-08 16:15 ` [igt-dev] [PATCH v19 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-04-08 16:25 ` Tvrtko Ursulin
2019-04-08 16:15 ` [igt-dev] [PATCH v19 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-04-08 16:28 ` Tvrtko Ursulin
2019-04-08 16:45 ` Andi Shyti
2019-04-11 12:26 ` [igt-dev] [RFT i-g-t 6/6] test: perf_pmu: use the gem_engine_topology library Tvrtko Ursulin
2019-04-11 12:32 ` [Intel-gfx] " Chris Wilson
2019-04-11 12:53 ` Tvrtko Ursulin
2019-04-11 13:50 ` Chris Wilson
2019-04-11 14:37 ` Tvrtko Ursulin
2019-04-11 13:01 ` [igt-dev] [Intel-gfx] " Andi Shyti
2019-04-11 13:40 ` Chris Wilson
2019-04-11 14:55 ` Andi Shyti
2019-04-11 12:28 ` [igt-dev] [RFT i-g-t 5/6] lib: igt_dummyload: use for_each_context_engine() Tvrtko Ursulin
2019-04-08 16:15 ` [igt-dev] [PATCH v19 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-08 16:35 ` Tvrtko Ursulin
2019-04-08 16:56 ` Andi Shyti
2019-04-08 17:35 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface Patchwork
2019-04-11 14:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev3) Patchwork
2019-04-11 18:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a1a1618-541b-2bd6-5a80-3ce6e71edfb9@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox