Re: [PATCH i-g-t] tests/amd_queue_reset: fix dynamic subtest issue for amd queue reset

[vitaly prosyak <vprosyak@amd.com>]

The changed looks good to me.

Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>

On 2024-08-12 03:50, Jesse.zhang@amd.com wrote:
> Correct the usage of igt_dynamic_f or it always print SUCCESS, like this:
>
> Starting subtest: amdgpu-gfx-CMD_STREAM_EXEC_INVALID_OPCODE
> Starting dynamic subtest: amdgpu-CMD_STREAM_EXEC_INVALID_OPCODE-1
> Dynamic subtest amdgpu-CMD_STREAM_EXEC_INVALID_OPCODE-1: SUCCESS (0.000s)
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
>
> Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
> ---
>  tests/amdgpu/amd_queue_reset.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/amdgpu/amd_queue_reset.c b/tests/amdgpu/amd_queue_reset.c
> index 1a128265a..729286d82 100644
> --- a/tests/amdgpu/amd_queue_reset.c
> +++ b/tests/amdgpu/amd_queue_reset.c
> @@ -1000,9 +1000,8 @@ igt_main
>  			igt_describe("Stressful-and-multiple-cs-of-bad and good length-operations-using-multiple-processes");
>  			igt_subtest_with_dynamic_f("amdgpu-%s-%s", ip_tests[i] == AMD_IP_COMPUTE ? "COMPUTE":"GRAPHIX", it->name) {
>  				if (arr_cap[ip_tests[i]] && get_next_rings(ring_id_good, info, &ring_id_good, &ring_id_bad, i)) {
> -					igt_dynamic_f("amdgpu-%s-ring-good-%d-bad-%d-%s", it->name,ring_id_good, ring_id_bad, ip_tests[i] == AMD_IP_COMPUTE ? "COMPUTE":"GRAPHIX");
> -					set_next_test_to_run(sh_mem, it->test,
> -							ip_background, ip_tests[i], ring_id_good, ring_id_bad);
> +					igt_dynamic_f("amdgpu-%s-ring-good-%d-bad-%d-%s", it->name,ring_id_good, ring_id_bad, ip_tests[i] == AMD_IP_COMPUTE ? "COMPUTE":"GRAPHIX")
> +					set_next_test_to_run(sh_mem, it->test, ip_background, ip_tests[i], ring_id_good, ring_id_bad);
>  				}
>  			}
>  		}