Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/amd_queue_reset: fix dynamic subtest issue for amd queue reset
@ 2024-08-12  7:50 Jesse.zhang@amd.com
  2024-08-12 12:27 ` ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Jesse.zhang@amd.com @ 2024-08-12  7:50 UTC (permalink / raw)
  To: igt-dev
  Cc: Vitaly Prosyak, Alex Deucher, Christian Koenig,
	Jesse.zhang@amd.com, Kamil Konieczny

Correct the usage of igt_dynamic_f or it always print SUCCESS, like this:

Starting subtest: amdgpu-gfx-CMD_STREAM_EXEC_INVALID_OPCODE
Starting dynamic subtest: amdgpu-CMD_STREAM_EXEC_INVALID_OPCODE-1
Dynamic subtest amdgpu-CMD_STREAM_EXEC_INVALID_OPCODE-1: SUCCESS (0.000s)

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>

Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
---
 tests/amdgpu/amd_queue_reset.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/amdgpu/amd_queue_reset.c b/tests/amdgpu/amd_queue_reset.c
index 1a128265a..729286d82 100644
--- a/tests/amdgpu/amd_queue_reset.c
+++ b/tests/amdgpu/amd_queue_reset.c
@@ -1000,9 +1000,8 @@ igt_main
 			igt_describe("Stressful-and-multiple-cs-of-bad and good length-operations-using-multiple-processes");
 			igt_subtest_with_dynamic_f("amdgpu-%s-%s", ip_tests[i] == AMD_IP_COMPUTE ? "COMPUTE":"GRAPHIX", it->name) {
 				if (arr_cap[ip_tests[i]] && get_next_rings(ring_id_good, info, &ring_id_good, &ring_id_bad, i)) {
-					igt_dynamic_f("amdgpu-%s-ring-good-%d-bad-%d-%s", it->name,ring_id_good, ring_id_bad, ip_tests[i] == AMD_IP_COMPUTE ? "COMPUTE":"GRAPHIX");
-					set_next_test_to_run(sh_mem, it->test,
-							ip_background, ip_tests[i], ring_id_good, ring_id_bad);
+					igt_dynamic_f("amdgpu-%s-ring-good-%d-bad-%d-%s", it->name,ring_id_good, ring_id_bad, ip_tests[i] == AMD_IP_COMPUTE ? "COMPUTE":"GRAPHIX")
+					set_next_test_to_run(sh_mem, it->test, ip_background, ip_tests[i], ring_id_good, ring_id_bad);
 				}
 			}
 		}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-13  1:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12  7:50 [PATCH i-g-t] tests/amd_queue_reset: fix dynamic subtest issue for amd queue reset Jesse.zhang@amd.com
2024-08-12 12:27 ` ✗ GitLab.Pipeline: warning for " Patchwork
2024-08-12 12:44 ` ✓ CI.xeBAT: success " Patchwork
2024-08-12 12:57 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-12 16:21 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-12 23:43 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-13  1:03 ` [PATCH i-g-t] " vitaly prosyak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox