Re: [igt-dev] [PATCH v2 2/2] add DROP_SUSPEND.

[Caz Yokoyama <Caz.Yokoyama@intel.com>]

On Tue, 2019-03-12 at 15:51 +0000, Chris Wilson wrote:
> Quoting Caz Yokoyama (2019-03-12 15:52:09)
> > On Tue, 2019-03-12 at 15:30 +0000, Chris Wilson wrote:
> > > Quoting Caz Yokoyama (2019-03-12 03:31:32)
> > > > +       if (val & DROP_SUSPEND) {
> > > > +               struct device *dev = i915->drm.dev;
> > > > +
> > > > +               dev_info(dev, "%s() %d: runtime_status: %d\n",
> > > > __func__, __LINE__,
> > > > +                        dev->power.runtime_status);
> > > 
> > > 
> > > > +               pm_runtime_disable(dev);
> > > > +               if (!pm_runtime_status_suspended(dev)) {
> > > > +                       dev_warn(dev, "%s() %d: runtime_status:
> > > > %d\n", __func__, __LINE__,
> > > > +                                dev->power.runtime_status);
> > > > +               }
> > > > +               pm_runtime_enable(dev);
> > > 
> > > ret = pm_runtime_force_suspend(i915->drm.dev);
> > > 
> > 
> > Yes, this works. However, pm_runtime_force_suspend() always exits
> > on 
> >         if (pm_runtime_status_suspended(dev))
> >                 return 0;
> > Therefore, this patch is meaningless after suspended state.
> 
> Which would be fine for DROP_SUSPEND. Ah, so your intent is to do a
> DROP_WAKE as well :)

My intention is to remove gem-execbuf-stress-extra-wait subtest
because it does same as gem-execbuf-stress except for meaningless (10 x
5 sec) delay.

DROP_WAKE is a joke, correct? The runtime of gem-execbuf-stress is 1.5
sec. or less. It is quick enough.
-caz

> -Chris

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev