From: Caz Yokoyama <Caz.Yokoyama@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH v2 2/2] add DROP_SUSPEND.
Date: Tue, 12 Mar 2019 15:36:49 -0700 [thread overview]
Message-ID: <993f036ff566405f4ba1400e869d11616b2fe1d9.camel@intel.com> (raw)
In-Reply-To: <036722020211f41dd4123fbffab4c41ef3be1607.camel@intel.com>
On Tue, 2019-03-12 at 08:52 -0700, Caz Yokoyama wrote:
> On Tue, 2019-03-12 at 15:30 +0000, Chris Wilson wrote:
> > Quoting Caz Yokoyama (2019-03-12 03:31:32)
> > > + if (val & DROP_SUSPEND) {
> > > + struct device *dev = i915->drm.dev;
> > > +
> > > + dev_info(dev, "%s() %d: runtime_status: %d\n",
> > > __func__, __LINE__,
> > > + dev->power.runtime_status);
> >
> >
> > > + pm_runtime_disable(dev);
> > > + if (!pm_runtime_status_suspended(dev)) {
> > > + dev_warn(dev, "%s() %d: runtime_status:
> > > %d\n", __func__, __LINE__,
> > > + dev->power.runtime_status);
> > > + }
> > > + pm_runtime_enable(dev);
> >
> > ret = pm_runtime_force_suspend(i915->drm.dev);
> >
>
> Yes, this works. However, pm_runtime_force_suspend() always exits on
> if (pm_runtime_status_suspended(dev))
> return 0;
Correction. This does not work because of kernel crash. When exiting
from pm_runtime_force_suspend() by pm_runtime_status_suspended(dev) ==
true, pm_runtime_enable(dev) is not called. It looks a bug for me.
-caz
> Therefore, this patch is meaningless after suspended state.
> -caz
>
> > -Chris
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-12 22:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 3:31 [igt-dev] [PATCH i-g-t v2 1/1] i915_pm_rpm: gem-execbuf-stress-extra-wait faster Caz Yokoyama
2019-03-12 3:31 ` [igt-dev] [PATCH v2 2/2] add DROP_SUSPEND Caz Yokoyama
2019-03-12 15:30 ` Chris Wilson
2019-03-12 15:52 ` Caz Yokoyama
2019-03-12 15:51 ` Chris Wilson
2019-03-12 16:11 ` Caz Yokoyama
2019-03-12 16:09 ` Chris Wilson
2019-03-12 17:14 ` Caz Yokoyama
2019-03-12 22:36 ` Caz Yokoyama [this message]
2019-03-12 22:42 ` Chris Wilson
2019-03-12 15:14 ` [igt-dev] [PATCH i-g-t v2 1/1] i915_pm_rpm: gem-execbuf-stress-extra-wait faster Caz Yokoyama
2019-03-12 15:24 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=993f036ff566405f4ba1400e869d11616b2fe1d9.camel@intel.com \
--to=caz.yokoyama@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox