Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915/i915_suspend: Add system-suspend-without-i915 subtest

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Tauro, Riana <riana.tauro@intel.com>
> Sent: Monday, March 28, 2022 12:17 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Tauro, Riana <riana.tauro@intel.com>; Gupta, Anshuman
> <anshuman.gupta@intel.com>; Ewins, Jon <jon.ewins@intel.com>; Dixit,
> Ashutosh <ashutosh.dixit@intel.com>
> Subject: [PATCH i-g-t 1/2] tests/i915/i915_suspend: Add system-suspend-
> without-i915 subtest
> 
> From: "Tauro, Riana" <riana.tauro@intel.com>
> 
> Add a new subtest system-suspend-without-i915 to exercise suspend/resume
> cycle without i915 module to know the system wide health of suspend/resume
> feature.
> This test will be part of CI fast-feedback test list.
> 
> v2: Addressing review comments
Please mention the individual addressed comment ,  so that it is easy for incremental review.
> 
> Signed-off-by: Tauro, Riana <riana.tauro@intel.com>
> ---
>  tests/i915/i915_suspend.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c index
> da27ce09..a610a16d 100644
> --- a/tests/i915/i915_suspend.c
> +++ b/tests/i915/i915_suspend.c
> @@ -41,6 +41,7 @@
>  #include "i915/gem.h"
>  #include "i915/gem_create.h"
>  #include "igt.h"
> +#include "igt_kmod.h"
>  #include "igt_device.h"
> 
>  #define OBJECT_SIZE (16*1024*1024)
> @@ -202,10 +203,25 @@ test_forcewake(int fd, bool hibernate)
>  	close (fw_fd);
>  }
> 
> +static void
> +test_suspend_without_i915(void)
> +{
We need one more log here "Unloading i915".
> +	igt_i915_driver_unload();
Add an assertion with igt_assert(igt_i915_driver_unload() == 0);
With all of comment addressed.
 Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
Thanks,
Anshuman Gupta.
> +
> +	igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> SUSPEND_TEST_NONE);
> +
> +	igt_kmsg(KMSG_INFO "Re-loading i915 \n");
> +	igt_assert_eq(igt_i915_driver_load(NULL), 0); }
> +
>  int fd;
> 
>  igt_main
>  {
> +	igt_describe("Validate system suspend cycle without i915 module");
> +	igt_subtest("system-suspend-without-i915")
> +		test_suspend_without_i915();
> +
>  	igt_fixture
>  		fd = drm_open_driver(DRIVER_INTEL);
> 
> --
> 2.25.1