Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/i915/i915_suspend: Add system-suspend-without-i915 subtest

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 28 Mar 2022 03:13:39 -0700, Riana Tauro wrote:
>
> From: "Tauro, Riana" <riana.tauro@intel.com>
>
> Add a new subtest system-suspend-without-i915 to exercise suspend/resume cycle
> without i915 module to know the system wide health of suspend/resume feature.
> This test will be part of CI fast-feedback test list.
>
> v2:
> -Remove drm_cancel_work_at_exit.
> -Add igt_describe. [Anshuman]
>
> v3 : Added assertion on unload module.[Anshuman]

No need to use a period after these small comments, they look weird. Period
at the end of longer comments are fine. Please look at 'git log' for
examples.

> @@ -202,10 +203,26 @@ test_forcewake(int fd, bool hibernate)
>	close (fw_fd);
>  }
>
> +static void
> +test_suspend_without_i915(void)
> +{
> +	igt_kmsg(KMSG_INFO "Unloading i915\n");
> +	igt_assert_eq(igt_i915_driver_unload(),0);
> +
> +	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);

Do we need any other suspend/resume tests without i915 or just this is
sufficient? Anyway this is fine for now, we can add more if needed later.