From: "Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>
To: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt
Date: Mon, 20 Apr 2026 00:13:46 +0530 [thread overview]
Message-ID: <6db9ce20-bd93-44c0-8f1a-54104b76432e@intel.com> (raw)
In-Reply-To: <20260323162911.1912755-7-juhapekka.heikkila@gmail.com>
Hi JP,
On 3/23/2026 9:59 PM, Juha-Pekka Heikkila wrote:
> Add __xe_bb_exec path to use specific engine/class/gt
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> lib/intel_batchbuffer.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index a3fa58b4f..5c0597869 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -2522,7 +2522,17 @@ int __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
> igt_assert_eq(ibb->num_relocs, 0);
> igt_assert_eq(ibb->xe_bound, false);
>
> - if (ibb->ctx) {
> + if (ibb->gt_id) {
> + unsigned short class = get_engine_class(ibb->fd, flags);
> +
> + if (ibb->engine_id)
> + xe_exec_queue_destroy(ibb->fd, ibb->engine_id);
> +
> + ibb->engine_id = engine_id = xe_exec_queue_create_class_gt(ibb->fd,
> + ibb->vm_id,
> + class,
> + ibb->gt_id);
> + } else if (ibb->ctx) {
> engine_id = ibb->ctx;
> } else if (ibb->last_engine != engine) {
> struct drm_xe_engine_class_instance inst = { };
LGTM,
Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
next prev parent reply other threads:[~2026-04-19 18:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:29 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-23 16:29 ` [PATCH i-g-t 1/8] lib: take out duplicate assert Juha-Pekka Heikkila
2026-03-23 16:29 ` [PATCH i-g-t 2/8] lib/intel_batchbuffer: make __intel_bb_create gt aware Juha-Pekka Heikkila
2026-04-18 4:26 ` Naladala, Ramanaidu
2026-03-23 16:29 ` [PATCH i-g-t 3/8] lib/xe: add xe_exec_queue_create_class_gt Juha-Pekka Heikkila
2026-04-19 14:52 ` Naladala, Ramanaidu
2026-03-23 16:29 ` [PATCH i-g-t 4/8] lib/intel_batchbuffer: add intel_bb_create_with_gt function Juha-Pekka Heikkila
2026-04-19 15:23 ` Naladala, Ramanaidu
2026-03-23 16:29 ` [PATCH i-g-t 5/8] lib/intel_batchbuffer: move engine class selection to helper Juha-Pekka Heikkila
2026-04-19 15:58 ` Naladala, Ramanaidu
2026-03-23 16:29 ` [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt Juha-Pekka Heikkila
2026-04-19 18:43 ` Naladala, Ramanaidu [this message]
2026-03-23 16:29 ` [PATCH i-g-t 7/8] lib: Enable Vebox framebuffer copying on Intel Xe2 Juha-Pekka Heikkila
2026-04-13 12:50 ` Maarten Lankhorst
2026-03-23 16:29 ` [PATCH i-g-t 8/8] lib/igt_fb: on Intel Xe force Vebox copy on yuv formats Juha-Pekka Heikkila
2026-04-13 12:46 ` Maarten Lankhorst
2026-03-23 18:56 ` ✓ Xe.CI.BAT: success for Enable Vebox engine copy on Intel Xe driver (rev10) Patchwork
2026-03-23 19:03 ` ✗ i915.CI.BAT: failure " Patchwork
2026-03-24 2:14 ` ✗ Xe.CI.FULL: " Patchwork
2026-03-24 11:03 ` ✓ Xe.CI.BAT: success for Enable Vebox engine copy on Intel Xe driver (rev11) Patchwork
2026-03-24 11:18 ` ✓ i915.CI.BAT: " Patchwork
2026-03-24 17:59 ` ✗ i915.CI.Full: failure " Patchwork
2026-03-24 20:14 ` ✗ Xe.CI.FULL: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2026-03-20 13:46 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-20 13:46 ` [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt Juha-Pekka Heikkila
2026-03-18 15:05 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-18 15:05 ` [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt Juha-Pekka Heikkila
2026-03-13 13:51 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-13 13:52 ` [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt Juha-Pekka Heikkila
2026-02-20 16:17 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db9ce20-bd93-44c0-8f1a-54104b76432e@intel.com \
--to=ramanaidu.naladala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox