public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: Wait for an extra vblank
@ 2020-04-16  6:10 Mika Kahola
  2020-04-16  6:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Wait for an extra vblank (rev4) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Mika Kahola @ 2020-04-16  6:10 UTC (permalink / raw)
  To: igt-dev

kms_cursor_legacy IGT subtest 2x-nonblocking-modeset-vs-cursor-atomic
is failing due to busyness while trying to do atomic commit. In case,
we are busy, let's just wait one extra vblank before continuing the
test.

References: https://gitlab.freedesktop.org/drm/intel/issues/1062

v2: Wait out for max 5 seconds for commit busyness (Juha-Pekka)

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_cursor_legacy.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index d5f95b8d..6467e646 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -927,7 +927,11 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
 
 		if (ret == -EBUSY) {
 			/* Force completion on both pipes, and generate event. */
-			igt_display_commit_atomic(display, flags, NULL);
+			while (ret == -EBUSY) {
+				igt_set_timeout(5, "stuck with -EBUSY");
+				igt_wait_for_vblank(display->drm_fd, pipe);
+				ret = igt_display_try_commit_atomic(display, flags, NULL);
+			}
 
 			while (nloops--) {
 				shared[1] = nloops & 1;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-17  6:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-16  6:10 [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: Wait for an extra vblank Mika Kahola
2020-04-16  6:58 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Wait for an extra vblank (rev4) Patchwork
2020-04-16  9:56 ` [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: Wait for an extra vblank Juha-Pekka Heikkila
2020-04-16 11:32   ` Kahola, Mika
2020-04-17  2:59 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_cursor_legacy: Wait for an extra vblank (rev4) Patchwork
2020-04-17  6:58   ` Kahola, Mika

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox