Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all
@ 2022-10-18  9:09 Kamil Konieczny
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding Kamil Konieczny
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Kamil Konieczny @ 2022-10-18  9:09 UTC (permalink / raw)
  To: igt-dev

Allow to select all (up to 16) discrete cards with the help of
card=all or card=*, for example:

./gem_basic --device=pci:vendor=intel,device=discrete,card=all

Kamil Konieczny (2):
  lib/igt_device_scan: refactor filer adding
  lib/igt_device_scan: add card=all filter selector

 lib/igt_device_scan.c | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

-- 
2.34.1

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding
  2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
@ 2022-10-18  9:10 ` Kamil Konieczny
  2022-10-18 15:12   ` Zbigniew Kempczyński
  2022-10-18 15:13   ` Zbigniew Kempczyński
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: add card=all filter selector Kamil Konieczny
                   ` (4 subsequent siblings)
  5 siblings, 2 replies; 12+ messages in thread
From: Kamil Konieczny @ 2022-10-18  9:10 UTC (permalink / raw)
  To: igt-dev

Refactor filter adding loop.

Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/igt_device_scan.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 15be3844..6f5b90e6 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -1775,13 +1775,15 @@ int igt_device_filter_add(const char *filters)
 
 	while ((filter = strsep(&dup, ";"))) {
 		bool is_valid = is_filter_valid(filter);
+		struct device_filter *df;
 		igt_warn_on(!is_valid);
-		if (is_valid) {
-			struct device_filter *df = malloc(sizeof(*df));
-			strncpy(df->filter, filter, sizeof(df->filter)-1);
-			igt_list_add_tail(&df->link, &device_filters);
-			count++;
-		}
+		if (!is_valid)
+			continue;
+
+		df = malloc(sizeof(*df));
+		strncpy(df->filter, filter, sizeof(df->filter)-1);
+		igt_list_add_tail(&df->link, &device_filters);
+		count++;
 	}
 
 	free(dup_orig);
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: add card=all filter selector
  2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding Kamil Konieczny
@ 2022-10-18  9:10 ` Kamil Konieczny
  2022-10-18 10:56   ` Petri Latvala
  2022-10-18  9:38 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_device_scan: add filer card=all Patchwork
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Kamil Konieczny @ 2022-10-18  9:10 UTC (permalink / raw)
  To: igt-dev

Allow to select all discrete cards on system with the help of
card=all or card=* filter, for example:

pci:vendor=intel,device=discrete,card=all

or

pci:vendor=intel,device=discrete,card=*

This will add max of 16 cards filters with card=0..15

Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/igt_device_scan.c | 36 +++++++++++++++++++++++++++++++++---
 1 file changed, 33 insertions(+), 3 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 6f5b90e6..55840b4f 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -120,6 +120,13 @@
  *
  *   It selects the second one.
  *
+ *   |[<!-- language="plain" -->
+ *   pci:vendor=8086,device=1234,card=all
+ *   pci:vendor=8086,device=1234,card=*
+ *   ]|
+ *
+ *   This will add 0..15 card selectors.
+ *
  *   We may use device codename or pseudo-codename (integrated/discrete)
  *   instead of pci device id:
  *
@@ -1753,6 +1760,8 @@ static bool is_filter_valid(const char *fstr)
 	return true;
 }
 
+#define MAX_PCI_CARDS 16
+
 /**
  * igt_device_filter_add
  * @filters: filter(s) to be stored in filter array
@@ -1776,14 +1785,35 @@ int igt_device_filter_add(const char *filters)
 	while ((filter = strsep(&dup, ";"))) {
 		bool is_valid = is_filter_valid(filter);
 		struct device_filter *df;
+		char *multi;
+
 		igt_warn_on(!is_valid);
 		if (!is_valid)
 			continue;
 
 		df = malloc(sizeof(*df));
-		strncpy(df->filter, filter, sizeof(df->filter)-1);
-		igt_list_add_tail(&df->link, &device_filters);
-		count++;
+		if (!strncmp(filter, "sriov:", 6)) {
+			multi = NULL;
+		} else {
+			multi = strstr(filter, "card=all");
+			if (!multi)
+				multi = strstr(filter, "card=*");
+		}
+
+		if (!multi) {
+			strncpy(df->filter, filter, sizeof(df->filter)-1);
+			igt_list_add_tail(&df->link, &device_filters);
+			count++;
+		} else {
+			multi[5] = 0;
+			for (int i = 0; i < MAX_PCI_CARDS; ++i) {
+				if (i)
+					df = malloc(sizeof(*df));
+				snprintf(df->filter, sizeof(df->filter)-1, "%s%d", filter, i);
+				igt_list_add_tail(&df->link, &device_filters);
+				count++;
+			}
+		}
 	}
 
 	free(dup_orig);
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_device_scan: add filer card=all
  2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding Kamil Konieczny
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: add card=all filter selector Kamil Konieczny
@ 2022-10-18  9:38 ` Patchwork
  2022-10-18  9:51 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-10-18  9:38 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 5149 bytes --]

== Series Details ==

Series: lib/igt_device_scan: add filer card=all
URL   : https://patchwork.freedesktop.org/series/109824/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12254 -> IGTPW_7976
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/index.html

Participating hosts (45 -> 44)
------------------------------

  Additional (2): fi-hsw-4770 bat-atsm-1 
  Missing    (3): fi-bdw-samus fi-icl-u2 fi-kbl-guc 

Known issues
------------

  Here are the changes found in IGTPW_7976 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_gttfill@basic:
    - fi-pnv-d510:        [PASS][1] -> [FAIL][2] ([i915#7229])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-pnv-d510/igt@gem_exec_gttfill@basic.html

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-bdw-gvtdvm:      NOTRUN -> [INCOMPLETE][3] ([i915#146])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-bdw-gvtdvm/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@gem_tiled_blits@basic:
    - fi-pnv-d510:        [PASS][4] -> [SKIP][5] ([fdo#109271])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/fi-pnv-d510/igt@gem_tiled_blits@basic.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-pnv-d510/igt@gem_tiled_blits@basic.html

  * igt@i915_pm_backlight@basic-brightness:
    - fi-hsw-4770:        NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3012])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html

  * igt@i915_pm_rpm@module-reload:
    - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][7] ([i915#7221])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-hsw-4770/igt@i915_pm_rpm@module-reload.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - fi-hsw-4770:        NOTRUN -> [SKIP][8] ([fdo#109271]) +9 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-hsw-4770:        NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +7 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_psr@sprite_plane_onoff:
    - fi-hsw-4770:        NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1072]) +3 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html

  * igt@runner@aborted:
    - fi-hsw-4770:        NOTRUN -> [FAIL][11] ([fdo#109271] / [i915#4312] / [i915#5594])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-hsw-4770/igt@runner@aborted.html

  
#### Warnings ####

  * igt@i915_suspend@basic-s3-without-i915:
    - fi-bdw-gvtdvm:      [INCOMPLETE][12] ([i915#146]) -> [FAIL][13] ([fdo#103375])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/fi-bdw-gvtdvm/igt@i915_suspend@basic-s3-without-i915.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/fi-bdw-gvtdvm/igt@i915_suspend@basic-s3-without-i915.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
  [i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
  [i915#7221]: https://gitlab.freedesktop.org/drm/intel/issues/7221
  [i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7018 -> IGTPW_7976

  CI-20190529: 20190529
  CI_DRM_12254: 2e6cdde56f896add665edb8d2f6d3dfce8b1b3b6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7976: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/index.html
  IGT_7018: 8312a2fe3f3287ba4ac4bc8d100de0734480f482 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

-igt@gem_exec3_balancer@parallel-ordering
-igt@gem_exec3_basic@basic
-igt@gem_lmem_swapping@vm_bind
-igt@i915_vm_bind_basic@2m
-igt@i915_vm_bind_basic@64k
-igt@i915_vm_bind_basic@basic
-igt@i915_vm_bind_basic@multi_cmds
-igt@i915_vm_bind_basic@multi_ctxts
-igt@i915_vm_bind_basic@share_vm
-igt@i915_vm_bind_basic@skip_copy
-igt@i915_vm_bind_basic@skip_unbind
-igt@i915_vm_bind_sanity@basic

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/index.html

[-- Attachment #2: Type: text/html, Size: 6379 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] ✗ GitLab.Pipeline: warning for lib/igt_device_scan: add filer card=all
  2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
                   ` (2 preceding siblings ...)
  2022-10-18  9:38 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_device_scan: add filer card=all Patchwork
@ 2022-10-18  9:51 ` Patchwork
  2022-10-18 16:06 ` [igt-dev] [PATCH i-g-t 0/2] " Tvrtko Ursulin
  2022-10-19  8:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
  5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-10-18  9:51 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

== Series Details ==

Series: lib/igt_device_scan: add filer card=all
URL   : https://patchwork.freedesktop.org/series/109824/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/714268 for the overview.

test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/29929918):
  Ok:                   23
  Expected Fail:         4
  Fail:                293
  Unexpected Pass:       0
  Skipped:               0
  Timeout:               0
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  section_end:1666086119:step_script
  section_start:1666086119:upload_artifacts_on_failure
  Uploading artifacts for failed job
  Uploading artifacts...
  build: found 1789 matching files and directories   
  Uploading artifacts as "archive" to coordinator... 201 Created  id=29929918 responseStatus=201 Created token=t_By4-M3
  section_end:1666086128:upload_artifacts_on_failure
  section_start:1666086128:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1666086129:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/714268

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: add card=all filter selector
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: add card=all filter selector Kamil Konieczny
@ 2022-10-18 10:56   ` Petri Latvala
  0 siblings, 0 replies; 12+ messages in thread
From: Petri Latvala @ 2022-10-18 10:56 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

On Tue, Oct 18, 2022 at 11:10:01AM +0200, Kamil Konieczny wrote:
> Allow to select all discrete cards on system with the help of
> card=all or card=* filter, for example:
> 
> pci:vendor=intel,device=discrete,card=all
> 
> or
> 
> pci:vendor=intel,device=discrete,card=*
> 
> This will add max of 16 cards filters with card=0..15
> 
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  lib/igt_device_scan.c | 36 +++++++++++++++++++++++++++++++++---
>  1 file changed, 33 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 6f5b90e6..55840b4f 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -120,6 +120,13 @@
>   *
>   *   It selects the second one.
>   *
> + *   |[<!-- language="plain" -->
> + *   pci:vendor=8086,device=1234,card=all
> + *   pci:vendor=8086,device=1234,card=*
> + *   ]|
> + *
> + *   This will add 0..15 card selectors.
> + *
>   *   We may use device codename or pseudo-codename (integrated/discrete)
>   *   instead of pci device id:
>   *
> @@ -1753,6 +1760,8 @@ static bool is_filter_valid(const char *fstr)
>  	return true;
>  }
>  
> +#define MAX_PCI_CARDS 16
> +

From an offline discussion:

16 is not enough. The limit for dri devices at this time is 64 and
it's being raised to 512k.

The current code does a blind filter splat to add 16 separate filters,
we could maybe enumerate all devices (with or without matching
anything) and use that as the loop limit. Then we get a number of
individual filters that is >= the matching amount, which works for all
cases. What do you think?


-- 
Petri Latvala




>  /**
>   * igt_device_filter_add
>   * @filters: filter(s) to be stored in filter array
> @@ -1776,14 +1785,35 @@ int igt_device_filter_add(const char *filters)
>  	while ((filter = strsep(&dup, ";"))) {
>  		bool is_valid = is_filter_valid(filter);
>  		struct device_filter *df;
> +		char *multi;
> +
>  		igt_warn_on(!is_valid);
>  		if (!is_valid)
>  			continue;
>  
>  		df = malloc(sizeof(*df));
> -		strncpy(df->filter, filter, sizeof(df->filter)-1);
> -		igt_list_add_tail(&df->link, &device_filters);
> -		count++;
> +		if (!strncmp(filter, "sriov:", 6)) {
> +			multi = NULL;
> +		} else {
> +			multi = strstr(filter, "card=all");
> +			if (!multi)
> +				multi = strstr(filter, "card=*");
> +		}
> +
> +		if (!multi) {
> +			strncpy(df->filter, filter, sizeof(df->filter)-1);
> +			igt_list_add_tail(&df->link, &device_filters);
> +			count++;
> +		} else {
> +			multi[5] = 0;
> +			for (int i = 0; i < MAX_PCI_CARDS; ++i) {
> +				if (i)
> +					df = malloc(sizeof(*df));
> +				snprintf(df->filter, sizeof(df->filter)-1, "%s%d", filter, i);
> +				igt_list_add_tail(&df->link, &device_filters);
> +				count++;
> +			}
> +		}
>  	}
>  
>  	free(dup_orig);
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding Kamil Konieczny
@ 2022-10-18 15:12   ` Zbigniew Kempczyński
  2022-10-18 15:13   ` Zbigniew Kempczyński
  1 sibling, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2022-10-18 15:12 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

On Tue, Oct 18, 2022 at 11:10:00AM +0200, Kamil Konieczny wrote:
> Refactor filter adding loop.
> 
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  lib/igt_device_scan.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 15be3844..6f5b90e6 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1775,13 +1775,15 @@ int igt_device_filter_add(const char *filters)
>  
>  	while ((filter = strsep(&dup, ";"))) {
>  		bool is_valid = is_filter_valid(filter);
> +		struct device_filter *df;
>  		igt_warn_on(!is_valid);
> -		if (is_valid) {
> -			struct device_filter *df = malloc(sizeof(*df));
> -			strncpy(df->filter, filter, sizeof(df->filter)-1);
> -			igt_list_add_tail(&df->link, &device_filters);
> -			count++;
> -		}
> +		if (!is_valid)
> +			continue;
> +
> +		df = malloc(sizeof(*df));
> +		strncpy(df->filter, filter, sizeof(df->filter)-1);
> +		igt_list_add_tail(&df->link, &device_filters);
> +		count++;

Ok, avoiding long if-block looks better for me.

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew

>  	}
>  
>  	free(dup_orig);
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding
  2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding Kamil Konieczny
  2022-10-18 15:12   ` Zbigniew Kempczyński
@ 2022-10-18 15:13   ` Zbigniew Kempczyński
  1 sibling, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2022-10-18 15:13 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

On Tue, Oct 18, 2022 at 11:10:00AM +0200, Kamil Konieczny wrote:
> Refactor filter adding loop.

Eh, one thing not visible here - patch subject - s/filer/filter/

--
Zbigniew

> 
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  lib/igt_device_scan.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 15be3844..6f5b90e6 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1775,13 +1775,15 @@ int igt_device_filter_add(const char *filters)
>  
>  	while ((filter = strsep(&dup, ";"))) {
>  		bool is_valid = is_filter_valid(filter);
> +		struct device_filter *df;
>  		igt_warn_on(!is_valid);
> -		if (is_valid) {
> -			struct device_filter *df = malloc(sizeof(*df));
> -			strncpy(df->filter, filter, sizeof(df->filter)-1);
> -			igt_list_add_tail(&df->link, &device_filters);
> -			count++;
> -		}
> +		if (!is_valid)
> +			continue;
> +
> +		df = malloc(sizeof(*df));
> +		strncpy(df->filter, filter, sizeof(df->filter)-1);
> +		igt_list_add_tail(&df->link, &device_filters);
> +		count++;
>  	}
>  
>  	free(dup_orig);
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all
  2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
                   ` (3 preceding siblings ...)
  2022-10-18  9:51 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
@ 2022-10-18 16:06 ` Tvrtko Ursulin
  2022-10-19 11:43   ` Kamil Konieczny
  2022-10-19  8:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
  5 siblings, 1 reply; 12+ messages in thread
From: Tvrtko Ursulin @ 2022-10-18 16:06 UTC (permalink / raw)
  To: Kamil Konieczny, igt-dev


On 18/10/2022 10:09, Kamil Konieczny wrote:
> Allow to select all (up to 16) discrete cards with the help of
> card=all or card=*, for example:
> 
> ./gem_basic --device=pci:vendor=intel,device=discrete,card=all

What should this do btw? Run the tests on more than one card in 
sequence? Isn't that test runner's job?

Regards,

Tvrtko

> Kamil Konieczny (2):
>    lib/igt_device_scan: refactor filer adding
>    lib/igt_device_scan: add card=all filter selector
> 
>   lib/igt_device_scan.c | 36 ++++++++++++++++++++++++++++++++++--
>   1 file changed, 34 insertions(+), 2 deletions(-)
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_device_scan: add filer card=all
  2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
                   ` (4 preceding siblings ...)
  2022-10-18 16:06 ` [igt-dev] [PATCH i-g-t 0/2] " Tvrtko Ursulin
@ 2022-10-19  8:25 ` Patchwork
  5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-10-19  8:25 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 28042 bytes --]

== Series Details ==

Series: lib/igt_device_scan: add filer card=all
URL   : https://patchwork.freedesktop.org/series/109824/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12254_full -> IGTPW_7976_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_7976_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_7976_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/index.html

Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_7976_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_pread@exhaustion:
    - shard-apl:          NOTRUN -> [INCOMPLETE][1] +3 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl3/igt@gem_pread@exhaustion.html

  * igt@syncobj_wait@invalid-signal-zero-handles:
    - shard-apl:          NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl2/igt@syncobj_wait@invalid-signal-zero-handles.html
    - shard-tglb:         [PASS][3] -> [INCOMPLETE][4] +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb7/igt@syncobj_wait@invalid-signal-zero-handles.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@syncobj_wait@invalid-signal-zero-handles.html

  
Known issues
------------

  Here are the changes found in IGTPW_7976_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@device_reset@unbind-reset-rebind:
    - shard-snb:          [PASS][5] -> [DMESG-WARN][6] ([i915#4528])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-snb7/igt@device_reset@unbind-reset-rebind.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-snb6/igt@device_reset@unbind-reset-rebind.html

  * igt@feature_discovery@display-4x:
    - shard-tglb:         NOTRUN -> [SKIP][7] ([i915#1839])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@feature_discovery@display-4x.html

  * igt@gem_create@create-massive:
    - shard-apl:          NOTRUN -> [DMESG-WARN][8] ([i915#4991])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl2/igt@gem_create@create-massive.html

  * igt@gem_ctx_persistence@engines-cleanup:
    - shard-snb:          NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-snb6/igt@gem_ctx_persistence@engines-cleanup.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-tglb:         NOTRUN -> [FAIL][10] ([i915#2842])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_params@secure-non-root:
    - shard-tglb:         NOTRUN -> [SKIP][11] ([fdo#112283])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_exec_params@secure-non-root.html

  * igt@gem_huc_copy@huc-copy:
    - shard-apl:          NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#2190])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl8/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@parallel-random-verify:
    - shard-apl:          NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613]) +5 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl6/igt@gem_lmem_swapping@parallel-random-verify.html
    - shard-tglb:         NOTRUN -> [SKIP][14] ([i915#4613]) +3 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_lmem_swapping@parallel-random-verify.html

  * igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
    - shard-tglb:         NOTRUN -> [SKIP][15] ([i915#4270]) +2 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_pxp@verify-pxp-execution-after-suspend-resume.html

  * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
    - shard-apl:          NOTRUN -> [SKIP][16] ([fdo#109271]) +356 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl6/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html

  * igt@gem_userptr_blits@readonly-pwrite-unsync:
    - shard-tglb:         NOTRUN -> [SKIP][17] ([i915#3297]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_userptr_blits@readonly-pwrite-unsync.html

  * igt@gen7_exec_parse@oacontrol-tracking:
    - shard-tglb:         NOTRUN -> [SKIP][18] ([fdo#109289])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gen7_exec_parse@oacontrol-tracking.html

  * igt@gen9_exec_parse@bb-start-param:
    - shard-tglb:         NOTRUN -> [SKIP][19] ([i915#2527] / [i915#2856]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gen9_exec_parse@bb-start-param.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-tglb:         NOTRUN -> [INCOMPLETE][20] ([i915#7243])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pipe_stress@stress-xrgb8888-ytiled:
    - shard-apl:          NOTRUN -> [FAIL][21] ([i915#7036])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl3/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html

  * igt@i915_pm_freq_mult@media-freq@gt0:
    - shard-tglb:         NOTRUN -> [SKIP][22] ([i915#6590])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_pm_freq_mult@media-freq@gt0.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-apl:          NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#1937])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_lpsp@screens-disabled:
    - shard-tglb:         NOTRUN -> [SKIP][24] ([i915#1902])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_pm_lpsp@screens-disabled.html

  * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
    - shard-tglb:         NOTRUN -> [SKIP][25] ([fdo#111644] / [i915#1397])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html

  * igt@i915_pm_rpm@pc8-residency:
    - shard-tglb:         NOTRUN -> [SKIP][26] ([fdo#109506])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_pm_rpm@pc8-residency.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-apl:          NOTRUN -> [INCOMPLETE][27] ([i915#7241])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl8/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@i915_query@hwconfig_table:
    - shard-tglb:         NOTRUN -> [SKIP][28] ([i915#6245])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_query@hwconfig_table.html

  * igt@i915_query@query-topology-unsupported:
    - shard-tglb:         NOTRUN -> [SKIP][29] ([fdo#109302])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_query@query-topology-unsupported.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
    - shard-tglb:         NOTRUN -> [SKIP][30] ([i915#5286]) +5 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
    - shard-tglb:         [PASS][31] -> [FAIL][32] ([i915#3743]) +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][33] ([fdo#111614]) +4 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
    - shard-tglb:         NOTRUN -> [SKIP][34] ([fdo#111615]) +3 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html

  * igt@kms_big_joiner@2x-modeset:
    - shard-tglb:         NOTRUN -> [SKIP][35] ([i915#2705])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_big_joiner@2x-modeset.html

  * igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([fdo#111615] / [i915#3689]) +6 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
    - shard-tglb:         NOTRUN -> [SKIP][37] ([i915#6095]) +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][38] ([i915#3689] / [i915#6095]) +2 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs.html

  * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][39] ([i915#3689] / [i915#3886]) +4 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +16 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl2/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][41] ([i915#3689]) +9 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs.html

  * igt@kms_cdclk@mode-transition:
    - shard-tglb:         NOTRUN -> [SKIP][42] ([i915#3742])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_cdclk@mode-transition.html

  * igt@kms_chamelium@dp-hpd-fast:
    - shard-tglb:         NOTRUN -> [SKIP][43] ([fdo#109284] / [fdo#111827]) +7 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_chamelium@dp-hpd-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - shard-snb:          NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +5 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-snb7/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_chamelium@vga-hpd-after-suspend:
    - shard-apl:          NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +16 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl6/igt@kms_chamelium@vga-hpd-after-suspend.html

  * igt@kms_color@ctm-0-25@pipe-c-edp-1:
    - shard-tglb:         NOTRUN -> [FAIL][46] ([i915#315] / [i915#6946]) +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_color@ctm-0-25@pipe-c-edp-1.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-tglb:         NOTRUN -> [SKIP][47] ([i915#7118]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@atomic@pipe-a-dp-1:
    - shard-apl:          NOTRUN -> [INCOMPLETE][48] ([i915#7121] / [i915#7173]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl3/igt@kms_content_protection@atomic@pipe-a-dp-1.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-tglb:         NOTRUN -> [SKIP][49] ([i915#3116] / [i915#3299]) +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_cursor_crc@cursor-random-32x10:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([i915#3555]) +6 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_cursor_crc@cursor-random-32x10.html

  * igt@kms_cursor_legacy@cursora-vs-flipb@varying-size:
    - shard-tglb:         NOTRUN -> [SKIP][51] ([fdo#109274] / [fdo#111825]) +8 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_cursor_legacy@cursora-vs-flipb@varying-size.html

  * igt@kms_dp_tiled_display@basic-test-pattern:
    - shard-tglb:         NOTRUN -> [SKIP][52] ([i915#426])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_dp_tiled_display@basic-test-pattern.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-snb:          NOTRUN -> [FAIL][53] ([fdo#103375]) +2 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-snb2/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-flip-vs-modeset:
    - shard-tglb:         NOTRUN -> [SKIP][54] ([fdo#109274] / [fdo#111825] / [i915#3637]) +8 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_flip@2x-flip-vs-modeset.html

  * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode:
    - shard-tglb:         NOTRUN -> [SKIP][55] ([i915#2587] / [i915#2672]) +4 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt:
    - shard-tglb:         NOTRUN -> [SKIP][56] ([i915#6497]) +13 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu:
    - shard-snb:          NOTRUN -> [SKIP][57] ([fdo#109271]) +189 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-snb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
    - shard-tglb:         NOTRUN -> [SKIP][58] ([fdo#109280] / [fdo#111825]) +31 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d:
    - shard-tglb:         NOTRUN -> [SKIP][59] ([i915#6403]) +3 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d.html

  * igt@kms_plane_lowres@tiling-none@pipe-c-edp-1:
    - shard-tglb:         NOTRUN -> [SKIP][60] ([i915#3536]) +3 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_plane_lowres@tiling-none@pipe-c-edp-1.html

  * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-edp-1:
    - shard-tglb:         NOTRUN -> [SKIP][61] ([i915#5176]) +19 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-edp-1.html

  * igt@kms_prime@basic-modeset-hybrid:
    - shard-tglb:         NOTRUN -> [SKIP][62] ([i915#6524])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_prime@basic-modeset-hybrid.html

  * igt@kms_psr2_sf@cursor-plane-update-sf:
    - shard-tglb:         NOTRUN -> [SKIP][63] ([i915#2920])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_psr2_sf@cursor-plane-update-sf.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
    - shard-apl:          NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) +3 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html

  * igt@kms_psr2_su@frontbuffer-xrgb8888:
    - shard-tglb:         NOTRUN -> [SKIP][65] ([i915#7037])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_psr2_su@frontbuffer-xrgb8888.html

  * igt@kms_psr@psr2_sprite_mmap_cpu:
    - shard-tglb:         NOTRUN -> [FAIL][66] ([i915#132] / [i915#3467]) +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_psr@psr2_sprite_mmap_cpu.html

  * igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
    - shard-tglb:         [PASS][67] -> [SKIP][68] ([i915#5519])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html

  * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
    - shard-tglb:         NOTRUN -> [SKIP][69] ([fdo#111615] / [i915#5289]) +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html

  * igt@perf_pmu@rc6-suspend:
    - shard-apl:          NOTRUN -> [INCOMPLETE][70] ([i915#7235])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl1/igt@perf_pmu@rc6-suspend.html

  * igt@prime_vgem@coherency-gtt:
    - shard-tglb:         NOTRUN -> [SKIP][71] ([fdo#109295] / [fdo#111656])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@prime_vgem@coherency-gtt.html

  * igt@prime_vgem@fence-flip-hang:
    - shard-tglb:         NOTRUN -> [SKIP][72] ([fdo#109295])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@prime_vgem@fence-flip-hang.html

  * igt@sysfs_clients@fair-3:
    - shard-apl:          NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#2994]) +6 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl6/igt@sysfs_clients@fair-3.html

  * igt@sysfs_clients@sema-50:
    - shard-tglb:         NOTRUN -> [SKIP][74] ([i915#2994]) +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@sysfs_clients@sema-50.html

  
#### Possible fixes ####

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-tglb:         [FAIL][75] ([i915#6268]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb1/igt@gem_ctx_exec@basic-nohangcheck.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [SKIP][77] ([i915#2190]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb7/igt@gem_huc_copy@huc-copy.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_huc_copy@huc-copy.html

  * igt@i915_selftest@mock@requests:
    - shard-snb:          [INCOMPLETE][79] ([i915#7226]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-snb4/igt@i915_selftest@mock@requests.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-snb5/igt@i915_selftest@mock@requests.html
    - shard-tglb:         [INCOMPLETE][81] ([i915#7226]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb1/igt@i915_selftest@mock@requests.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@i915_selftest@mock@requests.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - shard-tglb:         [FAIL][83] ([i915#3743]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  
#### Warnings ####

  * igt@gem_pread@exhaustion:
    - shard-tglb:         [INCOMPLETE][85] ([i915#7244]) -> [WARN][86] ([i915#2658])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-tglb1/igt@gem_pread@exhaustion.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-tglb1/igt@gem_pread@exhaustion.html

  * igt@runner@aborted:
    - shard-apl:          ([FAIL][87], [FAIL][88], [FAIL][89], [FAIL][90], [FAIL][91]) ([fdo#109271] / [i915#3002] / [i915#4312]) -> ([FAIL][92], [FAIL][93], [FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98]) ([i915#3002] / [i915#4312])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-apl6/igt@runner@aborted.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-apl8/igt@runner@aborted.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-apl7/igt@runner@aborted.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-apl8/igt@runner@aborted.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12254/shard-apl7/igt@runner@aborted.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl2/igt@runner@aborted.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl6/igt@runner@aborted.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl2/igt@runner@aborted.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl1/igt@runner@aborted.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl7/igt@runner@aborted.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl8/igt@runner@aborted.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/shard-apl7/igt@runner@aborted.html

  
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
  [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
  [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
  [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7226]: https://gitlab.freedesktop.org/drm/intel/issues/7226
  [i915#7235]: https://gitlab.freedesktop.org/drm/intel/issues/7235
  [i915#7241]: https://gitlab.freedesktop.org/drm/intel/issues/7241
  [i915#7243]: https://gitlab.freedesktop.org/drm/intel/issues/7243
  [i915#7244]: https://gitlab.freedesktop.org/drm/intel/issues/7244


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7018 -> IGTPW_7976
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12254: 2e6cdde56f896add665edb8d2f6d3dfce8b1b3b6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7976: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/index.html
  IGT_7018: 8312a2fe3f3287ba4ac4bc8d100de0734480f482 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7976/index.html

[-- Attachment #2: Type: text/html, Size: 33152 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all
  2022-10-18 16:06 ` [igt-dev] [PATCH i-g-t 0/2] " Tvrtko Ursulin
@ 2022-10-19 11:43   ` Kamil Konieczny
  2022-10-21  8:14     ` Tvrtko Ursulin
  0 siblings, 1 reply; 12+ messages in thread
From: Kamil Konieczny @ 2022-10-19 11:43 UTC (permalink / raw)
  To: igt-dev

Hi Tvrtko,

On 2022-10-18 at 17:06:29 +0100, Tvrtko Ursulin wrote:
> 
> On 18/10/2022 10:09, Kamil Konieczny wrote:
> > Allow to select all (up to 16) discrete cards with the help of
> > card=all or card=*, for example:
> > 
> > ./gem_basic --device=pci:vendor=intel,device=discrete,card=all
> 
> What should this do btw? Run the tests on more than one card in sequence?
> Isn't that test runner's job?
> 
> Regards,
> Tvrtko

The purpose it to run test in parallel with the help of new fork
helper or with threads. See my RFC patchset (using fork)

https://patchwork.freedesktop.org/series/109487/
Add multi-process subtests for multi-GPUs

Regards,
Kamil

> 
> > Kamil Konieczny (2):
> >    lib/igt_device_scan: refactor filer adding
> >    lib/igt_device_scan: add card=all filter selector
> > 
> >   lib/igt_device_scan.c | 36 ++++++++++++++++++++++++++++++++++--
> >   1 file changed, 34 insertions(+), 2 deletions(-)
> > 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all
  2022-10-19 11:43   ` Kamil Konieczny
@ 2022-10-21  8:14     ` Tvrtko Ursulin
  0 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2022-10-21  8:14 UTC (permalink / raw)
  To: Kamil Konieczny, igt-dev


On 19/10/2022 12:43, Kamil Konieczny wrote:
> Hi Tvrtko,
> 
> On 2022-10-18 at 17:06:29 +0100, Tvrtko Ursulin wrote:
>>
>> On 18/10/2022 10:09, Kamil Konieczny wrote:
>>> Allow to select all (up to 16) discrete cards with the help of
>>> card=all or card=*, for example:
>>>
>>> ./gem_basic --device=pci:vendor=intel,device=discrete,card=all
>>
>> What should this do btw? Run the tests on more than one card in sequence?
>> Isn't that test runner's job?
>>
>> Regards,
>> Tvrtko
> 
> The purpose it to run test in parallel with the help of new fork
> helper or with threads. See my RFC patchset (using fork)
> 
> https://patchwork.freedesktop.org/series/109487/
> Add multi-process subtests for multi-GPUs

Those would be running completely independently - I mean no interaction 
between the GPUs like work handover, buffer sharing and that? If so my 
gut feeling is that the direction needs to be carefully considered. Test 
runner could do that just as well for probably much less complication. 
But that's just my opinion, so FWIW.

Regards,

Tvrtko

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-10-21  8:14 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-18  9:09 [igt-dev] [PATCH i-g-t 0/2] lib/igt_device_scan: add filer card=all Kamil Konieczny
2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan: refactor filer adding Kamil Konieczny
2022-10-18 15:12   ` Zbigniew Kempczyński
2022-10-18 15:13   ` Zbigniew Kempczyński
2022-10-18  9:10 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: add card=all filter selector Kamil Konieczny
2022-10-18 10:56   ` Petri Latvala
2022-10-18  9:38 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_device_scan: add filer card=all Patchwork
2022-10-18  9:51 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2022-10-18 16:06 ` [igt-dev] [PATCH i-g-t 0/2] " Tvrtko Ursulin
2022-10-19 11:43   ` Kamil Konieczny
2022-10-21  8:14     ` Tvrtko Ursulin
2022-10-19  8:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox