From: Matthew Auld <matthew.auld@intel.com>
To: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
Cc: igt-dev@lists.freedesktop.org, ayaz.siddiqui@intel.com
Subject: Re: [PATCH i-g-t v5 5/6] tests/intel/gem_ccs: Add compression support for Lunarlake
Date: Tue, 12 Dec 2023 09:31:31 +0000 [thread overview]
Message-ID: <77191af7-2f04-49fc-b317-ccb6a15f5e5c@intel.com> (raw)
In-Reply-To: <d57e380afd85e47a685684847ef2adfa709734e8.1702402592.git.akshata.jahagirdar@intel.com>
On 12/12/2023 17:39, Akshata Jahagirdar wrote:
> Update the ccs_ratio call to get value according to platform.
>
> Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
> ---
> tests/intel/gem_ccs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/gem_ccs.c b/tests/intel/gem_ccs.c
> index 0a691778d..5a17be4cb 100644
> --- a/tests/intel/gem_ccs.c
> +++ b/tests/intel/gem_ccs.c
> @@ -99,7 +99,7 @@ static void surf_copy(int i915,
> struct blt_block_copy_data_ext ext = {};
> struct blt_ctrl_surf_copy_data surf = {};
> uint32_t bb1, bb2, ccs, ccs2, *ccsmap, *ccsmap2;
> - uint64_t bb_size, ccssize = mid->size / CCS_RATIO;
> + uint64_t bb_size, ccssize = mid->size / (CCS_RATIO(i915));
This seems misplaced, should this rather be squashed into one of the
previous patches? CCS_RATIO now takes an argument, but that was done
earlier in the series.
> uint32_t *ccscopy;
> uint8_t uc_mocs = intel_get_uc_mocs_index(i915);
> int result;
next prev parent reply other threads:[~2023-12-12 9:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 17:39 [PATCH i-g-t v5 0/6] Compression support for Lunarlake Akshata Jahagirdar
2023-12-12 6:48 ` ✓ Fi.CI.BAT: success for " Patchwork
2023-12-12 7:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2023-12-12 8:13 ` ✓ CI.xeBAT: success " Patchwork
2023-12-12 17:39 ` [PATCH i-g-t v5 1/6] lib: Add blt command properties for lunarlake Akshata Jahagirdar
2023-12-12 17:39 ` [PATCH i-g-t v5 2/6] lib/intel_blt: Update calculation of ccs_size and size_of_ctrl_copy Akshata Jahagirdar
2023-12-12 9:28 ` Matthew Auld
2023-12-13 7:12 ` Jahagirdar, Akshata
2023-12-12 17:39 ` [PATCH i-g-t v5 3/6] lib/intel_pat: Add uc_comp pat_index Akshata Jahagirdar
2023-12-12 9:19 ` Matthew Auld
2023-12-13 7:08 ` Jahagirdar, Akshata
2023-12-12 17:39 ` [PATCH i-g-t v5 4/6] lib/intel_blt: Update caching mode and pat_index Akshata Jahagirdar
2023-12-12 9:24 ` Matthew Auld
2023-12-13 7:09 ` Jahagirdar, Akshata
2023-12-12 17:39 ` [PATCH i-g-t v5 5/6] tests/intel/gem_ccs: Add compression support for Lunarlake Akshata Jahagirdar
2023-12-12 9:31 ` Matthew Auld [this message]
2023-12-13 7:16 ` Jahagirdar, Akshata
2023-12-12 17:39 ` [PATCH i-g-t v5 6/6] tests/intel/xe_ccs: " Akshata Jahagirdar
[not found] <cover.1702386259.git.akshata.jahagirdar@intel.com>
2023-12-12 13:13 ` [PATCH i-g-t v5 5/6] tests/intel/gem_ccs: " Akshata Jahagirdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77191af7-2f04-49fc-b317-ccb6a15f5e5c@intel.com \
--to=matthew.auld@intel.com \
--cc=akshata.jahagirdar@intel.com \
--cc=ayaz.siddiqui@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox